[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-27 Thread GitBox
morhidi commented on code in PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#discussion_r883435675 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -63,7 +63,7 @@ public class FlinkC

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-27 Thread GitBox
morhidi commented on code in PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#discussion_r883435675 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -63,7 +63,7 @@ public class FlinkC

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-26 Thread GitBox
morhidi commented on code in PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#discussion_r882895802 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/informer/InformerManager.java: ## @@ -39,21 +43,24 @@ public class Infor

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-26 Thread GitBox
morhidi commented on code in PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#discussion_r882885678 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/deployment/AbstractDeploymentObserver.java: ## @@ -199,11 +199,

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-26 Thread GitBox
morhidi commented on code in PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#discussion_r882854951 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigManager.java: ## @@ -63,7 +63,7 @@ public class FlinkC

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #239: [FLINK-27714] Migrate to java-operator-sdk v3

2022-05-24 Thread GitBox
morhidi commented on code in PR #239: URL: https://github.com/apache/flink-kubernetes-operator/pull/239#discussion_r880370389 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/controller/FlinkDeploymentController.java: ## @@ -152,26 +160,71 @@ priv