Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5240
Thanks for the feedback @fhueske. I hope I could address most of it. I
think we should merge this PR (if you agree) and add more PRs for this issue as
the next steps. I suggest the following subtasks
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/5240
Hi Timo,
the PR looks good overall. I've made a few suggestion mostly about renaming
methods or extending docs. I'd also propose to add a `supportedProperties()`
method to `TableSourceFactor
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/5240
Thanks for the review @fhueske. I will merge this now. We definitely need
follow-up issues for this.
---