[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-11 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949876#comment-16949876 ] Jiayi Liao commented on FLINK-14296: [~dwysakowicz] [~jark] Thanks for pointing this out. The PR can

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-11 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16949350#comment-16949350 ] Jiayi Liao commented on FLINK-14296: [~jark] Sure. I'll update the PR very soon. > SqlNodes in the

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-09 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947578#comment-16947578 ] Jark Wu commented on FLINK-14296: - Hi [~wind_ljy], could you update the PR according to the discussion

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-09 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947521#comment-16947521 ] Dawid Wysakowicz commented on FLINK-14296: -- Sure, I'm fine with that approach. I just wanted to

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-09 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947516#comment-16947516 ] Jark Wu commented on FLINK-14296: - Thanks [~dwysakowicz], I think we should check not null for

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-09 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947486#comment-16947486 ] Dawid Wysakowicz commented on FLINK-14296: -- Sorry I made you wait for a response. I would

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-07 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946423#comment-16946423 ] Jark Wu commented on FLINK-14296: - Hi [~wind_ljy], thanks for the PR, but before submitting the PR, I

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945233#comment-16945233 ] Jiayi Liao commented on FLINK-14296: [~jark] > SqlNodes in the parser module should use an Optional

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-05 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945224#comment-16945224 ] Jark Wu commented on FLINK-14296: - I agree with [~wind_ljy]. {{SqlNodeList}} is a List of SqlNode. We

[jira] [Commented] (FLINK-14296) SqlNodes in the parser module should use an Optional for optional parameters

2019-10-01 Thread Jiayi Liao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-14296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941677#comment-16941677 ] Jiayi Liao commented on FLINK-14296: [~dawidwys] Actually the partitionKeyList / columnList /