[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256401#comment-17256401
]
Till Rohrmann commented on FLINK-16998:
---
Quick question [~twalthr]: Did this change break
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17124885#comment-17124885
]
Timo Walther commented on FLINK-16998:
--
Updating the `Row.toString` method will be postponed to
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112566#comment-17112566
]
Timo Walther commented on FLINK-16998:
--
Backwards compatibility added.
Fixed in 1.11.0:
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17110549#comment-17110549
]
Timo Walther commented on FLINK-16998:
--
Changeflag has been added. Backwards compatibility will
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17105469#comment-17105469
]
Timo Walther commented on FLINK-16998:
--
In order to unblock FLINK-14807, I will open a PR with the
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100521#comment-17100521
]
Timo Walther commented on FLINK-16998:
--
Thanks everyone for your feedback. So we go with no
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100403#comment-17100403
]
Jingsong Lee commented on FLINK-16998:
--
+1 to keep nested flag.
When introducing data structure,
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100373#comment-17100373
]
Kurt Young commented on FLINK-16998:
Keep internal row's header makes sense, especially when we want
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099947#comment-17099947
]
Dawid Wysakowicz commented on FLINK-16998:
--
Your discussion in the JIRA issue exactly reflects
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099753#comment-17099753
]
Timo Walther commented on FLINK-16998:
--
Unless we adjust our data structure converters and remove
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099750#comment-17099750
]
Jark Wu commented on FLINK-16998:
-
That's right... Then I think it's reasonable to make the RowKind
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099749#comment-17099749
]
Timo Walther commented on FLINK-16998:
--
Honestly, I would also prefer {{+I(12, 12, (Hello,
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099739#comment-17099739
]
Jark Wu commented on FLINK-16998:
-
I'm fine with this. Another choice is to make the {{RowKind}}
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099696#comment-17099696
]
Timo Walther commented on FLINK-16998:
--
[~jark] [~dwysakowicz] before I do the big refactoring of
[
https://issues.apache.org/jira/browse/FLINK-16998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17099675#comment-17099675
]
Tzu-Li (Gordon) Tai commented on FLINK-16998:
-
Blocked by FLINK-17520.
> Add a changeflag
15 matches
Mail list logo