[GitHub] [flink] bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception

2019-11-01 Thread GitBox
bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception URL: https://github.com/apache/flink/pull/10053#issuecomment-548984963 > Thanks for the contribution. The diff itself looks fine. However, wouldn't it b

[GitHub] [flink] bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception

2019-11-01 Thread GitBox
bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception URL: https://github.com/apache/flink/pull/10053#issuecomment-548941834 @dawidwys @lirui-apache @zjuwangg ---

[GitHub] [flink] bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception

2019-10-31 Thread GitBox
bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception URL: https://github.com/apache/flink/pull/10053#issuecomment-548600306 @dawidwys @xuefuz @lirui-apache @zjuwangg ---

[GitHub] [flink] bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception

2019-10-30 Thread GitBox
bowenli86 commented on issue #10053: [FLINK-14578][table] load/unloadModule() should throw RuntimeException rather than checked exception URL: https://github.com/apache/flink/pull/10053#issuecomment-548152941 @dawidwys @xuefuz @lirui-apache @zjuwangg --