[
https://issues.apache.org/jira/browse/FLINK-9381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-9381:
Component/s: JobManager
> BlobServer data for a job is not getting cleaned up at JM
> --
[
https://issues.apache.org/jira/browse/FLINK-9379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kostas Kloudas reassigned FLINK-9379:
-
Assignee: Kostas Kloudas
> HA end-to-end test failing locally
> -
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603431
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603410
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604321
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604517
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/EntryClassQueryParameter.java
---
@@ -28,4 +28,10 @@
public En
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603310
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603356
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604472
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AllowNonRestoredStateQueryParameter.java
---
@@ -42,4 +42,10 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188604063
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5985#discussion_r188603266
--- Diff: flink-core/src/main/java/org/apache/flink/util/StringUtils.java
---
@@ -348,6 +350,21 @@ public static String concatenateWithAnd(@Nullable
String s
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477331#comment-16477331
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477335#comment-16477335
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477329#comment-16477329
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477333#comment-16477333
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477330#comment-16477330
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477334#comment-16477334
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477336#comment-16477336
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477332#comment-16477332
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
[
https://issues.apache.org/jira/browse/FLINK-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477337#comment-16477337
]
ASF GitHub Bot commented on FLINK-8135:
---
Github user zentol commented on a diff in t
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6019
@sihuazhou my plan was to integrate the timer service more closely with the
keyed state backends, starting from the point that we are merging the PR for
timers in RocksDB. I think timers shoul
[
https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477353#comment-16477353
]
ASF GitHub Bot commented on FLINK-9182:
---
Github user StefanRRichter commented on the
[
https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477359#comment-16477359
]
yuqi commented on FLINK-8918:
-
# Indeed as the streaming applications runs, bloom filter will
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6019
@StefanRRichter I definitely agree with your point! The timers should be
considered as keyed state is a beautiful way to go!
---
[
https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477360#comment-16477360
]
ASF GitHub Bot commented on FLINK-9182:
---
Github user sihuazhou commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477362#comment-16477362
]
Stephan Ewen commented on FLINK-9043:
-
Thank you for the discussion. To me, there are
[
https://issues.apache.org/jira/browse/FLINK-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477363#comment-16477363
]
Stephan Ewen commented on FLINK-9043:
-
[~ariskkol] I remember you asked about this fea
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6019
Yes, the only reason I did not start with this is that I first wanted to
wait for the completion and merge of the RocksDB timer service to have a
complete picture.
---
[
https://issues.apache.org/jira/browse/FLINK-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477365#comment-16477365
]
ASF GitHub Bot commented on FLINK-9182:
---
Github user StefanRRichter commented on the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5847
Sorry for the delay @sihuazhou I have a few minor touchups that I'll apply
while merging. ð
And thanks for discovering this and fixing it. ð
---
[
https://issues.apache.org/jira/browse/FLINK-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477369#comment-16477369
]
ASF GitHub Bot commented on FLINK-9174:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477373#comment-16477373
]
Sihua Zhou commented on FLINK-8918:
---
Hi [~fhueske] thank you very much for your reply, y
[
https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477373#comment-16477373
]
Sihua Zhou edited comment on FLINK-8918 at 5/16/18 12:49 PM:
-
[
https://issues.apache.org/jira/browse/FLINK-9174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aljoscha Krettek closed FLINK-9174.
---
Resolution: Fixed
Fix Version/s: (was: 1.5.0)
1.5.1
Chesnay Schepler created FLINK-9382:
---
Summary: Inconsistent file storage behavior in FileCache
Key: FLINK-9382
URL: https://issues.apache.org/jira/browse/FLINK-9382
Project: Flink
Issue Typ
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
A quick general question: could you observe any performance impact from
calling the `status()` method in the loops. It looks like a native method and I
am not sure that it is inexpensive. Mayb
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5735
I think I'd favour the second approach because the default value is closer
to where the return value is used. If it's define "far away" when defining the
state descriptor it's easier for code to get
[
https://issues.apache.org/jira/browse/FLINK-9036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477382#comment-16477382
]
ASF GitHub Bot commented on FLINK-9036:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477383#comment-16477383
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5955#discussion_r188614213
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulJobWBroadcastStateMigrationITCase.java
---
@@ -0,0 +1,418 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477385#comment-16477385
]
ASF GitHub Bot commented on FLINK-8659:
---
Github user kl0u commented on a diff in the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
@StefanRRichter No, I didn't have any performance tests yet. I think you
are right! Your proposal is the way I'm going to choose. Addressing this...
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
You could also in `isRocksIteratorValid` run the check only if the return
value is `false` if you like the helper method to avoid people forgetting about
this check.
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477387#comment-16477387
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477389#comment-16477389
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5896
@EronWright the fix is really one this:
https://github.com/apache/flink/commit/ba3e2711a2091b7c0907a5caf3ea527f837a442f
But I haven't yet managed to reproduce a failure on my system without the fix.
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
@StefanRRichter NO, I think that couldn't fix this issue, the problem here
is that even `iterator.isValid()` return `true`, there may also some internal
error in RocksDB. What do you think?
---
[
https://issues.apache.org/jira/browse/FLINK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477391#comment-16477391
]
ASF GitHub Bot commented on FLINK-8286:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477393#comment-16477393
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5896
@suez1224 Did you rebase on master? I think that krb5-specific could should
not be there anymore.
---
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
Yes, but eventually it will also return `false`, which is essentially the
same as waiting until the loop terminates. Anyways, I think after the loop is
the nicer way.
---
[
https://issues.apache.org/jira/browse/FLINK-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477394#comment-16477394
]
ASF GitHub Bot commented on FLINK-8286:
---
Github user aljoscha commented on the issue
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477397#comment-16477397
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
Also from the RocksDB docs: `In another word, if Iterator::Valid() is true,
status() is guaranteed to be OK()`
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477399#comment-16477399
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
[
https://issues.apache.org/jira/browse/FLINK-6336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477404#comment-16477404
]
ASF GitHub Bot commented on FLINK-6336:
---
Github user rsingh2411 commented on the iss
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
I think that is the incorrect one, If I'm not confused by the wiki's
content...
---
Github user rsingh2411 commented on the issue:
https://github.com/apache/flink/pull/3744
Getting similar error, whileadding Unique host constraint. How did you fix
that
imestamp=2018-05-16 10:52:34,105 LogLevel=ERROR
ThreadId=[flink-akka.actor.default-dispatcher-3] Class=c.n
Chesnay Schepler created FLINK-9383:
---
Summary: Extend DistributedCache E2E test to cover directories
Key: FLINK-9383
URL: https://issues.apache.org/jira/browse/FLINK-9383
Project: Flink
Iss
[
https://issues.apache.org/jira/browse/FLINK-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-9369.
---
Resolution: Invalid
> DistributedCache returns parent directory for directories
>
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477406#comment-16477406
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
[
https://issues.apache.org/jira/browse/FLINK-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-9383:
Issue Type: Improvement (was: Bug)
> Extend DistributedCache E2E test to cover directories
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
Oh you are right, this is confusing :-) So does this also mean the status
flag is cleared when we simple continue iterating and only check in the end?
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477409#comment-16477409
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
That is a good question, and I'm not sure...but I think that seems to be...
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477412#comment-16477412
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
I think I am a bit torn here now...
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477413#comment-16477413
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
I'm going to check the native implementation and see whether the `status()`
is a super cheap option...
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477414#comment-16477414
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/6023
[FLINK-9383][runtime] Test directories in DistributedCache E2E test
## What is the purpose of the change
With this PR the distributed cache end-to-end test
* also covers the distributed
[
https://issues.apache.org/jira/browse/FLINK-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477417#comment-16477417
]
ASF GitHub Bot commented on FLINK-9383:
---
GitHub user zentol opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477424#comment-16477424
]
Fabian Hueske commented on FLINK-8918:
--
It's good to know that you were thinking abou
[
https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477429#comment-16477429
]
Sihua Zhou commented on FLINK-8918:
---
Hi [~fhueske], sorry that I'm definitely not asked
[
https://issues.apache.org/jira/browse/FLINK-8918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477433#comment-16477433
]
Sihua Zhou commented on FLINK-8918:
---
[~fhueske] related to the saturated problem, I want
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477438#comment-16477438
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
@StefanRRichter I had a look at the implementation of the iterators in
RocksDB, I found status just return the flag first `_status` as the result
without any complex computation, But for some `comp
GitHub user azagrebin opened a pull request:
https://github.com/apache/flink/pull/6024
[FLINK-9301] [e2e test] Add back "not co mini cluster" test with reduced
parallelism
â¦ced to 25 parallelism and memory usage logging
## What is the purpose of the change
A
Github user azagrebin commented on the issue:
https://github.com/apache/flink/pull/6024
cc @zentol
---
[
https://issues.apache.org/jira/browse/FLINK-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477452#comment-16477452
]
ASF GitHub Bot commented on FLINK-9301:
---
GitHub user azagrebin opened a pull request
[
https://issues.apache.org/jira/browse/FLINK-9301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477453#comment-16477453
]
ASF GitHub Bot commented on FLINK-9301:
---
Github user azagrebin commented on the issu
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
It sounds cheap if they just `&` all the flags from the sub iterators. In
the end, we can see if there is a performance drop but better be correct first
before fast.
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477459#comment-16477459
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
Agree, should be correct first before fast! Could you please have a look at
this? I think it's already for a look now~
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477465#comment-16477465
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
Jun Zhang created FLINK-9384:
Summary: KafkaAvroTableSource failed to work due to type mismatch
Key: FLINK-9384
URL: https://issues.apache.org/jira/browse/FLINK-9384
Project: Flink
Issue Type: Bu
[
https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Zhang updated FLINK-9384:
-
Attachment: flink-9384.patch
> KafkaAvroTableSource failed to work due to type mismatch
>
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5823#discussion_r188638639
--- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env bash
+##
[
https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477479#comment-16477479
]
ASF GitHub Bot commented on FLINK-9008:
---
Github user zhangminglei commented on a dif
[
https://issues.apache.org/jira/browse/FLINK-9384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Zhang updated FLINK-9384:
-
Flags: Patch
> KafkaAvroTableSource failed to work due to type mismatch
>
GitHub user zhgao opened a pull request:
https://github.com/apache/flink/pull/6025
Release 1.4
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, pleas
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/5823#discussion_r188645244
--- Diff: flink-end-to-end-tests/test-scripts/test_quickstarts.sh ---
@@ -0,0 +1,123 @@
+#!/usr/bin/env bash
+##
[
https://issues.apache.org/jira/browse/FLINK-9008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477502#comment-16477502
]
ASF GitHub Bot commented on FLINK-9008:
---
Github user zhangminglei commented on a dif
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
After double checking with the RocksDB docs, I am afraid that we need to
introduce more checks because for example the point out that also after methods
like `seek` the iterator an become corr
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477549#comment-16477549
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user sihuazhou commented on the issue:
https://github.com/apache/flink/pull/6020
Oh My God...Is that means we need to wrap the `RocksIterator` to delegate
all it API?
---
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477554#comment-16477554
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user sihuazhou commented on the issu
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
It depends, maybe this is already covered currently because we might always
do an iteration attempt that checks right after the seek. But in general, this
is not very nice and fragile if true.
[
https://issues.apache.org/jira/browse/FLINK-9373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477556#comment-16477556
]
ASF GitHub Bot commented on FLINK-9373:
---
Github user StefanRRichter commented on the
Github user StefanRRichter commented on the issue:
https://github.com/apache/flink/pull/6020
Maybe we should ask them on their issue tracker what the best practise is?
I cannot remember seeing such checks in their code examples. Have a hard time
to believe that this can be true, becau
101 - 200 of 290 matches
Mail list logo