GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1563
[FLINK-3296] Remove 'flushing' behavior of the OutputFormat in DataStream
API
I removed the `FileSinkFunctionByMillis` and removed all the `millis`
arguments on the writing
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1569#discussion_r51432473
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/test/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSourceTest.java
---
@@ -219,7
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1573
[FLINK-3287][FLINK-3247] Fix curator shading for Kafka connector
Some maven versions are not properly evaluating star * excludes. Therefore,
I've manually listed our shaded artifac
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1573#issuecomment-178527480
There is one issue I need to figure out, then, I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1576
[hotfix][yarn] Shutdown JVM when Flink-on-yarn is shutting down
With this change, we call System.exit() when the YARN session is shutting
down.
On some Linux distributions, YARN is not
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1577#issuecomment-178683735
Good catch & fix!
+1 to merge asap (too many tests are failing on this one right now)
---
If your project is set up for it, you can reply to this email and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1582#issuecomment-179365564
I think the change is good to merge when travis has passed.
I tried it on GCE:
```
17:36:55,084 INFO org.apache.flink.yarn.YarnTaskManager
Github user rmetzger closed the pull request at:
https://github.com/apache/flink/pull/1576
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1558#issuecomment-179436819
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1584
[FLINK-3328] Incorrectly shaded dependencies in flink-runtime
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3328
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1584#issuecomment-179823460
Till told me that we do all this curator shading because of Hadoop 2.6.0.
I'll verify if everything is working with 2.6 as well.
---
If your project is s
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1581#discussion_r51874764
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/distcp/DistCp.java
---
@@ -62,18 +63,32 @@
public static
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-179859441
I just checked out your pull request locally and looked through it.
I think the following things need to be fixed before we can merge it:
- Squash the 60
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1584#issuecomment-179866261
It works with CDH 5.4.2, which uses Hadoop 2.6.0.
I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1428#issuecomment-179926670
I went through all the classes in the relevant modules outside `flink-core`
with @fhueske and annotated them properly.
I've rebased the changes and checked wit
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1590#issuecomment-180038020
Change looks good.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1590#issuecomment-180283281
Looks like one test needs to be adopted
```
testCheckpointing(org.apache.flink.streaming.connectors.kafka.Kafka08ITCase)
Time elapsed: 0.194 sec
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180378937
Actually, I worked a bit with redis recently ;) I'll take a look at the PR
now.
---
If your project is set up for it, you can reply to this email and have your
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52022185
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,160
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52023113
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/main/java/org/apache/flink/streaming/connectors/redis/RedisSink.java
---
@@ -0,0 +1,160
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180385898
Thanks a lot for working on this!
I like the pull request!
Just out of curiosity, did you test the throughput you can get with the
connector
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1580#discussion_r52023695
--- Diff:
flink-streaming-connectors/flink-connector-redis/src/test/java/org/apache/flink/streaming/connectors/redis/RedisSinkTest.java
---
@@ -0,0 +1,131
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-180422247
Awesome, thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-180746275
How do you want to implement this? I'm asking because I don't see an
obvious way to expose this to the user.
---
If your project is set up for it, you ca
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1597
[FLINK-3341] Make 'auto.offset.reset' compatible with Kafka 0.8 and 0.9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmet
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r52101633
--- Diff: docs/setup/config.md ---
@@ -211,6 +211,8 @@ The parameters define the behavior of tasks that create
result files
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753150
I didn't test this myself, but this diff could be sufficient for testing
your change:
```diff
diff --git
a/flink-yarn-tests/src/main/java/org/apache/
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-180753220
I hope its a coincidence that the YARN tests failed in this PR. If they
fail after your next push again, we have to check if your changes caused the
failure
---
If
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-180994099
The first test failed because some files on travis were corrupted, the two
other tests failed probably because the YARN tests became unstable recently.
I think
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1513#discussion_r52184878
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/TimeCharacteristic.java
---
@@ -34,7 +34,7 @@
* because the contents
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1513#discussion_r52185124
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/KeyedStream.java
---
@@ -163,7 +166,11 @@ public KeyedStream
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1597#discussion_r52202024
--- Diff:
flink-streaming-connectors/flink-connector-kafka-0.8/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/LegacyFetcher.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182065768
I identified the following issues:
- Setting the configuration using the yarn session "dynamic properties":
`./bin/yarn-session.sh -n 2 -Dfs.defa
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182066864
Setting the value to `fs.default-scheme: thisIsWrong:///`
is good:
```
robert@cdh544-master:~/flink/build-target$ ./bin/flink run
./examples/batch
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-182054657
I'm testing the change on a cluster (with YARN) to see if everything is
working as expected.
---
If your project is set up for it, you can reply to this emai
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52386582
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385415
--- Diff: docs/apis/batch/index.md ---
@@ -2123,7 +2123,7 @@ Note that types registered with `registerKryoType()`
are not available to Flink
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385934
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385223
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -27,13 +24,17 @@
import
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385698
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptor.java
---
@@ -141,9 +146,16 @@ public
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52385188
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGeneratorTest.java
---
@@ -75,16 +76,22 @@ public void
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1612#discussion_r52386295
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/jobgraph/JobGraph.java ---
@@ -102,60 +101,150
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1607#issuecomment-182114169
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1599#issuecomment-182115171
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1605#discussion_r52388115
--- Diff:
flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBFoldingState.java
---
@@ -0,0 +1,175
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1605#issuecomment-182125713
You are adding new `.apply()` variants to the API which are not documented
with the PR.
---
If your project is set up for it, you can reply to this email and have
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1623
[FLINK-3368][Kafka 0.8] Handle leader changes in Kafka Consumer.
Please see the JIRA for an explanation of the problems.
tl;dr: The Kafka 0.8 consumer now handles broker failures internally
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-183288223
Thank you.
- ` ./bin/yarn-session.sh -tm 1024 -n 7 -s 2 -Dfs.default-scheme=hdfs:///`
is now working
- Setting the fs.default-scheme to `thisIsWrong` and
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-183314810
Once this PR has been merged (I expect that some adoptions might still be
required) I can try and see if its straightforward to backport. Are you
planning to stick to
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1606#issuecomment-183332749
Except for two questions, the PR looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-183356403
Thank you for the review. I've addressed the comments and rebased the
change.
Once travis has passed, I'll merge it!
---
If your project is set
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1635#issuecomment-183918146
+1 to merge the change.
Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184594465
Looks like the YARN tests are failing. I'll look into it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52992939
--- Diff: docs/apis/streaming/connectors/cassandra.md ---
@@ -0,0 +1,100 @@
+---
+title: "Apache Cassandra Connector"
+
+#
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52993965
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52994037
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52994189
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52994316
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraCommitter.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52994409
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraCommitter.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52994814
--- Diff: docs/apis/streaming/fault_tolerance.md ---
@@ -176,6 +176,11 @@ state updates) of Flink coupled with bundled sinks
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184624521
The `testDetachedPerJobYarnCluster()` YARN test is failing with
```
10:33:26,969 INFO org.apache.flink.client.CliFrontend
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52997588
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1640#discussion_r52997627
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/streaming/connectors/cassandra/CassandraExactlyOnceSink.java
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-184642511
I renamed the method to `writeUsingOutputFormat` and rebased to current
master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1635#issuecomment-184688215
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1524#discussion_r53014234
--- Diff:
flink-yarn/src/main/scala/org/apache/flink/yarn/ApplicationMasterBase.scala ---
@@ -176,6 +184,8 @@ abstract class ApplicationMasterBase
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1563#issuecomment-184700077
I'll merge the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1524#issuecomment-184702790
I tested the change again on a cluster. Everything is working nicely with
YARN.
I'll merge the PR.
---
If your project is set up for it, you can rep
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-184754971
To get to the logs, I executed your branch in my travis account. I have a
S3 bucket configured where we upload the full logs to (travis has a log limit
of ~5 mb
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185264548
Awesome. Thanks a lot for testing it! @StephanEwen wanted to take a look at
the PR as well.
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-185204685
You can rebase your PR's branch to our current master and then force push
it again. This will update the PR.
---
If your project is set up for it, you can rep
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185430953
Thank you for the review. I'll address them soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53240407
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53241145
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/examples
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53241280
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185434970
Thank you for the contribution. I just scrolled over the code once and made
some comments. I think some further (small) changes are needed here and there.
---
If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1663#issuecomment-185435610
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r53296134
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -114,9 +108,9 @@ public void testClientStartup
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1588#discussion_r53296170
--- Diff:
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java
---
@@ -436,7 +430,7 @@ public void perJobYarnCluster
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53298910
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53298948
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185748371
So far nobody had this as an issue and during the integration tests and my
cluster tests, this issue never occurred. But I agree, there is no good reason
to fail hard
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185905274
Awesome, thank you. I'll take your changes from the pull request and
address the remaining issues.
---
If your project is set up for it, you can reply to this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-186201689
Thank you for the good review. I adopted my IntelliJ inspections to find
some of the mentioned issues myself in the future (forgotten @Override, unused
methods
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186364227
I started some tests on my travis as well to see whether the one YARN test
failure is a coincidence: https://travis-ci.org/rmetzger/flink/builds/110454166
---
If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186396847
In my private tests and here, `YARNSessionFIFOITCase.testQueryCluster`
failed with a timeout. Something has made this test unstable.
---
If your project is set up for
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-186835009
The expected output of the test is the following
```
Test testQueryCluster(org.apache.flink.yarn.YARNSessionFIFOITCase) is
running
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1684
[FLINK-3455] Bump Kafka to 0.9.0.1 and 0.8.2.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink3455
Alternatively you can
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1683#issuecomment-187107162
I think we should do the same for other modules such as ml, avro, gelly,
gelly-scala, ...
---
If your project is set up for it, you can reply to this email and have
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1681#issuecomment-187107826
+1 good catch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1682#issuecomment-187125611
I tested this change and #1681 on a HDP cluster and Flink started
successfully on YARN.
I know that this one test is certainly not sufficient to guarantee that it
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1683#issuecomment-187125781
I think the change is good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1580#issuecomment-187184409
Sorry, I'm currently very busy with the 1.0 release. I hope I'll find some
time to look into this PR again later this week.
---
If your project is set up f
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1687#discussion_r53628814
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/util/HDFSCopyFromLocal.java
---
@@ -26,32 +25,46 @@
import java.io.File
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-187364918
Hi, the error is not related to your changes. Its an issue of our build
system (an inconsistent file has been cached).
From a CI point of view, the changes look
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/1692
[FLINK-3340][Kafka 0.8] Commit also offsets retrieved from Kafka into the
OffsetStore (ZK)
Before this change, offsets were only committed to Zookeeper if something
was read from the
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1684#issuecomment-187366906
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1692#issuecomment-187598869
Ooops, you are right. I'll fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1588#issuecomment-187606854
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1687#issuecomment-187692550
+1 to merge this change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
701 - 800 of 1386 matches
Mail list logo
