[jira] [Comment Edited] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489255#comment-15489255 ] Duo Zhang edited comment on HBASE-15921 at 9/14/16 3:44 AM: I

[jira] [Commented] (HBASE-16373) precommit needs a dockerfile with hbase prereqs

2016-09-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489340#comment-15489340 ] Duo Zhang commented on HBASE-16373: --- Where do we tell yetus which java versions to use?

[jira] [Commented] (HBASE-16165) Decrease RpcServer.callQueueSize before writeResponse causes OOM

2016-09-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15489945#comment-15489945 ] Duo Zhang commented on HBASE-16165: --- +1. > Decrease RpcServer.callQueueSize before wri

[jira] [Commented] (HBASE-16165) Decrease RpcServer.callQueueSize before writeResponse causes OOM

2016-09-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490375#comment-15490375 ] Duo Zhang commented on HBASE-16165: --- This should be commited to all active branches. [

[jira] [Updated] (HBASE-16165) Decrease RpcServer.callQueueSize before writeResponse causes OOM

2016-09-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16165: -- Affects Version/s: 1.4.0 1.3.0 2.0.0

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492474#comment-15492474 ] Duo Zhang commented on HBASE-16635: --- Can you add the -Dio.netty.leakDetection.level=adv

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15492619#comment-15492619 ] Duo Zhang commented on HBASE-16635: --- Ah after a careful review, I found some leaks...

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15493276#comment-15493276 ] Duo Zhang commented on HBASE-16635: --- Go for it! And some background, we can not releas

[jira] [Commented] (HBASE-16165) Decrease RpcServer.callQueueSize before writeResponse causes OOM

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500049#comment-15500049 ] Duo Zhang commented on HBASE-16165: --- Will commit shortly. > Decrease RpcServer.callQue

[jira] [Updated] (HBASE-16165) Decrease RpcServer.callQueueSize before writeResponse causes OOM

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16165: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushe

[jira] [Commented] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500125#comment-15500125 ] Duo Zhang commented on HBASE-7612: -- Bad news, our {{Counter}} is declared as {{InterfaceA

[jira] [Assigned] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-7612: Assignee: Duo Zhang > [JDK8] Replace use of high-scale-lib counters with intrinsic facilities > ---

[jira] [Updated] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-7612: - Attachment: HBASE-7612.patch Not very big... Let's try it. > [JDK8] Replace use of high-scale-lib counter

[jira] [Updated] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-7612: - Affects Version/s: 2.0.0 Component/s: metrics > [JDK8] Replace use of high-scale-lib counters wi

[jira] [Updated] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-17 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-7612: - Status: Patch Available (was: Open) > [JDK8] Replace use of high-scale-lib counters with intrinsic facili

[jira] [Created] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-17 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-16648: - Summary: [JDK8] Use computeIfAbsent instead of get and putIfAbsent Key: HBASE-16648 URL: https://issues.apache.org/jira/browse/HBASE-16648 Project: HBase Issue Typ

[jira] [Commented] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15500463#comment-15500463 ] Duo Zhang commented on HBASE-7612: -- The failed test can not be reproduced locally and the

[jira] [Updated] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-7612: - Attachment: HBASE-7612-v1.patch Fix findbugs warnings. > [JDK8] Replace use of high-scale-lib counters wi

[jira] [Updated] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16648: -- Attachment: HBASE-16648.patch Only change the 'get-putIfAbsent-check if null' to {{computeIfAbsent}}. A

[jira] [Updated] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16648: -- Status: Patch Available (was: Open) > [JDK8] Use computeIfAbsent instead of get and putIfAbsent >

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501015#comment-15501015 ] Duo Zhang commented on HBASE-16648: --- The behavior of reportServerError method in Conne

[jira] [Updated] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16648: -- Attachment: HBASE-16648-v1.patch Fix TestHCM. > [JDK8] Use computeIfAbsent instead of get and putIfAbs

[jira] [Commented] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15501898#comment-15501898 ] Duo Zhang commented on HBASE-7612: -- I added the Deprecated annotation to Counter. We coul

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502335#comment-15502335 ] Duo Zhang commented on HBASE-16635: --- The cleanupConnection does not need to throw Excep

[jira] [Commented] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502352#comment-15502352 ] Duo Zhang commented on HBASE-7612: -- OK, let me commit. > [JDK8] Replace use of high-scal

[jira] [Updated] (HBASE-7612) [JDK8] Replace use of high-scale-lib counters with intrinsic facilities

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-7612: - Resolution: Fixed Hadoop Flags: Reviewed Release Note: org.apache.hadoop.hbase.util.Counter is de

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502380#comment-15502380 ] Duo Zhang commented on HBASE-16635: --- {quote} so you mean all the ByteBuf in the queue h

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502428#comment-15502428 ] Duo Zhang commented on HBASE-16635: --- Ah we should override the close method, not discon

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502521#comment-15502521 ] Duo Zhang commented on HBASE-16635: --- The connect method will called when you call Boots

[jira] [Commented] (HBASE-16635) RpcClient under heavy load leaks some netty bytebuf

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502654#comment-15502654 ] Duo Zhang commented on HBASE-16635: --- +1. There are still some bad practices but not yo

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502796#comment-15502796 ] Duo Zhang commented on HBASE-16652: --- See ProtobufUtil.toGet and toScan. If TimeRange.is

[jira] [Commented] (HBASE-16652) Figure out performance difference between increment and append

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15502866#comment-15502866 ] Duo Zhang commented on HBASE-16652: --- This is in {{reckonDeltasByStore}} {code:title=HRe

[jira] [Created] (HBASE-16654) Better handle channelInactive and close for netty rpc client

2016-09-19 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-16654: - Summary: Better handle channelInactive and close for netty rpc client Key: HBASE-16654 URL: https://issues.apache.org/jira/browse/HBASE-16654 Project: HBase Issue

[jira] [Updated] (HBASE-16654) Better handle channelInactive and close for netty rpc client

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16654: -- Attachment: HBASE-16654.patch Also rename the two AsyncXXX classes to NettyXXX. > Better handle channe

[jira] [Updated] (HBASE-16654) Better handle channelInactive and close for netty rpc client

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16654: -- Status: Patch Available (was: Open) > Better handle channelInactive and close for netty rpc client > -

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15503423#comment-15503423 ] Duo Zhang commented on HBASE-16648: --- [~enis] This is also a benefit from JDK8 where we

[jira] [Commented] (HBASE-16649) Truncate table with splits preserved can cause both data loss and truncated data appeared again

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505293#comment-15505293 ] Duo Zhang commented on HBASE-16649: --- {code} private static List recreteRegionInfo(final

[jira] [Commented] (HBASE-16649) Truncate table with splits preserved can cause both data loss and truncated data appeared again

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505298#comment-15505298 ] Duo Zhang commented on HBASE-16649: --- Theoretically this should not happen? I mean a sma

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505360#comment-15505360 ] Duo Zhang commented on HBASE-16648: --- Lock does not reduce performance, the problem is c

[jira] [Updated] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16648: -- Attachment: HBASE-16648-v2.patch Remove the modification of WeakObjectPool as [~ikeda] suggested, we ne

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505666#comment-15505666 ] Duo Zhang commented on HBASE-16648: --- Write a simple JMH test, it shows that the default

[jira] [Updated] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16648: -- Status: Open (was: Patch Available) > [JDK8] Use computeIfAbsent instead of get and putIfAbsent >

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505739#comment-15505739 ] Duo Zhang commented on HBASE-16648: --- https://github.com/Apache9/microbench/tree/master/

[jira] [Comment Edited] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505739#comment-15505739 ] Duo Zhang edited comment on HBASE-16648 at 9/20/16 6:20 AM: h

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505765#comment-15505765 ] Duo Zhang commented on HBASE-15921: --- [~chenheng] I found a big problem of your plan. Ho

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505857#comment-15505857 ] Duo Zhang commented on HBASE-15921: --- And now, I prefer that we can implement a simple A

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15505932#comment-15505932 ] Duo Zhang commented on HBASE-15921: --- I think we need to design a new API for async scan

[jira] [Commented] (HBASE-16654) Better handle channelInactive and close for netty rpc client

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506030#comment-15506030 ] Duo Zhang commented on HBASE-16654: --- [~stack] Mind take a look? Polish on the netty rpc

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506090#comment-15506090 ] Duo Zhang commented on HBASE-16648: --- Maybe I should use a new CHM instance for each ite

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506124#comment-15506124 ] Duo Zhang commented on HBASE-15921: --- Ah I found that, we need to implement async region

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506214#comment-15506214 ] Duo Zhang commented on HBASE-15921: --- OK, we need HTable to read meta table when impleme

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506690#comment-15506690 ] Duo Zhang commented on HBASE-16648: --- Rewrite the JMH test and run it again. {noformat}

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15506758#comment-15506758 ] Duo Zhang commented on HBASE-16648: --- I'm not Doug Lee so it is hard to tell what exactl

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508372#comment-15508372 ] Duo Zhang commented on HBASE-15921: --- If your goal is to implement the async client ASAP

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508439#comment-15508439 ] Duo Zhang commented on HBASE-16648: --- Seems the critical operation is the get before put

[jira] [Commented] (HBASE-16648) [JDK8] Use computeIfAbsent instead of get and putIfAbsent

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508510#comment-15508510 ] Duo Zhang commented on HBASE-16648: --- OK, I found the problem... The map will not be em

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-20 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15508516#comment-15508516 ] Duo Zhang commented on HBASE-15921: --- As said above, with the non-blocking rpc client, t

[jira] [Commented] (HBASE-16654) Better handle channelInactive and close for netty rpc client

2016-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509508#comment-15509508 ] Duo Zhang commented on HBASE-16654: --- Ping [~stack]. > Better handle channelInactive an

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509525#comment-15509525 ] Duo Zhang commented on HBASE-15921: --- https://github.com/Apache9/hbase/blob/asynclocator

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15509680#comment-15509680 ] Duo Zhang commented on HBASE-15921: --- I was misled by the current zh implementation in H

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15510129#comment-15510129 ] Duo Zhang commented on HBASE-15921: --- https://github.com/Apache9/hbase/blob/asynclocator

[jira] [Updated] (HBASE-16654) Better handle channelInactive and close for netty rpc client

2016-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16654: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushe

[jira] [Commented] (HBASE-16679) Flush throughput controller: Minor perf change and fix flaky TestFlushWithThroughputController

2016-09-21 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512174#comment-15512174 ] Duo Zhang commented on HBASE-16679: --- The {{maxThroughputPerOperation}} should be volati

[jira] [Updated] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-22 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15921: -- Attachment: HBASE-15921-v2.patch Finally I decide to use the blocking connection to get region location

[jira] [Updated] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-22 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-15921: -- Assignee: Duo Zhang (was: Jurriaan Mous) Fix Version/s: 2.0.0 Affects Version/s: 2

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-22 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15512701#comment-15512701 ] Duo Zhang commented on HBASE-15921: --- Yes, as I said in the comment, I haven't implement

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-22 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515258#comment-15515258 ] Duo Zhang commented on HBASE-15921: --- Let's talk about the retry and timeout logic. In

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-22 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515277#comment-15515277 ] Duo Zhang commented on HBASE-15921: --- And I think the refactoring work on zk could be do

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515692#comment-15515692 ] Duo Zhang commented on HBASE-15921: --- Yes the 'start from beginning' is only for single

[jira] [Created] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
Duo Zhang created HBASE-16690: - Summary: Move znode path configs to a separated class Key: HBASE-16690 URL: https://issues.apache.org/jira/browse/HBASE-16690 Project: HBase Issue Type: Improvemen

[jira] [Commented] (HBASE-15921) Add first AsyncTable impl and create TableImpl based on it

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515740#comment-15515740 ] Duo Zhang commented on HBASE-15921: --- {quote} this "start from beginning" could be a reg

[jira] [Commented] (HBASE-16679) Flush throughput controller: Minor perf change and fix flaky TestFlushWithThroughputController

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515816#comment-15515816 ] Duo Zhang commented on HBASE-16679: --- Here in this class ,and for now, it is not a probl

[jira] [Commented] (HBASE-16679) Flush throughput controller: Minor perf change and fix flaky TestFlushWithThroughputController

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15515847#comment-15515847 ] Duo Zhang commented on HBASE-16679: --- +1 on v3. Ping [~stack]. I can help committing if

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Fix Version/s: 2.0.0 Affects Version/s: 2.0.0 Status: Patch Available (was: Open

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Attachment: HBASE-16690.patch > Move znode path configs to a separated class >

[jira] [Assigned] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reassigned HBASE-16690: - Assignee: Duo Zhang > Move znode path configs to a separated class > ---

[jira] [Commented] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516087#comment-15516087 ] Duo Zhang commented on HBASE-16690: --- [~carp84] [~stack] FYI. > Move znode path configs

[jira] [Commented] (HBASE-16322) Disable filter for raw scan

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516345#comment-15516345 ] Duo Zhang commented on HBASE-16322: --- As [~yangzhe1991] has made some progress in HBASE-

[jira] [Commented] (HBASE-16322) Disable filter for raw scan

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15516527#comment-15516527 ] Duo Zhang commented on HBASE-16322: --- Ah it is not allowed to specify columns for a raw

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Attachment: HBASE-16690-v1.patch Fix javadoc issue and the failed UT. > Move znode path configs to a s

[jira] [Commented] (HBASE-16679) Flush throughput controller: Minor perf change and fix flaky TestFlushWithThroughputController

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518209#comment-15518209 ] Duo Zhang commented on HBASE-16679: --- Fine. :) > Flush throughput controller: Minor per

[jira] [Commented] (HBASE-16690) Move znode path configs to a separated class

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15518232#comment-15518232 ] Duo Zhang commented on HBASE-16690: --- TestBlockEvictionFromClient and TestFlushWithThrou

[jira] [Resolved] (HBASE-16702) TestBlockEvictionFromClient is broken

2016-09-23 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16702?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-16702. --- Resolution: Duplicate Duplicated with HBASE-16696. > TestBlockEvictionFromClient is broken > ---

[jira] [Commented] (HBASE-15536) Make AsyncFSWAL as our default WAL

2016-09-27 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15525894#comment-15525894 ] Duo Zhang commented on HBASE-15536: --- There are some problems for HBASE-15709. I'm on a

[jira] [Commented] (HBASE-16721) Concurrency issue in WAL unflushed seqId tracking

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538503#comment-15538503 ] Duo Zhang commented on HBASE-16721: --- Why AutoCloseable instead of Closeable? Thanks.

[jira] [Commented] (HBASE-15536) Make AsyncFSWAL as our default WAL

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538548#comment-15538548 ] Duo Zhang commented on HBASE-15536: --- I filed HBASE-15709 when debugging the problem of

[jira] [Commented] (HBASE-16690) Move znode path configs to a separated class

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538557#comment-15538557 ] Duo Zhang commented on HBASE-16690: --- Ah I'm back. Ping [~carp84] [~stack]. > Move znod

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Attachment: HBASE-16690-v2.patch Rebase. > Move znode path configs to a separated class >

[jira] [Commented] (HBASE-16373) precommit needs a dockerfile with hbase prereqs

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15538578#comment-15538578 ] Duo Zhang commented on HBASE-16373: --- So here we should use {noformat} --multijdkdirs="

[jira] [Commented] (HBASE-15536) Make AsyncFSWAL as our default WAL

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15539332#comment-15539332 ] Duo Zhang commented on HBASE-15536: --- Fine. Let me prepare a patch. Is 2MB a suitable si

[jira] [Commented] (HBASE-15536) Make AsyncFSWAL as our default WAL

2016-10-01 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15539723#comment-15539723 ] Duo Zhang commented on HBASE-15536: --- Let me revisit all the related configs. Seems they

[jira] [Commented] (HBASE-16690) Move znode path configs to a separated class

2016-10-02 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540362#comment-15540362 ] Duo Zhang commented on HBASE-16690: --- The timed out tests can pass locally. > Move znod

[jira] [Commented] (HBASE-15536) Make AsyncFSWAL as our default WAL

2016-10-02 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-15536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15540424#comment-15540424 ] Duo Zhang commented on HBASE-15536: --- Seems there is no key value size limitation at ser

[jira] [Updated] (HBASE-16373) precommit needs a dockerfile with hbase prereqs

2016-10-02 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16373: -- Attachment: HBASE-16373-0.98.patch Install oracle java6 for 0.98. > precommit needs a dockerfile with

[jira] [Commented] (HBASE-16373) precommit needs a dockerfile with hbase prereqs

2016-10-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15542283#comment-15542283 ] Duo Zhang commented on HBASE-16373: --- [~busbey] Let's commit and leave this issue open t

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-10-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Description: Which makes it easier to use curator at client in the future. And also, will try to fix t

[jira] [Reopened] (HBASE-16739) Timed out exception message should include encoded region name

2016-10-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang reopened HBASE-16739: --- The commit message is broken, both for master and branch-1. commit ec0adbd2c0fbe8e367521f85fdd7f94d5a886

[jira] [Commented] (HBASE-16373) precommit needs a dockerfile with hbase prereqs

2016-10-03 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15543864#comment-15543864 ] Duo Zhang commented on HBASE-16373: --- Fine. Thanks. > precommit needs a dockerfile with

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-10-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Attachment: HBASE-16690-v3.patch Rebase. > Move znode path configs to a separated class >

[jira] [Updated] (HBASE-16690) Move znode path configs to a separated class

2016-10-04 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-16690: -- Attachment: (was: HBASE-16690-v3.patch) > Move znode path configs to a separated class > --

<    4   5   6   7   8   9   10   11   12   13   >