[GitHub] [lucene] rmuir commented on issue #12012: Spotless runs before javac in `gradle check` which results in less-than-helpful errors on compilation problems

2022-12-12 Thread GitBox
rmuir commented on issue #12012: URL: https://github.com/apache/lucene/issues/12012#issuecomment-1347423692 I ran this patch on the mac m1 and also got `BUILD SUCCESSFUL in 3m 33s`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] rmuir commented on issue #12012: Spotless runs before javac in `gradle check` which results in less-than-helpful errors on compilation problems

2022-12-12 Thread GitBox
rmuir commented on issue #12012: URL: https://github.com/apache/lucene/issues/12012#issuecomment-1347398451 Here's my patch which seems to work and do the right thing. I'll benchmark it. But also I don't know what i am doing with gradle: ``` diff --git

[GitHub] [lucene] rmuir commented on issue #12012: Spotless runs before javac in `gradle check` which results in less-than-helpful errors on compilation problems

2022-12-12 Thread GitBox
rmuir commented on issue #12012: URL: https://github.com/apache/lucene/issues/12012#issuecomment-1347394601 Hmm, @dweiss I think it is still not quite right. I think we are not slowing down the `spotlessJava` task which is the one actually failing for me? Here's a simple reproducer

[GitHub] [lucene] rmuir commented on issue #12012: Spotless runs before javac in `gradle check` which results in less-than-helpful errors on compilation problems

2022-12-12 Thread GitBox
rmuir commented on issue #12012: URL: https://github.com/apache/lucene/issues/12012#issuecomment-1347377866 +1 Any difference is in the noise there: ``` Before: BUILD SUCCESSFUL in 3m 34s After: BUILD SUCCESSFUL in 3m 24s ``` I did notice all the

[GitHub] [lucene] rmuir commented on issue #12012: Spotless runs before javac in `gradle check` which results in less-than-helpful errors on compilation problems

2022-12-12 Thread GitBox
rmuir commented on issue #12012: URL: https://github.com/apache/lucene/issues/12012#issuecomment-1347351739 i can test out timings of your patch on a fast mac m1: give me a few minutes. I know it has enough concurrency to basically be bottlenecked by the task dependencies... which I've