olamy commented on PR #82:
URL: https://github.com/apache/maven-parent/pull/82#issuecomment-1288023514
LGTM but if we move to spotless. I would remove `checkstyle:check` as well
as we do not need really to check sources style twice during the build
And it's a bit confusing as when tes
gnodet commented on PR #149:
URL:
https://github.com/apache/maven-shade-plugin/pull/149#issuecomment-1287937197
The problem seems to have been fixed in 3.4.1 according to #162 which seems
to pass on master.
--
This is an automated message from the Apache Git Service.
To respond to the me
Guillaume Nodet created MPOM-352:
Summary: Remove managed dependency on deprecated
plexus-component-annotations
Key: MPOM-352
URL: https://issues.apache.org/jira/browse/MPOM-352
Project: Maven POMs
Guillaume Nodet created MPOM-351:
Summary: Upgrade plexus-utils to 3.4.2
Key: MPOM-351
URL: https://issues.apache.org/jira/browse/MPOM-351
Project: Maven POMs
Issue Type: Dependency upgrade
[
https://issues.apache.org/jira/browse/MPOM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MPOM-350:
-
Fix Version/s: MAVEN-38
> Raise JDK requirement to 1.8
>
>
>
pzygielo commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287922492
One module that gets repacked, instead being taken as-is, differs in
following way for several entries, here just shown for MANIFEST.MF:
\- is entry from original module (jar)
[
https://issues.apache.org/jira/browse/MPOM-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MPOM-350:
--
Component/s: maven
> Raise JDK requirement to 1.8
>
>
>
[
https://issues.apache.org/jira/browse/MNG-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622691#comment-17622691
]
Garret Wilson edited comment on MNG-7577 at 10/22/22 8:56 PM:
--
[
https://issues.apache.org/jira/browse/MNG-7577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622691#comment-17622691
]
Garret Wilson commented on MNG-7577:
Oops, looks like this is a duplicate (MNG-3328) …
Garret Wilson created MNG-7577:
--
Summary: Ability to activate profile based on multiple property
values
Key: MNG-7577
URL: https://issues.apache.org/jira/browse/MNG-7577
Project: Maven
Issue Ty
gnodet commented on code in PR #117:
URL:
https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1001740948
##
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/MojoAnnotationsScanner.java:
##
@@ -37,13 +37,21 @@
gnodet opened a new pull request, #83:
URL: https://github.com/apache/maven-parent/pull/83
JIRA issue: https://issues.apache.org/jira/browse/MPOM-350
Raise JDK mimimum requirements to 1.8
Discussion at:
https://lists.apache.org/thread/ksqgjw7v3rbzw7pq2pvv8xov38799yok
--
Guillaume Nodet created MPOM-350:
Summary: Raise JDK requirement to 1.8
Key: MPOM-350
URL: https://issues.apache.org/jira/browse/MPOM-350
Project: Maven POMs
Issue Type: Task
Repo
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622686#comment-17622686
]
ASF GitHub Bot commented on MNG-7559:
-
sultan opened a new pull request, #331:
URL: htt
sultan opened a new pull request, #331:
URL: https://github.com/apache/maven-site/pull/331
Fix versions comparison https://issues.apache.org/jira/browse/MNG-7559
intention is:
* milestone < preview < rc
* .RC1 < -RC2
* -pfd < final, ga, release
--
This is an automated message f
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622685#comment-17622685
]
ASF GitHub Bot commented on MNG-7038:
-
gnodet commented on PR #840:
URL: https://github
gnodet commented on PR #840:
URL: https://github.com/apache/maven/pull/840#issuecomment-1287888704
> I think I ran into a chicken-egg type of problem.
>
> * I would like to have the project.topdir available as a variable that can
be used in the pom.xml to pin point things. This implie
[
https://issues.apache.org/jira/browse/MSHARED-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622684#comment-17622684
]
Bartlomiej commented on MSHARED-1149:
-
Hi,
I created [PR|https://github.com/apach
Koziolek opened a new pull request, #71:
URL: https://github.com/apache/maven-dependency-analyzer/pull/71
Replace usage of `System.out.println` by Logger from slf4j.
Introducing slf4j in similar way like other MSHARED projects like
maven-filtering
- [x] I hereby declare this cont
[
https://issues.apache.org/jira/browse/MRESOLVER-279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622678#comment-17622678
]
ASF GitHub Bot commented on MRESOLVER-279:
--
gnodet commented on code in PR #2
gnodet commented on code in PR #203:
URL: https://github.com/apache/maven-resolver/pull/203#discussion_r1002547214
##
maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/checksum/FileTrustedChecksumsSourceTestSupport.java:
##
@@ -51,58 +56,79 @@
private Fil
slawekjaranowski commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287861226
In 07a84983809b4ec416b1330412bbd83844a88a44 I was replaced a way how items
are changed in attached modules
before it whole module was unpacked to temporary location, one f
pzygielo commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287857868
I have tested m-ear-p:3.3.0 + revert
07a84983809b4ec416b1330412bbd83844a88a44 and it's also fine and does not cause
the deploy problem.
--
This is an automated message from the A
pzygielo commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287856632
> can be connected with JDK versions and build
Using the same JDK (Temurin 11.0.16.1) here and there.
--
This is an automated message from the Apache Git Service.
To
pzygielo commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287855504
> Also - I have problems to reproduce it locally on regular linux box. It
fails only on GitHub Actions node.
To clarify:
I have problem **to build** reproducible archive lo
slawekjaranowski commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287854266
> Hi @slawekjaranowski, thanks for checking this issue.
>
> Currently I have bisected it to
[07a8498](https://github.com/apache/maven-ear-plugin/commit/07a84983809b4ec
pzygielo commented on PR #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80#issuecomment-1287852135
Hi @slawekjaranowski, thanks for checking this issue.
Currently I have bisected it to 07a84983809b4ec416b1330412bbd83844a88a44.
I have _"reproducer"_ but it is with non-
[
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622666#comment-17622666
]
Slawomir Jaranowski commented on MEAR-322:
--
I was tried to reproduce issue ... but
[
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Zygielo updated MEAR-322:
---
Description:
After m-ear-p upgrade from 3.2.0 to 3.3.0, this
{quote}Exception while deploying the app:
slawekjaranowski opened a new pull request, #80:
URL: https://github.com/apache/maven-ear-plugin/pull/80
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MEAR) filed
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622664#comment-17622664
]
ASF GitHub Bot commented on MNG-7559:
-
sultan commented on code in PR #845:
URL: https:
sultan commented on code in PR #845:
URL: https://github.com/apache/maven/pull/845#discussion_r1002523615
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -354,15 +354,15 @@ public String toString()
implements Item
[
https://issues.apache.org/jira/browse/MRESOLVER-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622662#comment-17622662
]
ASF GitHub Bot commented on MRESOLVER-274:
--
gnodet commented on code in PR #1
gnodet commented on code in PR #197:
URL: https://github.com/apache/maven-resolver/pull/197#discussion_r1002523689
##
src/site/markdown/remote-repository-filtering.md:
##
@@ -0,0 +1,70 @@
+# Remote Repository Filtering
+
+
+A new Maven Resolver feature that allows filtering of A
sultan commented on code in PR #845:
URL: https://github.com/apache/maven/pull/845#discussion_r1002523615
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -354,15 +354,15 @@ public String toString()
implements Item
sultan commented on code in PR #845:
URL: https://github.com/apache/maven/pull/845#discussion_r1002523419
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -354,15 +354,15 @@ public String toString()
implements Item
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622660#comment-17622660
]
Gwénaël Ruelland commented on MNG-7559:
---
!image-2022-10-22-18-22-11-591.png!
> Compa
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gwénaël Ruelland updated MNG-7559:
--
Attachment: image-2022-10-22-18-22-11-591.png
> ComparableVersion vs versions with custom qualifi
sultan commented on code in PR #845:
URL: https://github.com/apache/maven/pull/845#discussion_r1002518719
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -354,15 +354,15 @@ public String toString()
implements Item
michael-o commented on code in PR #845:
URL: https://github.com/apache/maven/pull/845#discussion_r1002518336
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java:
##
@@ -354,15 +354,15 @@ public String toString()
implements Item
dependabot[bot] commented on PR #33:
URL:
https://github.com/apache/maven-install-plugin/pull/33#issuecomment-1287838504
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dep
slawekjaranowski closed pull request #33: Bump aetherVersion from
1.0.0.v20140518 to 1.1.0
URL: https://github.com/apache/maven-install-plugin/pull/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dependabot[bot] commented on PR #34:
URL:
https://github.com/apache/maven-install-plugin/pull/34#issuecomment-1287838416
OK, I won't notify you again about this release, but will get in touch when
a new version is available. You can also ignore all major, minor, or patch
releases for a dep
slawekjaranowski closed pull request #34: Bump slf4jVersion from 1.7.5 to 1.7.32
URL: https://github.com/apache/maven-install-plugin/pull/34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
sultan opened a new pull request, #845:
URL: https://github.com/apache/maven/pull/845
Fix versions comparison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622613#comment-17622613
]
ASF GitHub Bot commented on MNG-7038:
-
nielsbasjes commented on PR #840:
URL: https://g
nielsbasjes commented on PR #840:
URL: https://github.com/apache/maven/pull/840#issuecomment-1287770947
I think I ran into a chicken-egg type of problem.
- I would like to have the project.topdir available as a variable that can
be used in the pom.xml to pin point things. This implies it
[
https://issues.apache.org/jira/browse/MEAR-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Zygielo updated MEAR-322:
---
Description:
After m-ear-p upgrade from 3.2.0 to 3.3.0, this
{quote}Exception while deploying the app:
Piotr Zygielo created MEAR-322:
--
Summary: Exception while deploying the app:
java.util.zip.ZipException: only DEFLATED entries can have EXT descriptor
Key: MEAR-322
URL: https://issues.apache.org/jira/browse/MEAR-322
slawekjaranowski commented on PR #38:
URL:
https://github.com/apache/maven-install-plugin/pull/38#issuecomment-1287757533
@cstamas please look - I added more cases in IT test and corresponding
implementation
--
This is an automated message from the Apache Git Service.
To respond to the m
gnodet opened a new pull request, #162:
URL: https://github.com/apache/maven-shade-plugin/pull/162
JIRA issue: https://issues.apache.org/jira/browse/MSHADE-419
Shade plugin causes pom to be created without compile dependencies
IT extracted from #149
===
Slawomir Jaranowski created MINSTALL-179:
Summary: installAtEnd when module does not use m-install-p
Key: MINSTALL-179
URL: https://issues.apache.org/jira/browse/MINSTALL-179
Project: Maven Ins
[
https://issues.apache.org/jira/browse/MINSTALL-102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MINSTALL-102.
Fix Version/s: 3.0.0
Resolution: Fixed
Fixed by MINSTALL-115
> installAtE
gnodet commented on PR #80:
URL: https://github.com/apache/maven-parent/pull/80#issuecomment-1287697958
Superseded by #82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
gnodet closed pull request #80: Apply spotless to check/reformat code
URL: https://github.com/apache/maven-parent/pull/80
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
gnodet opened a new pull request, #82:
URL: https://github.com/apache/maven-parent/pull/82
JIRA issue: https://issues.apache.org/jira/browse/MPOM-349
- [MPOM-349] Apply spotless to check/reformat code + poms
- [MPOM-349] Reformat poms
Discussed on
* https://lists.apache.o
Guillaume Nodet created MPOM-349:
Summary: Enable spotless for autoformatting
Key: MPOM-349
URL: https://issues.apache.org/jira/browse/MPOM-349
Project: Maven POMs
Issue Type: Task
[
https://issues.apache.org/jira/browse/MCOMPILER-480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622590#comment-17622590
]
Vasiliy Kudriavtsev commented on MCOMPILER-480:
---
I am getting the same p
58 matches
Mail list logo