[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494603#comment-16494603
]
ASF GitHub Bot commented on METRON-1563:
Github user ottobackwards commented on
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1014
Can I ask how we do ++, --, += etc with the := notation?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1033
+1
I will say, that the exception building facilities and builders should be
publicly exposed as part of stellar as a follow on. As part of my own antlr
work on the syslog stuff, I am kin
[
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494601#comment-16494601
]
ASF GitHub Bot commented on METRON-1579:
Github user ottobackwards commented on
[
https://issues.apache.org/jira/browse/METRON-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494581#comment-16494581
]
Simon Elliston Ball commented on METRON-1583:
-
Would it be possible to share
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494425#comment-16494425
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on the i
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1036
Yeah, I have mixed reactions. I think refactoring opportunistically is
damned useful, but if it becomes excessive it can make it hard to review and
make it hard for those with open branches in the
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494406#comment-16494406
]
ASF GitHub Bot commented on METRON-1584:
Github user mmiklavc commented on the i
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1036
I want to take a step back a moment here. I think there are some useful,
clarifying refactorings in this PR. I'm generally in favor of refactoring
improvements e.g. "handleTick(tuple)" that sum up
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494405#comment-16494405
]
ASF GitHub Bot commented on METRON-1584:
Github user nickwallen commented on a d
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191596670
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(Bul
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494376#comment-16494376
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191592021
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(BulkW
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494366#comment-16494366
]
ASF GitHub Bot commented on METRON-1584:
Github user nickwallen commented on a d
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191590539
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -213,60 +214,144 @@ public void pr
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494357#comment-16494357
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on a dif
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494355#comment-16494355
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191588785
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(BulkW
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191588901
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -213,60 +214,144 @@ public void prep
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494352#comment-16494352
]
ASF GitHub Bot commented on METRON-1584:
Github user nickwallen commented on a d
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191588328
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(Bul
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494348#comment-16494348
]
ASF GitHub Bot commented on METRON-1584:
Github user nickwallen commented on a d
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191587917
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -213,60 +214,144 @@ public void pr
[
https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494330#comment-16494330
]
ASF GitHub Bot commented on METRON-1569:
Github user cestella commented on the i
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1022
Ok, I'm comfortable with the change now. +1 by inspection, pending
@mmiklavc
---
[
https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494329#comment-16494329
]
ASF GitHub Bot commented on METRON-1569:
Github user nickwallen commented on a d
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494328#comment-16494328
]
ASF GitHub Bot commented on METRON-1584:
Github user mmiklavc commented on a dif
Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r191585931
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/field/FieldNameConverters.java
---
@@ -0,0 +1,98 @@
+/*
+ * Licen
Github user mmiklavc commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191585908
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(BulkW
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494322#comment-16494322
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191585015
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java
---
@@ -213,60 +214,144 @@ public void prep
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494320#comment-16494320
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191584626
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(BulkW
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494314#comment-16494314
]
ASF GitHub Bot commented on METRON-1584:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1036#discussion_r191582496
--- Diff:
metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java
---
@@ -115,15 +116,37 @@ public void commit(BulkW
[
https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494273#comment-16494273
]
ASF GitHub Bot commented on METRON-1569:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1022#discussion_r191574312
--- Diff:
metron-platform/metron-common/src/main/java/org/apache/metron/common/field/FieldNameConverters.java
---
@@ -0,0 +1,98 @@
+/*
+ * License
[
https://issues.apache.org/jira/browse/METRON-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494270#comment-16494270
]
ASF GitHub Bot commented on METRON-1298:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/830
-1 as this PR has been abandoned.
---
[
https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494268#comment-16494268
]
ASF GitHub Bot commented on METRON-1569:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1022
All review feedback should have been addressed. Let me know if there is
anything else @mmiklavc @cestella
---
[
https://issues.apache.org/jira/browse/METRON-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494254#comment-16494254
]
ASF GitHub Bot commented on METRON-1479:
Github user nickwallen commented on the
[
https://issues.apache.org/jira/browse/METRON-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494251#comment-16494251
]
ASF GitHub Bot commented on METRON-1472:
Github user nickwallen commented on the
[
https://issues.apache.org/jira/browse/METRON-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494256#comment-16494256
]
ASF GitHub Bot commented on METRON-1478:
Github user nickwallen commented on the
[
https://issues.apache.org/jira/browse/METRON-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494252#comment-16494252
]
ASF GitHub Bot commented on METRON-1480:
Github user nickwallen commented on the
[
https://issues.apache.org/jira/browse/METRON-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494255#comment-16494255
]
ASF GitHub Bot commented on METRON-1474:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/954
-1 as this has become an abandoned PR. I will open a request to close
this.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/956
-1 as this has become an abandoned PR. I will open a request to close this
PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/952
-1 as this has become an abandoned PR. I will open a request to close
this.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/951
-1 as this has become an abandoned PR. I will open a request to close this
PR.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/953
-1 as this has become an abandoned PR. I will open a request to close
this.
---
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494207#comment-16494207
]
ASF GitHub Bot commented on METRON-1563:
Github user cestella commented on the i
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1014
Do we want to expand assignment to `:=` as part of this PR or make it a
follow-on in this feature branch? I'm ok with either way.
---
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494185#comment-16494185
]
ASF GitHub Bot commented on METRON-1563:
Github user cestella commented on the i
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1014
>Ultimately, I'd like to see us move to supporting = as that is just way
more intuitive for most people. Maybe that means supporting both = and := for
some period of time?
In my opinion we
[
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494156#comment-16494156
]
ASF GitHub Bot commented on METRON-1579:
GitHub user cestella reopened a pull re
[
https://issues.apache.org/jira/browse/METRON-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494153#comment-16494153
]
ASF GitHub Bot commented on METRON-1568:
Github user mmiklavc commented on the i
[
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494155#comment-16494155
]
ASF GitHub Bot commented on METRON-1579:
Github user cestella closed the pull re
GitHub user cestella reopened a pull request:
https://github.com/apache/metron/pull/1033
METRON-1579: Stellar should return the expression that failed in the
exception
## Contributor Comments
There are situations where we are not including the expression in the
exception. Also,
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1021
+1 via inspection.
---
Github user cestella closed the pull request at:
https://github.com/apache/metron/pull/1033
---
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494063#comment-16494063
]
ASF GitHub Bot commented on METRON-1563:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1014
> I am not sure how this PR impacts all the places where Stellar is used
and assignment .. Or maybe that is left to a future PR?
Sorry, its a little hard to digest that old PR, but I thin
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494059#comment-16494059
]
ASF GitHub Bot commented on METRON-1563:
Github user nickwallen commented on the
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1014
> Should assignment be = or :=?
Ultimately, I'd like to see us move to supporting `=` as that is just way
more intuitive for most people. Maybe that means supporting both `=` and `:=`
f
[
https://issues.apache.org/jira/browse/METRON-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494013#comment-16494013
]
ASF GitHub Bot commented on METRON-1544:
Github user asfgit closed the pull requ
Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1015
---
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493999#comment-16493999
]
ASF GitHub Bot commented on METRON-1563:
Github user cestella commented on the i
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1014
Should assignment be `=` or `:=`? I'm not super opinionated other than we
have been using `:=` and we'd break existing installations if we move to `=`,
right?
---
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1015
+1 for sure
---
[
https://issues.apache.org/jira/browse/METRON-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493982#comment-16493982
]
ASF GitHub Bot commented on METRON-1544:
Github user cestella commented on the i
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493980#comment-16493980
]
ASF GitHub Bot commented on METRON-1584:
GitHub user nickwallen opened a pull re
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1036
METRON-1584 Indexing Topology Crashes with Invalid Message
If the indexing topology receives a message containing invalid JSON, the
topology will crash. The topology needs to handle these types
[
https://issues.apache.org/jira/browse/METRON-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493968#comment-16493968
]
ASF GitHub Bot commented on METRON-1577:
Github user cestella commented on the i
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1031
@merrimanr can you close this PR since it's been committed?
---
[
https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Allen reassigned METRON-1584:
--
Assignee: Nick Allen
> Indexing Topology Crashes with Invalid Message
> -
Nick Allen created METRON-1584:
--
Summary: Indexing Topology Crashes with Invalid Message
Key: METRON-1584
URL: https://issues.apache.org/jira/browse/METRON-1584
Project: Metron
Issue Type: Bug
[
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493940#comment-16493940
]
ASF GitHub Bot commented on METRON-1579:
Github user cestella commented on the i
[
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493939#comment-16493939
]
ASF GitHub Bot commented on METRON-1579:
Github user cestella commented on a dif
Github user cestella commented on the issue:
https://github.com/apache/metron/pull/1033
@ottobackwards That makes sense. How do you like it now?
---
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1033#discussion_r191513907
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/BaseStellarProcessor.java
---
@@ -143,7 +143,11 @@ public T parse(f
[
https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493935#comment-16493935
]
ASF GitHub Bot commented on METRON-1579:
Github user cestella commented on a dif
Github user cestella commented on a diff in the pull request:
https://github.com/apache/metron/pull/1033#discussion_r191513381
--- Diff:
metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/stellar/StellarAdapter.java
---
@@ -92,6 +96,19 @@ public
[
https://issues.apache.org/jira/browse/METRON-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493834#comment-16493834
]
ASF GitHub Bot commented on METRON-1544:
Github user mmiklavc commented on the i
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1015
lgtm, +1
---
[
https://issues.apache.org/jira/browse/METRON-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
manisha tank updated METRON-1583:
-
Attachment: cisco_asa_logs_error.png
> issue regarding cisco asa logs
>
manisha tank created METRON-1583:
Summary: issue regarding cisco asa logs
Key: METRON-1583
URL: https://issues.apache.org/jira/browse/METRON-1583
Project: Metron
Issue Type: Bug
Affects V
manisha tank created METRON-1582:
Summary: after installation of metron in ubuntu my system is hang
Key: METRON-1582
URL: https://issues.apache.org/jira/browse/METRON-1582
Project: Metron
Iss
88 matches
Mail list logo