Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/168
@phrocker Sure thing. I'm not with the project that needed minifi anymore,
but I'm still interested in seeing these changes implemented.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
Squashed.
@phrocker No, I didn't create a benchmark. The slowdown is surprising,
though. I can't prove it, but I think larger production payloads will show
improvement.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
@phrocker Honestly, I just reimplemented the JSON handling in RapidJSON as
well as I could, and fixed the things that broke the build and tests. Help
would be greatly appreciated.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
I see it in df353561c8a8a0a0d1178a76f03b966b44542834. Hopefully that commit
hash will resolve once the sync is complete. Thanks!
---
Github user calebj closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/185
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
I did. The new commit messages reflect the new version, too.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/157
@phrocker Sure, I'll do that when I get a chance to.
---
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r153602526
--- Diff: CMakeLists.txt ---
@@ -173,6 +173,12 @@ if (ENABLE_TENSORFLOW)
createExtension(TENSORFLOW-EXTENSIONS "TENSORFLOW EXTENSIONS&q
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r153566702
--- Diff: CMakeLists.txt ---
@@ -173,6 +173,12 @@ if (ENABLE_TENSORFLOW)
createExtension(TENSORFLOW-EXTENSIONS "TENSORFLOW EXTENSIONS&q
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
See if it works after the next push. I'm putting 5.8.6 in afresh and
disabling the tests in a cleaner fashion.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/185
Weird. Nothing in the process should have changed. Where is that happening?
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/206
This causes some tests to fail to link on Linux both on Travis CI and
cloud9, both of which are Ubuntu Trusty. Here's the output:
```
[ 19%] Linking CXX executable TestExecutePr
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/203
Should be fine now, I think.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/203
Still some issues to work out.
---
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/203
MINIFICPP-251 Move Civet implementations to an extension.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/199
I'm too late, but removing the `CATCH_CONFIG_MAIN` and linking to
`${CATCH_MAIN_LIB}` instead would be mode consistent with the other extensions'
test creation script. I'l
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/198
Superceded by #199
---
Github user calebj closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/198
---
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/198
Fix travis-breaking linter error in TensorFlowTests.cpp
Is a JIRA ticket necessary for this? It's literally a difference of one
character.
Thank you for submitting a contrib
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r152182652
--- Diff: extensions/libarchive/UnfocusArchiveEntry.cpp ---
@@ -67,55 +66,41 @@ void
UnfocusArchiveEntry::onTrigger(core::ProcessContext *context
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r152180661
--- Diff: libminifi/src/RemoteProcessorGroupPort.cpp ---
@@ -264,20 +264,27 @@ void
RemoteProcessorGroupPort::refreshRemoteSite2SiteInfo
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
I know that it's MIT licensed, but their license.txt comes with others
tacked on for subcomponents. If you think they're all compatible, I'll copy all
of them in.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/191
@achristianson something in the master branch is failing. Looks like
something in the commit before the latest one,
9b9c3354330d525cfdd50f656ae42fc3da80764c, broke it.
Regarding the
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151581577
--- Diff: extensions/http-curl/protocols/RESTReceiver.cpp ---
@@ -65,38 +65,8 @@ void RESTReceiver::initialize(const
std::shared_ptr
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151581091
--- Diff: extensions/http-curl/protocols/RESTProtocol.cpp ---
@@ -81,48 +93,117 @@ const C2Payload RESTProtocol::parseJsonResponse(const
C2Payload
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151580773
--- Diff: extensions/http-curl/protocols/RESTProtocol.cpp ---
@@ -81,48 +93,117 @@ const C2Payload RESTProtocol::parseJsonResponse(const
C2Payload
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151580663
--- Diff:
libminifi/src/core/reporting/SiteToSiteProvenanceReportingTask.cpp ---
@@ -53,54 +56,92 @@ void SiteToSiteProvenanceReportingTask
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191#discussion_r151580153
--- Diff: extensions/http-curl/protocols/RESTProtocol.cpp ---
@@ -81,48 +93,117 @@ const C2Payload RESTProtocol::parseJsonResponse(const
C2Payload
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/191
MINIFICPP-114 Consolidate JSON API use to RapidJSON
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/156
Should be ready now. Check to see if the exceptions and error output on
misconfigurations fits what you want.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/156
Is this waiting on #181? I have another branch based on that code I can
push this PR if needed. Otherwise, is there an estimate as to when this might
be merged?
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/157
Is there an estimate as to when this can be merged?
---
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/185
MINIFICPP-303 Upgrade civetweb and rocksdb
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/184
MINIFICPP-302 Correct USB camera createExtension
Configuration fails because the USB camera extension's createExtension in
the top-level CMakeLists wasn't updated to match the
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/170#discussion_r150017488
--- Diff: .travis.yml ---
@@ -84,4 +84,4 @@ matrix:
- package='libpng'; [[ $(brew ls --versions ${package}) ]] &&
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/180
MINIFICPP-258 enable C2NullConfiguration test
Not entirely sure if this is correct; I'm just going off of what the spec
was before this test was removed. It appears to run just fine on
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/169
MINIFICPP-282 Improve test build speed, add Travis build cache
Split off from MINIFICPP-280 #168 as requested
Thank you for submitting a contribution to Apache NiFi - MiNiFi C
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157#discussion_r148581669
--- Diff: extensions/bustache/ApplyTemplate.cpp ---
@@ -0,0 +1,100 @@
+/**
+ * @file ApplyTemplate.cpp
+ * ApplyTemplate class
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/168
MINIFICPP-280 Refactoring and various improvements
- move extension tests into their respective folders
- separate source and header files
- remove unnecessary or nonexisting include
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r148094619
--- Diff: CMakeLists.txt ---
@@ -111,38 +111,38 @@ add_subdirectory(libminifi)
#function(createExtension extensionCondition extensionGuard
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147534705
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156#discussion_r147534442
--- Diff: extensions/libarchive/ManipulateArchive.cpp ---
@@ -0,0 +1,309 @@
+/**
+ * @file ManipulateArchive.cpp
+ * ManipulateArchive
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/157
MINIFI-269 Implement ApplyTemplate processor
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/156
MINIFICPP-268 Implement ManipulateArchive processor
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker That was the last one, I promise.
---
Github user calebj commented on the pull request:
https://github.com/apache/nifi-minifi-cpp/commit/a0268cf374c3e632fde89352d77dcf1be29d75dc#commitcomment-25237614
In .travis.yml:
In .travis.yml on line 68:
It was the only way to get the build under Travis's 50 minute
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
The build fails both with or without the `struct` keyword; I'll try a
different approach next. There are also some other things I forgot to add when
moving to the extension.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker I already have a travis-ci.org account, but I've granted access
to @NifiLocal and synced the account.
---
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146919029
--- Diff: libminifi/include/processors/ExtractText.h ---
@@ -0,0 +1,91 @@
+/**
+ * @file ExtractText.h
+ * ExtractText class declaration
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146907747
--- Diff: libminifi/include/processors/ExtractText.h ---
@@ -0,0 +1,91 @@
+/**
+ * @file ExtractText.h
+ * ExtractText class declaration
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker Cool. I can squash into one commit and force push, if needed.
---
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146861542
--- Diff: libminifi/src/processors/ExtractText.cpp ---
@@ -0,0 +1,105 @@
+/**
+ * @file ExtractText.cpp
+ * ExtractText class
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/152#discussion_r146861365
--- Diff: libminifi/src/processors/ExtractText.cpp ---
@@ -0,0 +1,105 @@
+/**
+ * @file ExtractText.cpp
+ * ExtractText class
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
I'm changing the types for size, mtime and mtime_nsec in
`ArchiveEntryMetadata`'s declaration instead of casting. Why'd you take out the
boost header include?
---
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/152
MINIFICPP-52 basic ExtractText processor
Regex support blocked by dynamic properties, #37
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
@phrocker For the first error, I'm pretty sure the only type it can convert
to is int64. The JsonCPP docs don't have any ambiguities there, it's just
signed and unsigne
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
Thank @achristianson for the original implementation, way back in
March/April against 070d8758fded4836f17816c1b1a34a48aa1bba20. I just brought it
up to date.
---
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
Rebased.
---
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145747588
--- Diff: libminifi/include/core/FlowConfiguration.h ---
@@ -35,6 +35,8 @@
#include "processors/ExecuteProcess.h"
#include &
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145747665
--- Diff: libminifi/include/FlowFileRecord.h ---
@@ -164,6 +164,11 @@ class FlowFileRecord : public core::FlowFile, public
io::Serializable
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145743863
--- Diff: libminifi/src/processors/FocusArchiveEntry.cpp ---
@@ -0,0 +1,340 @@
+/**
+ * @file FocusArchiveEntry.cpp
+ * FocusArchiveEntry
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145744191
--- Diff: libminifi/include/processors/FocusArchiveEntry.h ---
@@ -0,0 +1,115 @@
+/**
+ * @file FocusArchiveEntry.h
+ * FocusArchiveEntry
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145743845
--- Diff: LICENSE ---
@@ -534,4 +534,68 @@ ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145744366
--- Diff: libminifi/include/core/ProcessSession.h ---
@@ -19,6 +19,7 @@
#define __PROCESS_SESSION_H__
#include
+#include
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/148
Things left to look into:
* [ ] Move things which depend on libarchive to an extension
* [ ] Use streams for exportContent
* [ ] Move exportContent ReadCallback to another file
---
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145745217
--- Diff: libminifi/include/processors/FocusArchiveEntry.h ---
@@ -0,0 +1,115 @@
+/**
+ * @file FocusArchiveEntry.h
+ * FocusArchiveEntry
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145744343
--- Diff: libminifi/include/core/FlowFile.h ---
@@ -50,6 +50,32 @@ class FlowFile : public core::Connectable {
void clearResourceClaim
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145743879
--- Diff: libminifi/src/processors/FocusArchiveEntry.cpp ---
@@ -0,0 +1,340 @@
+/**
+ * @file FocusArchiveEntry.cpp
+ * FocusArchiveEntry
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145743902
--- Diff: libminifi/src/processors/FocusArchiveEntry.cpp ---
@@ -0,0 +1,340 @@
+/**
+ * @file FocusArchiveEntry.cpp
+ * FocusArchiveEntry
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145742734
--- Diff: LICENSE ---
@@ -534,4 +534,68 @@ ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR
Github user calebj commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148#discussion_r145738276
--- Diff: CMakeLists.txt ---
@@ -101,6 +101,7 @@ set(CIVETWEB_ENABLE_SSL_DYNAMIC_LOADING OFF CACHE BOOL
"Disable dynamic SSL libr
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/148
MINIFI-244 Un/FocusArchive processors
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to
GitHub user calebj opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/139
MINIFI-388 Backport the rest of EVP_Digest for civetweb
As per the discussion in apache/nifi-minifi-cpp#131. This is a backport of
the `#define` declaration of `EVP_Digest()` and the
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
I'm building on Cloud9, which has Ubuntu 14.04 with GCC 4.8.4, against
OpenSSL version is 1.0.1f-1ubuntu2.22 if it helps.
The specific error was:
```
[ 45%] Building C o
Github user calebj commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/131
This doesn't build for me without backporting the `#define` for EVP_Digest
and the matching entry in `crypto_sw`. I added these in
66dc8f039ca0fa1af362c11a5bcc43475456bc74; should I c
75 matches
Mail list logo
