Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1018
+1 LGTM, great addition here, thanks! Merging to master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1018
> (who uses Hex literals for floating point?!),
I do! Like... All the time!
But I also joke sometimes...
:smiley:
---
If your project is set up for it, you can reply to this
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1018
@mattyb149 just pushed out a new commit along with yours. I added proper
support for literal decimals in the UI as well.
---
If your project is set up for it, you can reply to this email and have
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1018
@mattyb149 this is awesome! I was having bit of trouble trying with the
grammar due to not knowing much about ANTLR. I'm gonna add your commit to my
branch, test it a bit and then add it to the PR.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1018
I'm a big ANTLR fan :) so I tried adding decimal literals to the grammar,
feel free to take a look and use whatever you like:
https://github.com/mattyb149/nifi/commit/9ed3fb4f17b0ec64fbe9d861ff25575
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1018
@mattyb149, I agree with adding it to the lexer as a subset. I thought
through it a bit more and is someone passes "toLiteral('1.1')" they should
expect they would get a string with the value "1.1"
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1018
I like the idea of a subset, we can probably cover 90% of the cases people
have for floating-point literals (who uses Hex literals for floating point?!),
but it might warrant a discussion with the c
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/1018
@mattyb149 the problem was that the parsing for the various representations
of doubles in Java is crazy, Check out the pattern used in this
documentation[1]. I guess we could offer a sub-set of the
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1018
Why are decimal literals expected to be in String format? Seems like the
Lexer should be able to determine a decimal literal from a whole number literal?
---
If your project is set up for it, you c