mosermw closed pull request #8064: NIFI-12386 Adds processor FilterAttribute
(Java 1.8 / NiFi 1.x)
URL: https://github.com/apache/nifi/pull/8064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mosermw commented on PR #8064:
URL: https://github.com/apache/nifi/pull/8064#issuecomment-1834609921
I've finished testing on the support/nifi-1.x branch and this processor
works in the supported scenarios. So +1 I will merge. We should have plenty
of time to resolve NIFI-12446 before
EndzeitBegins commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411247112
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
+/*
+
exceptionfactory commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411228506
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
EndzeitBegins commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411227342
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
+/*
+
exceptionfactory commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411218921
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
mosermw commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411216311
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
+/*
+ *
exceptionfactory commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411211679
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
exceptionfactory commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411210531
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
exceptionfactory commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411197372
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
EndzeitBegins commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411204064
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
+/*
+
EndzeitBegins commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411201844
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
+/*
+
exceptionfactory commented on code in PR #8064:
URL: https://github.com/apache/nifi/pull/8064#discussion_r1411195445
##
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FilterAttribute.java:
##
@@ -0,0 +1,273 @@
EndzeitBegins commented on PR #8064:
URL: https://github.com/apache/nifi/pull/8064#issuecomment-1834442892
No worries, I just wasn't sure you're aware there is a backport available.
Thanks for your work.
--
This is an automated message from the Apache Git Service.
To respond to the
mosermw commented on PR #8064:
URL: https://github.com/apache/nifi/pull/8064#issuecomment-1834438804
Yes, sorry, I meant to note that I'm testing this one now. The code looks
good, just doing a final test.
--
This is an automated message from the Apache Git Service.
To respond to the
EndzeitBegins commented on PR #8064:
URL: https://github.com/apache/nifi/pull/8064#issuecomment-1834427491
Thank you for reviewing and merging #8049, @mosermw.
Can we backport the new processor for the 1.x track as well? I would
appreciate a review as you're familiar with the
16 matches
Mail list logo
