[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663300#comment-16663300
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-373:
--
Summary: Tolerate the last half written log entry (was: Tolerate half
written log entry
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: r352_20181025b.patch
> Persist commit index in Raft log.
> -
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: (was: r352_20181025.patch)
> Persist commit index in Raft log.
> ---
Tsz Wo Nicholas Sze created RATIS-373:
-
Summary: Tolerate half written log entry
Key: RATIS-373
URL: https://issues.apache.org/jira/browse/RATIS-373
Project: Ratis
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/RATIS-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663270#comment-16663270
]
Tsz Wo Nicholas Sze commented on RATIS-370:
---
r370_20181025.patch: fixes #1 and a
[
https://issues.apache.org/jira/browse/RATIS-370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-370:
--
Attachment: r370_20181025.patch
> TestRaftServerSlownessDetection keep failing
> ---
[
https://issues.apache.org/jira/browse/RATIS-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663241#comment-16663241
]
Tsz Wo Nicholas Sze commented on RATIS-370:
---
Found two problems:
# Minor: The Re
Josh Elser created RATIS-372:
Summary: Basic test harness for LogService
Key: RATIS-372
URL: https://issues.apache.org/jira/browse/RATIS-372
Project: Ratis
Issue Type: Task
Components:
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663022#comment-16663022
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663015#comment-16663015
]
Josh Elser commented on RATIS-369:
--
Hahah. Thanks Vlad! :)
> LogService read/write path
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663004#comment-16663004
]
Vladimir Rodionov commented on RATIS-369:
-
{quote}
What's the UNDEFINED for?
{quot
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663001#comment-16663001
]
Vladimir Rodionov commented on RATIS-369:
-
{quote}
Do we want Test in the file nam
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662997#comment-16662997
]
Vladimir Rodionov edited comment on RATIS-369 at 10/24/18 11:37 PM:
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662999#comment-16662999
]
Josh Elser commented on RATIS-369:
--
bq. Hmm, this is what I usually try to avoid : workin
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662997#comment-16662997
]
Vladimir Rodionov commented on RATIS-369:
-
Hmm, this is what I usually try to avoi
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662988#comment-16662988
]
Josh Elser commented on RATIS-369:
--
[~vrodionov], you should be good to rebase this on to
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662985#comment-16662985
]
Tsz Wo Nicholas Sze commented on RATIS-352:
---
r352_20181025.patch: sync'ed after
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: (was: r352_20181024.patch)
> Persist commit index in Raft log.
> ---
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: r352_20181025.patch
> Persist commit index in Raft log.
> --
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser resolved RATIS-334.
--
Resolution: Fixed
Fix Version/s: 0.3.0
Thanks for the patch, [~sergey.soldatov]. This is a nice s
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662965#comment-16662965
]
Josh Elser commented on RATIS-334:
--
Had to tweak the protobuf-compiler pom stuff to accou
[
https://issues.apache.org/jira/browse/RATIS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662958#comment-16662958
]
Tsz Wo Nicholas Sze commented on RATIS-371:
---
[~jnp], thanks for review the patch
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662909#comment-16662909
]
Josh Elser commented on RATIS-334:
--
Thanks for the quick feedback, Sergey. Let's just pla
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662888#comment-16662888
]
Vladimir Rodionov commented on RATIS-334:
-
Someone (me or Sergey) should stop and
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662883#comment-16662883
]
Sergey Soldatov commented on RATIS-334:
---
bq. Just remove these from LogStateMachine
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662854#comment-16662854
]
Sergey Soldatov commented on RATIS-334:
---
bq. equals(Object), toString(), and hashCod
[
https://issues.apache.org/jira/browse/RATIS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662801#comment-16662801
]
Jitendra Nath Pandey commented on RATIS-371:
Thanks for fixing these. As I und
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662762#comment-16662762
]
Vladimir Rodionov commented on RATIS-334:
-
np, I will rebase RATIS-369 on top of t
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662751#comment-16662751
]
Josh Elser commented on RATIS-334:
--
{code:java}
+public class LogInfo {
{code}
{{equals(O
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josh Elser updated RATIS-334:
-
Component/s: LogService
> Implement server membership for LogService Metadata Service
> --
[
https://issues.apache.org/jira/browse/RATIS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662412#comment-16662412
]
Hadoop QA commented on RATIS-371:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662378#comment-16662378
]
Tsz Wo Nicholas Sze commented on RATIS-352:
---
Filed RATIS-371.
> Persist commit
[
https://issues.apache.org/jira/browse/RATIS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-371:
--
Attachment: r371_20181024.patch
> Change tests so that they do not depend on consecutive
[
https://issues.apache.org/jira/browse/RATIS-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662376#comment-16662376
]
Tsz Wo Nicholas Sze commented on RATIS-371:
---
r371_20181024.patch: split the test
Tsz Wo Nicholas Sze created RATIS-371:
-
Summary: Change tests so that they do not depend on consecutive
log indices
Key: RATIS-371
URL: https://issues.apache.org/jira/browse/RATIS-371
Project: Rat
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662354#comment-16662354
]
Tsz Wo Nicholas Sze commented on RATIS-352:
---
Thanks [~jnp] for reviewing the pat
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662221#comment-16662221
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662218#comment-16662218
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
Tsz Wo Nicholas Sze created RATIS-370:
-
Summary: TestRaftServerSlownessDetection keep failing
Key: RATIS-370
URL: https://issues.apache.org/jira/browse/RATIS-370
Project: Ratis
Issue Type
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662115#comment-16662115
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661994#comment-16661994
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661892#comment-16661892
]
Jitendra Nath Pandey commented on RATIS-352:
+1 for the latest patch.
> Persi
[
https://issues.apache.org/jira/browse/RATIS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661890#comment-16661890
]
Sergey Soldatov commented on RATIS-369:
---
Why do we need the snapshot support? In the
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661868#comment-16661868
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661843#comment-16661843
]
Tsz Wo Nicholas Sze commented on RATIS-352:
---
r352_20181024.patch: fixes some tes
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: r352_20181024.patch
> Persist commit index in Raft log.
> --
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: (was: r352_20181023b.patch)
> Persist commit index in Raft log.
> --
48 matches
Mail list logo