Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/971
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r78096463
--- Diff: lib/records/I_RecCore.h ---
@@ -168,11 +169,15 @@ int RecGetRecordBool(const char *name, RecBool
*rec_byte, bool lock = true);
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r78096159
--- Diff: lib/records/I_RecCore.h ---
@@ -168,11 +169,15 @@ int RecGetRecordBool(const char *name, RecBool
*rec_byte, bool lock = true);
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r78096037
--- Diff: lib/records/RecCore.cc ---
@@ -514,6 +514,18 @@ RecLookupMatchingRecords(unsigned rec_type, const char
*match, void (*callback)(
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r78089641
--- Diff: lib/records/I_RecCore.h ---
@@ -168,11 +169,15 @@ int RecGetRecordBool(const char *name, RecBool
*rec_byte, bool lock = true);
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r78089078
--- Diff: lib/records/RecCore.cc ---
@@ -514,6 +514,18 @@ RecLookupMatchingRecords(unsigned rec_type, const char
*match, void (*callback)(
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r77874593
--- Diff: proxy/Main.cc ---
@@ -476,6 +476,18 @@ check_config_directories(void)
}
}
+namespace {
+ // Values with
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r77854033
--- Diff: proxy/Main.cc ---
@@ -476,6 +476,18 @@ check_config_directories(void)
}
}
+namespace {
+ // Values with names that
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/971#discussion_r77714260
--- Diff: proxy/Main.cc ---
@@ -476,6 +476,18 @@ check_config_directories(void)
}
}
+namespace {
+ // Values with names that
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/971
TS-1882: Check for unrecognized configuration values.
You can merge this pull request into a Git repository by running:
$ git pull
10 matches
Mail list logo
