Re: RFR: JDK-8272984: javadoc support for reproducible builds [v4]

2022-01-26 Thread Hannes Wallnöfer
On Tue, 25 Jan 2022 19:43:08 GMT, Jonathan Gibbons wrote: >> Please review a javadoc update to support a new `--date` option to support >> reproducible builds. >> >> This pull request supersedes https://github.com/openjdk/jdk/pull/6905. In >> that PR, the `SOURCE_DATE_EPOCH` environment variab

Re: RFR: JDK-8272984: javadoc support for reproducible builds [v4]

2022-01-26 Thread Jonathan Gibbons
On Wed, 26 Jan 2022 11:31:06 GMT, Hannes Wallnöfer wrote: > Looks good to me. > > The CSR should be updated to reflect the changed option help message. Talking > about that change: I'm a bit unsure about it, as ISO 8601 does not include > the optional zone ID, which is an extension in > `Date

Re: RFR: JDK-8280488: doclint reference checks withstand warning suppression [v2]

2022-01-26 Thread Jonathan Gibbons
> Please review a small modification to the way that bad references are > reported by DocLint. > > A new "mode" is introduced, `strictReferenceChecks`. > > If the mode is _not_ set, references that explicitly include a module name > when that module name is not resolved in the module graph w

Re: RFR: JDK-8280488: doclint reference checks withstand warning suppression

2022-01-26 Thread Jonathan Gibbons
On Wed, 26 Jan 2022 02:46:45 GMT, Joe Darcy wrote: > Question: for the JDK use case in particular, to turn all the doclint warning > on during compilation, the cross-module references need to be > SuppressWarning'ed? Only forward references, where the target module is not on the module path,

Integrated: 8268978: Document the javadoc software stack

2022-01-26 Thread Jonathan Gibbons
On Wed, 22 Dec 2021 00:48:08 GMT, Jonathan Gibbons wrote: > Please review a `noreg-doc` update to document the javadoc software stack, in > the top-level `jdk.javadoc.internal` package. > > The intent is to provide a broad overview. We can add more specific > details, but in general, additio

Integrated: JDK-8280402: Add new convenience forms to HtmlTree

2022-01-26 Thread Jonathan Gibbons
On Thu, 20 Jan 2022 19:31:41 GMT, Jonathan Gibbons wrote: > Please review a simple `noreg-clean` update to `HtmlTree` and a couple of > friends. The updates are to continue the trend towards the use of Facebook > tory methods for `HtmlTree` objects, and to leverage generic methods and > lambd

RFR: JDK-8280738: Minor cleanup for HtmlStyle

2022-01-26 Thread Jonathan Gibbons
Please review a simple update to reorder some members of the enum `HtmlStyle`, and to make some minor updates to the comments. This is to facilitate automated extraction of information into an upcoming new spec for the output from the standard doclet. - Commit messages: - JDK-8280

RFR: JDK-8280534: Enable compile-time doclint reference checking

2022-01-26 Thread Joe Darcy
The changes in this PR on top of the out-for-review changes in https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint checking to be enabled in all JDK modules. Typically, a @SuppressWarnings("doclint:refernce") annotation is added to declaration with javadoc blocks that have alr

Re: RFR: JDK-8280534: Enable compile-time doclint reference checking

2022-01-26 Thread Sergey Bylokhov
On Wed, 26 Jan 2022 20:05:07 GMT, Joe Darcy wrote: > The changes in this PR on top of the out-for-review changes in > https://git.openjdk.java.net/jdk/pull/7222 allow compile-time doclint > checking to be enabled in all JDK modules. > > Typically, a @SuppressWarnings("doclint:refernce") annota

RFR: JDK-8279486: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy

2022-01-26 Thread Jonathan Gibbons
Please review a small test update to have this test pass if the main`src/` directory cannot be found. (Yes, apparently that happens in some testing scenarios.) - Commit messages: - JDK-8279486: jdk/javadoc/tool/CheckManPageOptions.java depends on source hierarchy Changes: https:/