Re: RFR: JDK-8323628: Update license on "pass-through" files

2024-01-30 Thread Hannes Wallnöfer
On Fri, 12 Jan 2024 23:37:28 GMT, Jonathan Gibbons wrote: > Please review an update to change the license used on those files that get > written by `javadoc` into any generated API doc bundles. The license is > changed to the Universal Permissive License in all situations. > > A new test is ad

Re: RFR: JDK-8322874: Redirection loop in index.html

2024-01-30 Thread Hannes Wallnöfer
On Thu, 4 Jan 2024 21:06:17 GMT, Jonathan Gibbons wrote: > Please review a simple fix to address an apparently long-standing issue of > generating a redirection loop in the top-level `index.html` file. > > The fix is simply to remove some obsolete/unnecessary code in > `HtmlConfiguration.setTo

Re: RFR: JDK-8322865: JavaDoc fails on aggregator modules

2024-01-30 Thread Hannes Wallnöfer
On Thu, 4 Jan 2024 21:27:06 GMT, Jonathan Gibbons wrote: > Please review a simple fix that JavaDoc fails when asked to just generate > documentation for an aggegator module, or for any module that contains no > classes or interfaces to be documented, such as a service-provider module. > > The

Re: RFR: JDK-8323628: Update license on "pass-through" files

2024-01-30 Thread Pavel Rappo
On Fri, 12 Jan 2024 23:37:28 GMT, Jonathan Gibbons wrote: > Please review an update to change the license used on those files that get > written by `javadoc` into any generated API doc bundles. The license is > changed to the Universal Permissive License in all situations. > > A new test is ad

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v2]

2024-01-30 Thread Hannes Wallnöfer
On Tue, 23 Jan 2024 05:21:17 GMT, psoujany wrote: >> @psoujany just to make sure we're on the same page, you'll also update the >> tests required by this change? > > @hns I've modified regression tests with the code changes and see langtools > jtreg tests passing with the new fixes. Could you p

Re: RFR: JDK-8164094: javadoc allows to create a @link to a non-existent method [v2]

2024-01-30 Thread Hannes Wallnöfer
On Mon, 29 Jan 2024 22:11:25 GMT, Jonathan Gibbons wrote: > All that is out of scope for here, and can be handled in > [JDK-8324320](https://bugs.openjdk.org/browse/JDK-8324320), so I have one > last question before I add my approval (or Pavel can lower the `/reviewer` > count): Does this chan

Re: RFR: JDK-8164094: javadoc allows to create a @link to a non-existent method [v2]

2024-01-30 Thread Hannes Wallnöfer
On Tue, 12 Dec 2023 12:42:41 GMT, Hannes Wallnöfer wrote: >> Please review a simple fix in `JavacTrees` to only look up member references >> in the enclosing type if the reference does not contain an explicit type >> name. For example, `@see #method()` in a a doc comment of class >> `Outer.Inn

RFR: JDK-8324774: Add DejaVu web fonts

2024-01-30 Thread Hannes Wallnöfer
This change adds the DejaVu web fonts that were previously maintained externally to the open repository so they are available both in JDK API documentation and any API documentation generated with the `javadoc` tool. All files added in this PR are the same as the ones previously maintained exte

Re: RFR: JDK-8324774: Add DejaVu web fonts

2024-01-30 Thread Magnus Ihse Bursie
On Tue, 30 Jan 2024 16:13:42 GMT, Hannes Wallnöfer wrote: > This change adds the DejaVu web fonts that were previously maintained > externally to the open repository so they are available both in JDK API > documentation and any API documentation generated with the `javadoc` tool. > All files a

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Mon, 22 Jan 2024 15:35:41 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8164094: javadoc allows to create a @link to a non-existent method [v2]

2024-01-30 Thread Joe Darcy
On Wed, 13 Dec 2023 10:44:43 GMT, Hannes Wallnöfer wrote: > > Should this issue have a CSR for the behavioral change? > > My understanding of the issue is that the lookup of explicit-class member > references in enclosing classes was an unintended consequence of doing the > same for classless

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Tue, 23 Jan 2024 12:01:38 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Thu, 25 Jan 2024 12:41:02 GMT, Pavel Rappo wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java >> line 1388: >> >>> 1386: * @see >> href="https://spec.commonmark.org/0.30/#thematic-breaks";>Thematic Break >>> 1387: */ >>> 1388:

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Tue, 23 Jan 2024 12:50:45 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Tue, 23 Jan 2024 15:07:15 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Mon, 22 Jan 2024 16:57:16 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Tue, 23 Jan 2024 15:17:14 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Wed, 24 Jan 2024 12:17:19 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v10]

2024-01-30 Thread Jonathan Gibbons
On Wed, 24 Jan 2024 16:24:25 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - fix @since tags >> - fix copyright year > > src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Wed, 24 Jan 2024 16:30:50 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Wed, 24 Jan 2024 19:43:51 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v7]

2024-01-30 Thread Jonathan Gibbons
On Wed, 24 Jan 2024 22:38:58 GMT, Pavel Rappo wrote: >> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains eight commits: >> >> - Merge with upstream/master >> - Merge with upstream/master >> - Merge remote-tracki

Re: RFR: JDK-8298405: Support Markdown in Documentation Comments [v11]

2024-01-30 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: JDK-8311893: Interactive component with ARIA role 'tabpanel' does not have a programmatically associated name [v10]

2024-01-30 Thread psoujany
> Interactive component with ARIA role 'tabpanel' does not have a > programmatically associated name in javadoc which is failing Accessibility > checks. > https://bugs.openjdk.org/browse/JDK-8311893 > https://bugs.openjdk.org/browse/JDK-8311894 psoujany has updated the pull request with a new ta