Re: RFR: 8345555: Improve layout of search results [v6]

2025-03-12 Thread Hannes Wallnöfer
> Please review an enhancement to JavaDoc search to provide more context and a > nicer layout for search results. This adds a new "kind" field to the search > index to describes search items, such as "Static method", "Interface, or > "System property" etc. Additionally, the drop-down search box

Re: RFR: 8345555: Improve layout of search results [v8]

2025-03-12 Thread Hannes Wallnöfer
> Please review an enhancement to JavaDoc search to provide more context and a > nicer layout for search results. This adds a new "kind" field to the search > index to describes search items, such as "Static method", "Interface, or > "System property" etc. Additionally, the drop-down search box

Re: RFR: 8351626: Update remaining icons to SVG format

2025-03-12 Thread Jonathan Gibbons
On Wed, 12 Mar 2025 13:22:07 GMT, Hannes Wallnöfer wrote: > Please review a change to update the remaining `.png` files used by JavaDoc > with `.svg` files. In addition to the looking glass and "x" icons used in the > search box this also adds left and right pointing angles used in breadcrumb

Integrated: 8351626: Update remaining icons to SVG format

2025-03-12 Thread Hannes Wallnöfer
On Wed, 12 Mar 2025 13:22:07 GMT, Hannes Wallnöfer wrote: > Please review a change to update the remaining `.png` files used by JavaDoc > with `.svg` files. In addition to the looking glass and "x" icons used in the > search box this also adds left and right pointing angles used in breadcrumb

Re: RFR: 8351881: Tidy complains about missing "alt" attribute

2025-03-12 Thread Jonathan Gibbons
On Wed, 12 Mar 2025 18:51:07 GMT, Nizar Benalla wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/TableOfContents.java >> line 114: >> >>> 112: .put(HtmlAttr.SRC, >>> writer.pathToRoot.resolve(DocPaths.RESOURCE_FILES) >>> 113:

Re: RFR: 8351881: Tidy complains about missing "alt" attribute

2025-03-12 Thread Hannes Wallnöfer
On Wed, 12 Mar 2025 18:08:24 GMT, Nizar Benalla wrote: > Please review this change to add missing "alt" attributes to the left and > right pointing angles used in the sidebar hide/show buttons and prevent > `jdkCheckHtml.java` from failing. > > TIA. Looks good, thanks for fixing. ---

Re: RFR: 8351881: Tidy complains about missing "alt" attribute

2025-03-12 Thread Jonathan Gibbons
On Wed, 12 Mar 2025 18:08:24 GMT, Nizar Benalla wrote: > Please review this change to add missing "alt" attributes to the left and > right pointing angles used in the sidebar hide/show buttons and prevent > `jdkCheckHtml.java` from failing. > > TIA. src/jdk.javadoc/share/classes/jdk/javadoc/i

Integrated: 8351881: Tidy complains about missing "alt" attribute

2025-03-12 Thread Nizar Benalla
On Wed, 12 Mar 2025 18:08:24 GMT, Nizar Benalla wrote: > Please review this change to add missing "alt" attributes to the left and > right pointing angles used in the sidebar hide/show buttons and prevent > `jdkCheckHtml.java` from failing. > > TIA. This pull request has now been integrated.

Re: RFR: 8350920: Allow inherited member summaries to be viewed inline [v2]

2025-03-12 Thread Hannes Wallnöfer
> Please review an enhancement to allow switching between the traditional > condensed footnote-style summary and the summary table format for inherited > members (types, fields, methods and properties) that are inherited from > included types. You can test the feature in [the doc bundle I > upl

Re: RFR: 8345555: Improve layout of search results [v7]

2025-03-12 Thread Hannes Wallnöfer
> Please review an enhancement to JavaDoc search to provide more context and a > nicer layout for search results. This adds a new "kind" field to the search > index to describes search items, such as "Static method", "Interface, or > "System property" etc. Additionally, the drop-down search box

RFR: 8351626: Update remaining icons to SVG format

2025-03-12 Thread Hannes Wallnöfer
Please review a change to update the remaining `.png` files used by JavaDoc with `.svg` files. In addition to the looking glass and "x" icons used in the search box this also adds left and right pointing angles used in breadcrumb navigation and sidebar hide/show buttons that previously used glyp

Re: RFR: 8351626: Update remaining icons to SVG format

2025-03-12 Thread Nizar Benalla
On Wed, 12 Mar 2025 13:22:07 GMT, Hannes Wallnöfer wrote: > Please review a change to update the remaining `.png` files used by JavaDoc > with `.svg` files. In addition to the looking glass and "x" icons used in the > search box this also adds left and right pointing angles used in breadcrumb

Re: RFR: 8351626: Update remaining icons to SVG format

2025-03-12 Thread Hannes Wallnöfer
On Wed, 12 Mar 2025 13:22:07 GMT, Hannes Wallnöfer wrote: > Please review a change to update the remaining `.png` files used by JavaDoc > with `.svg` files. In addition to the looking glass and "x" icons used in the > search box this also adds left and right pointing angles used in breadcrumb

Re: RFR: 8351626: Update remaining icons to SVG format

2025-03-12 Thread Nizar Benalla
On Wed, 12 Mar 2025 13:22:07 GMT, Hannes Wallnöfer wrote: > Please review a change to update the remaining `.png` files used by JavaDoc > with `.svg` files. In addition to the looking glass and "x" icons used in the > search box this also adds left and right pointing angles used in breadcrumb

RFR: 8351881: Tidy complains about missing "alt" attribute

2025-03-12 Thread Nizar Benalla
Please review this change to add missing "alt" attributes to the left and right pointing angles used in the sidebar hide/show buttons and prevent `jdkCheckHtml.java` from failing. TIA. - Commit messages: - add missing alt attribute Changes: https://git.openjdk.org/jdk/pull/24016/

Re: RFR: 8351881: Tidy complains about missing "alt" attribute

2025-03-12 Thread Nizar Benalla
On Wed, 12 Mar 2025 18:44:09 GMT, Jonathan Gibbons wrote: >> Please review this change to add missing "alt" attributes to the left and >> right pointing angles used in the sidebar hide/show buttons and prevent >> `jdkCheckHtml.java` from failing. >> >> TIA. > > src/jdk.javadoc/share/classes/jd