- Original Message -
> February CPU pushes completed as reviewed in last round of webrevs.
>
> I'd like to push 2 extra fixes now for issues addressed in
> yesterday's
> JDK releases.
>
> webrev : http://cr.openjdk.java.net/~coffeys/webrev.6open.mar5/
>
> Good to push ?
>
> regards,
> S
I'm only the proxy here but I created the webrev from the changesets
that I pushed. I don't see any difference.
t4 $diff LCMSTransform.java.webrev
jdk/src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
t4 $
regards,
Sean.
On 07/03/2013 10:59, Andrew Hughes wrote:
- Original Messag
- Original Message -
> I'm only the proxy here but I created the webrev from the changesets
> that I pushed. I don't see any difference.
>
> t4 $diff LCMSTransform.java.webrev
> jdk/src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
> t4 $
>
Indeed. I'm still seeing the same failu
- Original Message -
> - Original Message -
> > I'm only the proxy here but I created the webrev from the
> > changesets
> > that I pushed. I don't see any difference.
> >
> > t4 $diff LCMSTransform.java.webrev
> > jdk/src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
> > t4
Yes - you're right. That does look like an issue. Andrew Brygin ran pre
integration tests before pushing the changes internally and they were
successful. However - I've traced back over the sources and what was run
in his test build and what he pushed to internal repo differs. ( in 2
areas) -
- Original Message -
> Yes - you're right. That does look like an issue. Andrew Brygin ran
> pre
> integration tests before pushing the changes internally and they were
> successful. However - I've traced back over the sources and what was
> run
> in his test build and what he pushed to
Even better if you want to push the change ? I haven't heard from Andrew
B. yet.
I've logged 8009641 to track this. You could use that ID if you want.
8009641: OpenJDK 6 build broken via 8007675 fix
regards,
Sean.
On 07/03/2013 13:51, Andrew Hughes wrote:
- Original Message -
Yes
- Original Message -
> Hello,
>
> please review a fix for the build failure:
>
> http://cr.openjdk.java.net/~bae/8009641/webrev.00/
>
Looks good to me and better than what I had as the synchronized blocks were
still outside the try
(so the variables could end up being null).
Ok to
- Original Message -
> Hi Andrew,
>
> thanks for the review. I am pushing the change.
>
> Sorry for the mess.
>
It's ok. I'm still baffled that javac misses it. I was able to build with
OpenJDK6,
just not with IcedTea's bootstrapping setup, which uses ecj.
Thanks for the quick f
Changeset: c73944a23b44
Author:bae
Date: 2013-03-07 18:20 +0300
URL: http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/c73944a23b44
8009641: OpenJDK 6 build broken via 8007675 fix
Reviewed-by: andrew
! src/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java
Hi Andrew,
thanks for the review. I am pushing the change.
Sorry for the mess.
Thanks,
Andrew
On 3/7/2013 7:12 PM, Andrew Hughes wrote:
- Original Message -
Hello,
please review a fix for the build failure:
http://cr.openjdk.java.net/~bae/8009641/webrev.00/
Looks good to
Hello,
please review a fix for the build failure:
http://cr.openjdk.java.net/~bae/8009641/webrev.00/
Thanks,
Andrew
On 3/7/2013 5:55 PM, Seán Coffey wrote:
Even better if you want to push the change ? I haven't heard from
Andrew B. yet.
I've logged 8009641 to track this. You could use tha
Il giorno mer, 30/01/2013 alle 13.52 -0500, Andrew Hughes ha scritto:
> - Original Message -
> >
> > I nominate Andrew Haley as the new jdk6 Project Lead. According to
> > the bylaws on project leads [1] the
> > Group Leads of the sponsoring project gets to nominate and vote. The
> > only
Sorry, it was my mistake, I pushed changes without build failure correction.
May I push a fix for this into the same repo?
Thanks,
Andrew
On 3/7/2013 5:20 PM, Seán Coffey wrote:
Yes - you're right. That does look like an issue. Andrew Brygin ran
pre integration tests before pushing the changes
14 matches
Mail list logo
