[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-634855359 @mjsax Thanks a lot for the review and tests triggering! This is an automated message from the Apache Git Servi

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431354284 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -51,9 +52,21 @@ if (throwable

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431352788 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -261,6 +261,42 @@ public void shouldNo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r431349905 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the

[jira] [Commented] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117976#comment-17117976 ] Adam Bellemare commented on KAFKA-10049: Is this us? I think this is their seria

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-634846871 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch removed a comment on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch removed a comment on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-634846388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431345466 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -51,9 +52,21 @@ if (thro

[GitHub] [kafka] rhauch commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431328464 ## File path: connect/transforms/src/test/java/org/apache/kafka/connect/transforms/predicates/TopicNameMatchesTest.java ## @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-634846209 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-634846336 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-634846388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] vvcephei commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-27 Thread GitBox
vvcephei commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r431342011 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskAssignorIntegrationTest.java ## @@ -0,0 +1,138 @@ +/* + * Licensed to the Apa

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431341731 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -261,6 +261,42 @@ public void shouldNo

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-27 Thread GitBox
mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634840600 Thanks for the KIP and PR @pgwhalen! This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] mjsax merged pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-27 Thread GitBox
mjsax merged pull request #6824: URL: https://github.com/apache/kafka/pull/6824 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-27 Thread GitBox
ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r431326390 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -874,7 +874,7 @@ public static final String TIME = "__ti

[GitHub] [kafka] rhauch commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-27 Thread GitBox
rhauch commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-634836169 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-27 Thread GitBox
mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634834525 Java 8: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] Java 11 and 14 passed. Merging this. ---

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431329158 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -66,6 +79,9 @@ * Returns the selecte

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431327264 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -51,9 +52,21 @@ if (throwable

[GitHub] [kafka] ableegoldman commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-27 Thread GitBox
ableegoldman commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-634827871 > The java 8 build started running right after I mentioned that it's not running I hope you'll choose to use these new powers for good ---

[GitHub] [kafka] guozhangwang commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-27 Thread GitBox
guozhangwang commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-634827126 Thanks for your patience @avalsa ! Merged to trunk. This is an automated message from the Apache Git Service.

[jira] [Resolved] (KAFKA-9561) Update task input partitions when topic metadata changes

2020-05-27 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-9561. -- Resolution: Fixed > Update task input partitions when topic metadata changes >

[GitHub] [kafka] guozhangwang merged pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-27 Thread GitBox
guozhangwang merged pull request #8221: URL: https://github.com/apache/kafka/pull/8221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431323350 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3623,22 +3641,26 @@ public RemoveMembersFromConsumerGroupResu

[GitHub] [kafka] hachikuji commented on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-27 Thread GitBox
hachikuji commented on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634825301 Bummer. Guess I will revert the commit. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] guozhangwang commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-27 Thread GitBox
guozhangwang commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r431322682 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431322560 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -261,6 +261,42 @@ public void shouldNotAllo

[GitHub] [kafka] vvcephei commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-27 Thread GitBox
vvcephei commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-634823280 Unbelievable. The java 8 build started running right after I mentioned that it's not running. This is an automat

[GitHub] [kafka] mjsax opened a new pull request #8732: KAFKA-10017: disable flaky EosBetaUpgradeIntegrationTest to stabilize build

2020-05-27 Thread GitBox
mjsax opened a new pull request #8732: URL: https://github.com/apache/kafka/pull/8732 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing str

[GitHub] [kafka] vvcephei commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-27 Thread GitBox
vvcephei commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-634821709 The only failing tests were unrelated: org.apache.kafka.connect.integration.InternalTopicsIntegrationTest.testCreateInternalTopicsWithFewerReplicasThanBrokers org.a

[GitHub] [kafka] vvcephei commented on pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-27 Thread GitBox
vvcephei commented on pull request #8716: URL: https://github.com/apache/kafka/pull/8716#issuecomment-634820186 The only failures were: org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka.streams.integr

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431313236 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -379,6 +380,22 @@ private static MetadataResponse pr

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431313074 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupOptions.java ## @@ -37,7 +38,15 @@ public RemoveMember

[jira] [Commented] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117933#comment-17117933 ] Matthias J. Sax commented on KAFKA-10049: - Assigned the ticket to [~vvcephei] fo

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431312462 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3623,22 +3641,26 @@ public RemoveMembersFromConsumerGrou

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431308724 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/predicates/TopicNameMatches.java ## @@ -0,0 +1,75 @@ +/* + * Licensed

[jira] [Created] (KAFKA-10052) Flaky Test InternalTopicsIntegrationTest.testCreateInternalTopicsWithFewerReplicasThanBrokers

2020-05-27 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10052: --- Summary: Flaky Test InternalTopicsIntegrationTest.testCreateInternalTopicsWithFewerReplicasThanBrokers Key: KAFKA-10052 URL: https://issues.apache.org/jira/browse/KA

[jira] [Assigned] (KAFKA-10047) Unnecessary widening of (int to long) scope in FloatSerializer

2020-05-27 Thread Guru Tahasildar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guru Tahasildar reassigned KAFKA-10047: --- Assignee: Guru Tahasildar > Unnecessary widening of (int to long) scope in FloatSer

[jira] [Assigned] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-10049: --- Assignee: John Roesler > KTable-KTable Foreign Key join throwing Serialization Exce

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431305795 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -66,6 +79,9 @@ * Returns the se

[GitHub] [kafka] tombentley commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
tombentley commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431305276 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/predicates/HasHeaderKey.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431302352 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/RemoveMembersFromConsumerGroupResult.java ## @@ -51,9 +52,21 @@ if (thro

[GitHub] [kafka] ijuma commented on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-27 Thread GitBox
ijuma commented on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634803985 Looks like `productToString` only works with Scala 2.13. :( This is an automated message from the Apache Git Service

[GitHub] [kafka] ijuma commented on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-27 Thread GitBox
ijuma commented on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634803238 Argh: > 09:53:20 [Error] /home/jenkins/jenkins-slave/workspace/kafka-pr-jdk8-scala2.12/core/src/main/scala/kafka/utils/CoreUtils.scala:326: value productElementName is not a

[GitHub] [kafka] ijuma commented on a change in pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-27 Thread GitBox
ijuma commented on a change in pull request #8709: URL: https://github.com/apache/kafka/pull/8709#discussion_r431300357 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -109,9 +109,19 @@ case class LogReadResult(info: FetchDataInfo, def withEmptyFetc

[jira] [Commented] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117922#comment-17117922 ] John Roesler commented on KAFKA-10049: -- I've marked this as a 2.6 blocker. It's not

[jira] [Updated] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10049: - Priority: Blocker (was: Major) > KTable-KTable Foreign Key join throwing Serialization Exceptio

[jira] [Updated] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10049: - Affects Version/s: 2.6.0 > KTable-KTable Foreign Key join throwing Serialization Exception > --

[GitHub] [kafka] rhauch commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r431281159 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -0,0 +1,297 @@ +/* + * Licensed to

[jira] [Updated] (KAFKA-10049) KTable-KTable Foreign Key join throwing Serialization Exception

2020-05-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10049: Priority: Major (was: Blocker) > KTable-KTable Foreign Key join throwing Serialization Ex

[GitHub] [kafka] hachikuji commented on a change in pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-27 Thread GitBox
hachikuji commented on a change in pull request #8709: URL: https://github.com/apache/kafka/pull/8709#discussion_r431288110 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -109,9 +109,19 @@ case class LogReadResult(info: FetchDataInfo, def withEmpty

[jira] [Assigned] (KAFKA-9878) Block AddPartitionsToTxn call until the txn markers are committed

2020-05-27 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-9878: -- Assignee: HaiyuanZhao > Block AddPartitionsToTxn call until the txn markers are committed > --

[jira] [Comment Edited] (KAFKA-4793) Kafka Connect: POST /connectors/(string: name)/restart doesn't start failed tasks

2020-05-27 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117896#comment-17117896 ] Jun Wang edited comment on KAFKA-4793 at 5/27/20, 4:23 PM: --- {{L

[jira] [Comment Edited] (KAFKA-4793) Kafka Connect: POST /connectors/(string: name)/restart doesn't start failed tasks

2020-05-27 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117896#comment-17117896 ] Jun Wang edited comment on KAFKA-4793 at 5/27/20, 4:23 PM: --- {{L

[jira] [Commented] (KAFKA-4793) Kafka Connect: POST /connectors/(string: name)/restart doesn't start failed tasks

2020-05-27 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117896#comment-17117896 ] Jun Wang commented on KAFKA-4793: - {{Look at the pause endpoint, it pause it's tasks.}}

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431266629 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3623,22 +3641,26 @@ public RemoveMembersFromConsumerGrou

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-27 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r431267044 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java ## @@ -65,4 +66,12 @@ default void validateReconfiguration(Map

[jira] [Resolved] (KAFKA-9353) Add groupInstanceId to DescribeGroup for better visibility

2020-05-27 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-9353. Fix Version/s: 2.6.0 Resolution: Fixed > Add groupInstanceId to DescribeGroup for be

[GitHub] [kafka] rajinisivaram commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
rajinisivaram commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-634769086 @ijuma Based on our discussion, I have added `Selector#clearCompletedSends()` and `Selector#clearCompletedReceives()` for SocketServer to clear buffers after they are proces

[GitHub] [kafka] hachikuji merged pull request #7886: KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility

2020-05-27 Thread GitBox
hachikuji merged pull request #7886: URL: https://github.com/apache/kafka/pull/7886 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rhauch commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
rhauch commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-634766420 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r431212650 ## File path: connect/api/src/main/java/org/apache/kafka/connect/sink/ErrantRecordReporter.java ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] feyman2016 commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-27 Thread GitBox
feyman2016 commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r431247169 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractResetIntegrationTest.java ## @@ -261,6 +261,42 @@ public void shouldNo

[GitHub] [kafka] mumrah commented on pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

2020-05-27 Thread GitBox
mumrah commented on pull request #8376: URL: https://github.com/apache/kafka/pull/8376#issuecomment-634738632 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-27 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r431210497 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -65,13 +65,24 @@ import scala.compat.java8.OptionConverters._ /* * Result meta

[GitHub] [kafka] rhauch commented on pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-27 Thread GitBox
rhauch commented on pull request #8720: URL: https://github.com/apache/kafka/pull/8720#issuecomment-634721500 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-27 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r431209368 ## File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala ## @@ -33,11 +34,40 @@ import scala.math.{max, min} */ private[group] class

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-27 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r431208549 ## File path: core/src/main/scala/kafka/coordinator/group/DelayedJoin.scala ## @@ -33,11 +34,40 @@ import scala.math.{max, min} */ private[group] class

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-27 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r431206147 ## File path: core/src/test/scala/unit/kafka/coordinator/group/DelayedJoinTest.scala ## @@ -0,0 +1,73 @@ +/** + * Licensed to the Apache Software Foundati

[GitHub] [kafka] rhauch commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-27 Thread GitBox
rhauch commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r431194915 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsReporter.java ## @@ -65,4 +66,12 @@ default void validateReconfiguration(Map conf

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117819#comment-17117819 ] John Roesler commented on KAFKA-10017: -- I've just marked this as a blocker for 2.6.

[jira] [Updated] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10017: - Priority: Blocker (was: Major) > Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosA

[GitHub] [kafka] tombentley commented on pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

2020-05-27 Thread GitBox
tombentley commented on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-634705442 @mimaison I've fixed those, if you want to make a 2nd pass. I guess I should add a test to `KafkaAdminClientTest` too.

[jira] [Updated] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

2020-05-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10017: - Affects Version/s: 2.6.0 > Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToE

[GitHub] [kafka] vvcephei commented on pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-27 Thread GitBox
vvcephei commented on pull request #8716: URL: https://github.com/apache/kafka/pull/8716#issuecomment-634702382 The test failures were the result of extra tests that were added on trunk after this branch. The branch builder does a merge with trunk before running the tests. I'm rebasing and

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-27 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-634699859 Java 14 passed, Java 11 failed with ```Execution failed for task ':connect:mirror:integrationTest'. 21:42:58 > Process 'Gradle Test Executor 48' finished with non-zero ex

[GitHub] [kafka] ijuma commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
ijuma commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-634696784 One more thing, can we improve `KafkaChannel.hashCode/equals` to avoid unnecessary work? The calls to `Objects.equals` and `Objects.hash` seem pointless. -

[GitHub] [kafka] vvcephei commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-27 Thread GitBox
vvcephei commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634696168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] rhauch commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-27 Thread GitBox
rhauch commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-634695460 @xiaodongdu please address the conflicts. This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] ijuma commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
ijuma commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-634696095 This change is probably OK, but the way we call `close` while iterating over `completedReceives` seems a bit fragile. It would probably be safer to collect the items we need to clos

[GitHub] [kafka] vvcephei commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-27 Thread GitBox
vvcephei commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-634694919 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-27 Thread GitBox
ijuma commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-634692630 @rajinisivaram We also retain a reference to the `NetworkReceive`, which is probably a bigger deal, right? This is

[jira] [Commented] (KAFKA-10007) Kafka consumer offset reset despite recent group activity

2020-05-27 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117792#comment-17117792 ] Ismael Juma commented on KAFKA-10007: - Do you see segment rolling happening in the b

[GitHub] [kafka] wj1918 commented on pull request #2880: New transform: ExtractFields

2020-05-27 Thread GitBox
wj1918 commented on pull request #2880: URL: https://github.com/apache/kafka/pull/2880#issuecomment-634666303 @dbtucker @ewencp Do we still need this PR? This is an automated message from the Apache Git Service. To respond to

[jira] [Commented] (KAFKA-10007) Kafka consumer offset reset despite recent group activity

2020-05-27 Thread Raman Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117760#comment-17117760 ] Raman Gupta commented on KAFKA-10007: - It certainly could be. I'm not certain KAFKA-

[GitHub] [kafka] nizhikov edited a comment on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

2020-05-27 Thread GitBox
nizhikov edited a comment on pull request #8731: URL: https://github.com/apache/kafka/pull/8731#issuecomment-634652827 I added call of `fix_opts_for_new_jvm` [here](https://github.com/apache/kafka/commit/befd80b38d3ccb1aa0c6d99a899129fd5cf27774#diff-ad7ee04aff5cb79b1478d038d59d4bbeR48).

[GitHub] [kafka] nizhikov commented on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

2020-05-27 Thread GitBox
nizhikov commented on pull request #8731: URL: https://github.com/apache/kafka/pull/8731#issuecomment-634652827 I added call of `fix_opts_for_new_jvm` [here](https://github.com/apache/kafka/commit/befd80b38d3ccb1aa0c6d99a899129fd5cf27774#diff-ad7ee04aff5cb79b1478d038d59d4bbeR48). But

[jira] [Commented] (KAFKA-7500) MirrorMaker 2.0 (KIP-382)

2020-05-27 Thread Ella Kurginyan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117750#comment-17117750 ] Ella Kurginyan commented on KAFKA-7500: --- Hi [~ryannedolan]. Now I can't find class 

[GitHub] [kafka] ijuma commented on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

2020-05-27 Thread GitBox
ijuma commented on pull request #8731: URL: https://github.com/apache/kafka/pull/8731#issuecomment-634644538 Thanks for the PR. Can you elaborate how the original change broke it? I don't see anything obviously related. This

[GitHub] [kafka] ijuma commented on pull request #8726: MINOR: Remove unused `Json.legacyEncodeAsString`

2020-05-27 Thread GitBox
ijuma commented on pull request #8726: URL: https://github.com/apache/kafka/pull/8726#issuecomment-634638112 Unrelated test failures. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ijuma merged pull request #8726: MINOR: Remove unused `Json.legacyEncodeAsString`

2020-05-27 Thread GitBox
ijuma merged pull request #8726: URL: https://github.com/apache/kafka/pull/8726 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-27 Thread GitBox
ijuma commented on pull request #8728: URL: https://github.com/apache/kafka/pull/8728#issuecomment-634623654 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] nizhikov commented on pull request #8731: KAFKA-10050: kafka_log4j_appender.py fixed for JDK11

2020-05-27 Thread GitBox
nizhikov commented on pull request #8731: URL: https://github.com/apache/kafka/pull/8731#issuecomment-634599948 Hello, @ijuma I found that `kafka_log4j_appender.py` broken for JDK11. This was broken by my patch - befd80b38d3ccb1aa0c6d99a899129fd5cf27774 I've prepared onelin

[jira] [Commented] (KAFKA-10050) kafka_log4j_appender.py broken on JDK11

2020-05-27 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117673#comment-17117673 ] Nikolay Izhikov commented on KAFKA-10050: - Results with the patch: {noformat} ni

[jira] [Commented] (KAFKA-10051) kafka_2.11 2.5.0 isn't available on Maven Central

2020-05-27 Thread Stefan Zwanenburg (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17117661#comment-17117661 ] Stefan Zwanenburg commented on KAFKA-10051: --- Ah. The release notes mentioned a

[jira] [Resolved] (KAFKA-10051) kafka_2.11 2.5.0 isn't available on Maven Central

2020-05-27 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-10051. - Resolution: Won't Fix Kafka 2.5.0 dropped support for Scala 2.11. > kafka_2.11 2.5.0 isn't avai

[GitHub] [kafka] tombentley commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-27 Thread GitBox
tombentley commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-634585597 Rebased for conflict. @kkonstantine I've addressed those first comments, thanks! Still some work on the integration test (not passing when run via gradle).

[jira] [Assigned] (KAFKA-10036) Improve error message if user violates `Supplier` pattern

2020-05-27 Thread Alex Sun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Sun reassigned KAFKA-10036: Assignee: Alex Sun > Improve error message if user violates `Supplier` pattern >

<    1   2   3   4   >