[jira] [Updated] (KAFKA-15238) Connect workers can be disabled by DLQ-related blocking admin client calls

2023-07-23 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-15238: --- Summary: Connect workers can be disabled by DLQ-related blocking admin client calls (was: Connect w

[jira] [Created] (KAFKA-15238) Connect workers can be disabled by DLQ related stuck admin client calls

2023-07-23 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-15238: -- Summary: Connect workers can be disabled by DLQ related stuck admin client calls Key: KAFKA-15238 URL: https://issues.apache.org/jira/browse/KAFKA-15238 Project: Kafka

[jira] [Created] (KAFKA-15237) Implement `offsets.commit.timeout.ms` setting

2023-07-23 Thread David Jacot (Jira)
David Jacot created KAFKA-15237: --- Summary: Implement `offsets.commit.timeout.ms` setting Key: KAFKA-15237 URL: https://issues.apache.org/jira/browse/KAFKA-15237 Project: Kafka Issue Type: Sub-t

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-23 Thread via GitHub
fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271787804 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contri

[jira] [Commented] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2023-07-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746199#comment-17746199 ] Luke Chen commented on KAFKA-12283: --- Thanks [~sagarrao] ! > Flaky Test > RebalanceSo

[jira] [Commented] (KAFKA-10457) JsonConverter.toConnectData trims BigInteger to Long for schema-less case

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746198#comment-17746198 ] Sagar Rao commented on KAFKA-10457: --- [~yash.mayya], IIRC, you had worked on an issue r

[jira] [Comment Edited] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746197#comment-17746197 ] Sagar Rao edited comment on KAFKA-12283 at 7/24/23 5:02 AM:

[jira] [Resolved] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-12283. --- Resolution: Fixed > Flaky Test > RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoin

[jira] [Commented] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746197#comment-17746197 ] Sagar Rao commented on KAFKA-12283: --- The flakiness with this test was also fixed as pa

[jira] [Resolved] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao resolved KAFKA-8391. -- Resolution: Fixed Fixed with https://github.com/apache/kafka/pull/12561 > Flaky Test RebalanceSourceCo

[jira] [Comment Edited] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746195#comment-17746195 ] Sagar Rao edited comment on KAFKA-8391 at 7/24/23 5:00 AM: --- Jus

[jira] [Commented] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746195#comment-17746195 ] Sagar Rao commented on KAFKA-8391: -- Just bumped upon this. The issue mentioned above (h

[jira] [Assigned] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2023-07-23 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-8391: Assignee: Sagar Rao > Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector > --

[GitHub] [kafka] vamossagar12 commented on a diff in pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-23 Thread via GitHub
vamossagar12 commented on code in PR #14051: URL: https://github.com/apache/kafka/pull/14051#discussion_r1271739558 ## core/src/test/scala/unit/kafka/cluster/PartitionTest.scala: ## @@ -1290,6 +1290,56 @@ class PartitionTest extends AbstractPartitionTest { ) } + @Test

[GitHub] [kafka] github-actions[bot] commented on pull request #13571: KAFKA-14907:Add the traffic metric of the partition dimension in BrokerTopicStats

2023-07-23 Thread via GitHub
github-actions[bot] commented on PR #13571: URL: https://github.com/apache/kafka/pull/13571#issuecomment-1647146954 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

[GitHub] [kafka] zhpyc closed pull request #13105: MINOR: fix typo in KafkaConsumer.java

2023-07-23 Thread via GitHub
zhpyc closed pull request #13105: MINOR: fix typo in KafkaConsumer.java URL: https://github.com/apache/kafka/pull/13105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

[GitHub] [kafka] showuon commented on a diff in pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-23 Thread via GitHub
showuon commented on code in PR #14051: URL: https://github.com/apache/kafka/pull/14051#discussion_r1271666143 ## core/src/test/scala/unit/kafka/cluster/PartitionTest.scala: ## @@ -1290,6 +1290,56 @@ class PartitionTest extends AbstractPartitionTest { ) } + @Test + d

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13998: KAFKA-14702: Extend server side assignor to support rack aware replica placement

2023-07-23 Thread via GitHub
rreddy-22 commented on code in PR #13998: URL: https://github.com/apache/kafka/pull/13998#discussion_r1271665613 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AssignmentTopicDescriber.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Softw

[jira] [Resolved] (KAFKA-14712) Confusing error when writing downgraded FeatureImage

2023-07-23 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-14712. --- Resolution: Fixed > Confusing error when writing downgraded FeatureImage > -

[GitHub] [kafka] showuon merged pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-07-23 Thread via GitHub
showuon merged PR #13773: URL: https://github.com/apache/kafka/pull/13773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] showuon commented on pull request #13773: KAFKA-14712: Produce correct error msg with correct metadataversion

2023-07-23 Thread via GitHub
showuon commented on PR #13773: URL: https://github.com/apache/kafka/pull/13773#issuecomment-1647109827 Failed tests are unrelated: ``` Build / JDK 17 and Scala 2.13 / org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationExactlyOnceTest.testOffsetTranslationBehind

[GitHub] [kafka] olalamichelle opened a new pull request, #14078: Fix flaky test 'testSecondaryRefreshAfterElapsedDelay'

2023-07-23 Thread via GitHub
olalamichelle opened a new pull request, #14078: URL: https://github.com/apache/kafka/pull/14078 "The test RefreshingHttpsJwksTest#testSecondaryRefreshAfterElapsedDelay relies on the actual system clock, which makes it frequently fail. The fix adds a second constructor that allows for passi

[GitHub] [kafka] vamossagar12 commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-23 Thread via GitHub
vamossagar12 commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1647039846 @showuon as suggested, I added the unit test. Thanks for your help! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] ex172000 closed pull request #14076: MINOR: Use Awaitility for waiting in test

2023-07-23 Thread via GitHub
ex172000 closed pull request #14076: MINOR: Use Awaitility for waiting in test URL: https://github.com/apache/kafka/pull/14076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (KAFKA-15235) No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-23 Thread Eike Thaden (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746133#comment-17746133 ] Eike Thaden commented on KAFKA-15235: - [~bmscomp] thank you preparing this fix! The

[GitHub] [kafka] ex172000 commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-23 Thread via GitHub
ex172000 commented on code in PR #14075: URL: https://github.com/apache/kafka/pull/14075#discussion_r1271558534 ## build.gradle: ## @@ -808,10 +809,9 @@ if (userEnableTestCoverage) { executionData.from = javaProjects.jacocoTestReport.executionData reports { - ht

[GitHub] [kafka] lihaosky commented on a diff in pull request #14030: KAFKA-15022: [3/N] use graph to compute rack aware assignment for active stateful tasks

2023-07-23 Thread via GitHub
lihaosky commented on code in PR #14030: URL: https://github.com/apache/kafka/pull/14030#discussion_r1271539596 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/RackAwareTaskAssignor.java: ## @@ -185,4 +191,224 @@ public boolean validateClientRack

[jira] [Commented] (KAFKA-14112) Expose replication-offset-lag Mirror metric

2023-07-23 Thread Elkhan Eminov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746108#comment-17746108 ] Elkhan Eminov commented on KAFKA-14112: --- [~viktorsomogyi] I've created the PR, ple

[GitHub] [kafka] elkkhan opened a new pull request, #14077: KAFKA-14112: Expose replication-offset-lag Mirror metric

2023-07-23 Thread via GitHub
elkkhan opened a new pull request, #14077: URL: https://github.com/apache/kafka/pull/14077 The replication offset lag is the difference of the last end offset of the source partition (LEO) the last replicated source offset (LRO), +1 (to account for zero-based offset numbering) The offset l

[jira] [Updated] (KAFKA-14112) Expose replication-offset-lag Mirror metric

2023-07-23 Thread Elkhan Eminov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Eminov updated KAFKA-14112: -- Description: The replication offset lag is the difference of the {*}l{*}ast {*}e{*}nd  {*}o{*}

[jira] [Commented] (KAFKA-15215) The default.dsl.store config is not compatible with custom state stores

2023-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746106#comment-17746106 ] Guozhang Wang commented on KAFKA-15215: --- Just realized I have not read the KIP! :)

[jira] [Commented] (KAFKA-15215) The default.dsl.store config is not compatible with custom state stores

2023-07-23 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17746102#comment-17746102 ] Guozhang Wang commented on KAFKA-15215: --- [~ableegoldman] Thanks for bringing this

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-23 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-23 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-23 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] ruslankrivoshein commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

2023-07-23 Thread via GitHub
ruslankrivoshein commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271470073 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [kafka] ocadaruma commented on pull request #10167: KAFKA-12261: Mention about potential delivery loss on increasing partition when auto.offset.reset = latest

2023-07-23 Thread via GitHub
ocadaruma commented on PR #10167: URL: https://github.com/apache/kafka/pull/10167#issuecomment-1646844923 @hudeqi Yeah, that's right. The problem still exists. I'll share my thoughts in KIP-842 discussion thread. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [kafka] bmscomp commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-23 Thread via GitHub
bmscomp commented on code in PR #14075: URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437691 ## build.gradle: ## @@ -808,10 +809,9 @@ if (userEnableTestCoverage) { executionData.from = javaProjects.jacocoTestReport.executionData reports { - htm

[GitHub] [kafka] bmscomp commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-23 Thread via GitHub
bmscomp commented on code in PR #14075: URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437161 ## build.gradle: ## @@ -808,10 +809,9 @@ if (userEnableTestCoverage) { executionData.from = javaProjects.jacocoTestReport.executionData reports { - htm

[GitHub] [kafka] bmscomp commented on a diff in pull request #14075: KAFKA-15235: No test coverage reports for Java due to settings for Jacoco being incompatible with Gradle 8.x

2023-07-23 Thread via GitHub
bmscomp commented on code in PR #14075: URL: https://github.com/apache/kafka/pull/14075#discussion_r1271437161 ## build.gradle: ## @@ -808,10 +809,9 @@ if (userEnableTestCoverage) { executionData.from = javaProjects.jacocoTestReport.executionData reports { - htm

[GitHub] [kafka] maniekes commented on pull request #13321: MINOR: added compatibility for MinGW

2023-07-23 Thread via GitHub
maniekes commented on PR #13321: URL: https://github.com/apache/kafka/pull/13321#issuecomment-1646799859 hi @divijvaidya what do u think about my last changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] vamossagar12 commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-23 Thread via GitHub
vamossagar12 commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1646786096 Thanks @showuon . oh I didn’t realise I could use spy in scala tests as well. Sorry I missed that and thanks for your help. -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] showuon commented on pull request #14051: KAFKA-15218: Avoid NPE thrown while deleting topic and fetch from follower concurrently

2023-07-23 Thread via GitHub
showuon commented on PR #14051: URL: https://github.com/apache/kafka/pull/14051#issuecomment-1646779495 @vamossagar12 , sorry for late response. For your suggestion: > Remove the canAddReplicaToIsr call from [here](https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/