cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r657530674
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1164,7 +1164,7 @@ class KafkaApis(val requestChannel: RequestChannel,
var unaut
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r657530812
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2886,7 +2885,7 @@ class KafkaApis(val requestChannel: RequestChannel,
sendRes
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r657531588
##
File path: core/src/main/scala/kafka/server/MetadataCache.scala
##
@@ -62,17 +46,22 @@ trait MetadataCache {
def getAllTopics(): collection.Set[St
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r657531976
##
File path: core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala
##
@@ -1352,8 +1370,7 @@ class ReplicaManagerTest {
Optional.of(1))
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r660911200
##
File path: core/src/main/scala/kafka/server/MetadataCache.scala
##
@@ -62,17 +46,22 @@ trait MetadataCache {
def getAllTopics(): collection.Set[St
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r660911200
##
File path: core/src/main/scala/kafka/server/MetadataCache.scala
##
@@ -62,17 +46,22 @@ trait MetadataCache {
def getAllTopics(): collection.Set[St
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r660925631
##
File path: core/src/main/scala/kafka/server/MetadataCache.scala
##
@@ -62,17 +46,22 @@ trait MetadataCache {
def getAllTopics(): collection.Set[St
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r660928423
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1721,8 +1720,10 @@ class ReplicaManager(val config: KafkaConfig,
} else
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r660928423
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1721,8 +1720,10 @@ class ReplicaManager(val config: KafkaConfig,
} else
cmccabe commented on a change in pull request #10887:
URL: https://github.com/apache/kafka/pull/10887#discussion_r660935556
##
File path: core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala
##
@@ -0,0 +1,406 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
10 matches
Mail list logo