Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

2024-03-28 Thread via GitHub
lucasbru merged PR #15612: URL: https://github.com/apache/kafka/pull/15612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

2024-03-27 Thread via GitHub
lianetm commented on code in PR #15612: URL: https://github.com/apache/kafka/pull/15612#discussion_r1541452355 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala: ## @@ -0,0 +1,320 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-16406 [2] : Split consumer commit tests [kafka]

2024-03-27 Thread via GitHub
lianetm commented on PR #15612: URL: https://github.com/apache/kafka/pull/15612#issuecomment-2023088189 @lucasbru this is one more last split that I find would make sense. With this, all the tests left in the `PlainTextConsumer` do not seem to belong to any sensible group other than the gen