mimaison merged PR #15877:
URL: https://github.com/apache/kafka/pull/15877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
mimaison commented on PR #15877:
URL: https://github.com/apache/kafka/pull/15877#issuecomment-2109561702
Thanks for the reviews! Test failures are not related, merging to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598589821
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2288,23 +2253,15 @@ public void testRebalanceException(GroupProtocol
groupPr
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598491917
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -2288,23 +2253,15 @@ public void testRebalanceException(GroupProtocol
groupPro
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598214121
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3232,7 +3231,7 @@ public void
testProducerBatchRetriesWhenPartitionLeader
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598196898
##
clients/src/test/java/org/apache/kafka/test/Microbenchmarks.java:
##
@@ -78,34 +78,30 @@ public static void main(String[] args) throws Exception {
final Ti
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598194726
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1323,7 +1323,7 @@ public void
testConcurrentUpdateAndFetchForSnapshotAndCluster() throws I
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598184479
##
clients/src/test/java/org/apache/kafka/common/utils/ImplicitLinkedHashMultiCollectionTest.java:
##
@@ -114,11 +114,11 @@ public void testEnlargement() {
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598183774
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -1840,28 +1840,28 @@ public void
testOperationsBySubscribingConsumerWithDefau
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598182787
##
clients/src/test/java/org/apache/kafka/common/header/internals/RecordHeadersTest.java:
##
@@ -220,9 +220,7 @@ public void
shouldThrowNpeWhenAddingCollectionWithNul
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598182133
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1335,7 +1335,7 @@ public void
testConcurrentUpdateAndFetchForSnapshotAndCluster() throws I
mimaison commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1598165504
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -106,10 +103,9 @@ public void setup() {
commitReque
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594231539
##
clients/src/test/java/org/apache/kafka/common/utils/ImplicitLinkedHashMultiCollectionTest.java:
##
@@ -114,11 +114,11 @@ public void testEnlargement() {
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594213570
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3492,9 +3491,9 @@ private void verifyErrorMessage(ProduceResponse response,
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594199948
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3232,7 +3231,7 @@ public void
testProducerBatchRetriesWhenPartitionLeaderC
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594200503
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java:
##
@@ -3253,13 +3252,13 @@ public void
testProducerBatchRetriesWhenPartitionLeade
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1594156634
##
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##
@@ -1840,28 +1840,28 @@ public void
testOperationsBySubscribingConsumerWithDefaul
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1593116655
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -106,10 +103,9 @@ public void setup() {
commitReques
lianetm commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1593098515
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -106,10 +103,9 @@ public void setup() {
commitReques
chia7712 commented on code in PR #15877:
URL: https://github.com/apache/kafka/pull/15877#discussion_r1591714910
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1323,7 +1323,7 @@ public void
testConcurrentUpdateAndFetchForSnapshotAndCluster() throws I
mimaison opened a new pull request, #15877:
URL: https://github.com/apache/kafka/pull/15877
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgr
21 matches
Mail list logo
