Re: [PR] MINOR: Code cleanup Kafka Streams [kafka]

2024-09-25 Thread via GitHub
mjsax commented on code in PR #16050: URL: https://github.com/apache/kafka/pull/16050#discussion_r1776270654 ## streams/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyInnerJoinCustomPartitionerIntegrationTest.java: ## @@ -125,8 +125,8 @@ public static v

Re: [PR] MINOR: Code cleanup Kafka Streams [kafka]

2024-09-21 Thread via GitHub
sjhajharia commented on PR #16050: URL: https://github.com/apache/kafka/pull/16050#issuecomment-2365167257 Hey @mjsax Sorry, I was swamped a bit. Getting back to this, thanks for the review. I have updated the PR. Could you pls help review again. Thanks -- This is an automated

Re: [PR] MINOR: Code cleanup Kafka Streams [kafka]

2024-08-22 Thread via GitHub
mjsax commented on code in PR #16050: URL: https://github.com/apache/kafka/pull/16050#discussion_r1728144339 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/TaskAssignorConvergenceTest.java: ## @@ -623,11 +622,10 @@ private static void testForCon

Re: [PR] [MINOR] Code Cleanup [kafka]

2024-05-23 Thread via GitHub
sjhajharia commented on PR #16021: URL: https://github.com/apache/kafka/pull/16021#issuecomment-2128693543 Hey @chia7712 I have created 5 sub-PRs to address the cleanup module-by-module. - https://github.com/apache/kafka/pull/16049: Clients Module - https://github.com/apache/kafka/

Re: [PR] [MINOR] Code Cleanup [kafka]

2024-05-23 Thread via GitHub
sjhajharia commented on PR #16021: URL: https://github.com/apache/kafka/pull/16021#issuecomment-2127460772 Hey @chia7712 Thanks for the comment. I was also in a split brain regarding the same. I will close this one and create child PRs with one/two modules targetted at a time for an eas

Re: [PR] [MINOR] Code Cleanup [kafka]

2024-05-23 Thread via GitHub
sjhajharia closed pull request #16021: [MINOR] Code Cleanup URL: https://github.com/apache/kafka/pull/16021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] [MINOR] Code Cleanup [kafka]

2024-05-23 Thread via GitHub
chia7712 commented on PR #16021: URL: https://github.com/apache/kafka/pull/16021#issuecomment-2127214845 @sjhajharia Thanks for this great contribution. However, we normally do such refactor one module by one module. For example: #15967, #15955, and #15877 The huge PR is un-reviewable

[PR] [MINOR] Code Cleanup [kafka]

2024-05-21 Thread via GitHub
sjhajharia opened a new pull request, #16021: URL: https://github.com/apache/kafka/pull/16021 Performing some cleanup on code. Mainly it addresses cases of using Singleton lists where possible instead of an Array List and some minor changes to get rid of String Builders -- This is an a

Re: [PR] MINOR: code cleanup [kafka]

2024-01-17 Thread via GitHub
mjsax merged PR #15208: URL: https://github.com/apache/kafka/pull/15208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: code cleanup [kafka]

2024-01-16 Thread via GitHub
mjsax commented on PR #15208: URL: https://github.com/apache/kafka/pull/15208#issuecomment-1894793322 This PR must be cherry-picked to `3.7` and `3.6` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a