[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-08-27 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16917215#comment-16917215 ] ASF GitHub Bot commented on KAFKA-6460: --- shunge commented on pull request #7261: KA

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-20 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16773714#comment-16773714 ] Matthias J. Sax commented on KAFKA-6460: Personally, I would not use EasyMock for

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-15 Thread Yishun Guan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16769862#comment-16769862 ] Yishun Guan commented on KAFKA-6460: Sounds good to me [~mjsax] and [~guozhang], the

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767930#comment-16767930 ] Matthias J. Sax commented on KAFKA-6460: I did not think about how to make it wor

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767899#comment-16767899 ] Guozhang Wang commented on KAFKA-6460: -- Ah yes, that's a good point. Thinking abou

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767791#comment-16767791 ] Matthias J. Sax commented on KAFKA-6460: Internally, the DSL always uses the clas

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767766#comment-16767766 ] Guozhang Wang commented on KAFKA-6460: -- [~mjsax] I'm not sure I can follow-up here,

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767517#comment-16767517 ] Matthias J. Sax commented on KAFKA-6460: [~guozhang] I think it would also be imp

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-02-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767479#comment-16767479 ] Guozhang Wang commented on KAFKA-6460: -- Hi [~shung], sorry for the late replies. Her

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-01-31 Thread Yishun Guan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757803#comment-16757803 ] Yishun Guan commented on KAFKA-6460: Hi [~guozhang] , I still not quite understand -

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-01-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736406#comment-16736406 ] Guozhang Wang commented on KAFKA-6460: -- Great! Feel free to look at KIP-267 for the

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-01-07 Thread Yishun Guan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736402#comment-16736402 ] Yishun Guan commented on KAFKA-6460: Hi [~guozhang] , I am still interested if nobody

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2019-01-07 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736399#comment-16736399 ] Guozhang Wang commented on KAFKA-6460: -- It should be part of the public test-utils p

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2018-07-16 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545824#comment-16545824 ] Matthias J. Sax commented on KAFKA-6460: [~shung] Yes, this is not completely res

[jira] [Commented] (KAFKA-6460) Add mocks for state stores used in Streams unit testing

2018-06-28 Thread Shun Guan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16526697#comment-16526697 ] Shun Guan commented on KAFKA-6460: -- Is this still needs to be work on? Thanks. > Add mo