[GitHub] [kafka] mimaison commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-25 Thread via GitHub
mimaison commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1269270009 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorHeartbeatConnector.java: ## @@ -85,6 +89,26 @@ public String version() { return AppInfoP

[GitHub] [kafka] mimaison commented on a diff in pull request #14005: KAFKA-15177: Implement KIP-875 SourceConnector::alterOffset API in MirrorMaker 2 connectors

2023-07-20 Thread via GitHub
mimaison commented on code in PR #14005: URL: https://github.com/apache/kafka/pull/14005#discussion_r1269268948 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -65,27 +72,170 @@ static String encodeTopicPartition(TopicPartition topicParti