[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-28 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r431678155 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -352,17 +357,18 @@ def start_cmd(self, node): KafkaService.STDOUT_STDERR_CAPTU

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-28 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r431677154 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -52,6 +51,7 @@ def advertised_listener(self, node): def listener_security_protocol(self):

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-28 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r431675317 ## File path: tests/kafkatest/benchmarks/core/benchmark_test.py ## @@ -236,9 +238,9 @@ def test_producer_and_consumer(self, compression_type="none", secur

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-28 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r431674950 ## File path: tests/docker/run_tests.sh ## @@ -30,6 +30,6 @@ if [ "$REBUILD" == "t" ]; then fi if ${SCRIPT_DIR}/ducker-ak ssh | grep -q '(none)'; then

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-28 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r431668846 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -0,0 +1,130 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428173640 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersi

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428114569 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersi