cmccabe commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2133754024
@jolshan : Sorry, there was a typo in the original commit that led to a
variable getting shadowed. I think it happened during rebasing on trunk. This
should be fixed now.
--
This is an
jolshan commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2131316535
https://github.com/apache/kafka/pull/16082 to revert. If folks can find a
fix quickly that also works.
--
This is an automated message from the Apache Git Service.
To respond to the mes
jolshan commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2131315366
Are we sure the failures are not related? It seems there are consistent
ZKMigrationIntegrationTest failures on trunk since this change. Reverting the
change fixes the issue.
--
This i
cmccabe commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2130026904
failures not related. committed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cmccabe closed pull request #16006: KAFKA-16515: Fix the ZK Metadata cache
confusion between brokers and controllers
URL: https://github.com/apache/kafka/pull/16006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cmccabe commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2123537218
Tests should be fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
cmccabe commented on code in PR #16006:
URL: https://github.com/apache/kafka/pull/16006#discussion_r1608921813
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -350,11 +347,7 @@ class ZkMetadataCache(
override def getAliveBrokerNode(brokerId: Int, l
jsancio commented on code in PR #16006:
URL: https://github.com/apache/kafka/pull/16006#discussion_r1608902290
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -350,11 +347,7 @@ class ZkMetadataCache(
override def getAliveBrokerNode(brokerId: Int, l
