Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Jan Heylen
Any comments? Br , Jan On May 16, 2015 2:13 PM, "Jan Heylen" wrote: > correction: > > and a demo/code on this blur demo here: > > http://heyleke.pythonanywhere.com/kallithea-heyleke/changeset/28a2bd5250ba1bb26d9a09b51c95e1e07bab6ff3 > (login: test pass: testtest) > > Jan > > On Sat, May 16, 201

Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Mads Kiilerich
On 05/25/2015 10:06 AM, Jan Heylen wrote: Any comments? I don't understand the references to "blur". What problem do you think it would or wouldn't solve? For the general demo, I think the UI as it is would be a regression. The color emphasis of drafts do not seem efficient to me. I woul

Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Thomas De Schampheleire
On May 25, 2015 9:41:12 PM CEST, Mads Kiilerich wrote: >On 05/25/2015 10:06 AM, Jan Heylen wrote: >> >> Any comments? >> > >I don't understand the references to "blur". What problem do you think >it would or wouldn't solve? Blur is the opposite of focus: the event of leaving an input element. ht

Re: [PATCH] privacy: don't tell users what is the reason for a failed login

2015-05-25 Thread Mads Kiilerich
On 05/21/2015 09:41 AM, Andrew Shadura wrote: Hello, On Tue, 19 May 2015 17:15:30 +0200 Mads Kiilerich wrote: I think the current implementation is wrong when it does any kind of login verification in the user friendly form code. The authentication should be done explicitly in the controller.

Re: [PATCH v2] auth: let users log in using their email address

2015-05-25 Thread Mads Kiilerich
On 05/17/2015 01:04 PM, Andrew Shadura wrote: Hello, On Sun, 17 May 2015 03:12:20 +0200 Mads Kiilerich wrote: Correct me if I'm wrong, but if I read the code correctly, the check here will have no effect (which is why I haven't added it). Ok. The explanation explains it. The code do however

Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Mads Kiilerich
On 05/25/2015 09:57 PM, Thomas De Schampheleire wrote: On May 25, 2015 9:41:12 PM CEST, Mads Kiilerich wrote: On 05/25/2015 10:06 AM, Jan Heylen wrote: Any comments? I don't understand the references to "blur". What problem do you think it would or wouldn't solve? Blur is the opposite of fo

Re: [DEMO] automatic saving of draft comments

2015-05-25 Thread Jan Heylen
If we keep input boxes instead of showing the preview, it might work well, and the issue with the cancel button might disappear by itself, I'll have a proper look at you comments and update the patches and demo where applicable Jan On May 26, 2015 1:48 AM, "Mads Kiilerich" wrote: > On 05/25/2015