[PATCH v2] auth: let users log in using their email address

2015-05-16 Thread Andrew Shadura
# HG changeset patch # User Andrew Shadura # Date 1431709586 -7200 # Fri May 15 19:06:26 2015 +0200 # Node ID 93de511e84fe940786acf468789a77daed83a461 # Parent 95bffe63997d40bfab5ae6b8d1a54859d6275471 auth: let users log in using their email address diff --git a/kallithea/controllers/login.

Re: [PATCH v2] auth: let users log in using their email address

2015-05-16 Thread Mads Kiilerich
On 05/16/2015 03:49 PM, Andrew Shadura wrote: # HG changeset patch # User Andrew Shadura # Date 1431709586 -7200 # Fri May 15 19:06:26 2015 +0200 # Node ID 93de511e84fe940786acf468789a77daed83a461 # Parent 95bffe63997d40bfab5ae6b8d1a54859d6275471 auth: let users log in using their email ad

Re: [PATCH v2] auth: let users log in using their email address

2015-05-16 Thread Andrew Shadura
Hello, On Sun, 17 May 2015 01:50:56 +0200 Mads Kiilerich wrote: > > diff --git a/kallithea/controllers/login.py > > b/kallithea/controllers/login.py --- > > a/kallithea/controllers/login.py +++ > > b/kallithea/controllers/login.py @@ -121,9 +121,15 @@ class > > LoginController(BaseController): s

Re: [PATCH v2] auth: let users log in using their email address

2015-05-16 Thread Mads Kiilerich
On 05/17/2015 02:11 AM, Andrew Shadura wrote: Hello, On Sun, 17 May 2015 01:50:56 +0200 Mads Kiilerich wrote: diff --git a/kallithea/controllers/login.py b/kallithea/controllers/login.py --- a/kallithea/controllers/login.py +++ b/kallithea/controllers/login.py @@ -121,9 +121,15 @@ class Login

Re: [PATCH v2] auth: let users log in using their email address

2015-05-17 Thread Andrew Shadura
Hello, On Sun, 17 May 2015 03:12:20 +0200 Mads Kiilerich wrote: > > Correct me if I'm wrong, but if I read the code correctly, the check > > here will have no effect (which is why I haven't added it). > Ok. The explanation explains it. The code do however seem fragile and > non-obvious when re

Re: [PATCH v2] auth: let users log in using their email address

2015-05-25 Thread Mads Kiilerich
On 05/17/2015 01:04 PM, Andrew Shadura wrote: Hello, On Sun, 17 May 2015 03:12:20 +0200 Mads Kiilerich wrote: Correct me if I'm wrong, but if I read the code correctly, the check here will have no effect (which is why I haven't added it). Ok. The explanation explains it. The code do however