[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-28 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added Version Fixed In||5.1.2 -- You are receiving this mail because: You

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-28 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 Sven Brauch changed: What|Removed |Added Latest Commit|54c2740ae97f4e3ee7675ff06ec |https://commits.kde.org/kde |5a

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-26 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #32 from Axel Kellermann --- (In reply to Sven Brauch from comment #31) > Ah yes, if you trick the mimetype detection, you will still crash. You are > also right about strncpy. > > phabricator should be simple enough to use, just log in (wi

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #31 from Sven Brauch --- Ah yes, if you trick the mimetype detection, you will still crash. You are also right about strncpy. phabricator should be simple enough to use, just log in (with identity.kde.org), click differential, then click ne

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #30 from Axel Kellermann --- (In reply to Sven Brauch from comment #28) > Patch still looks sensible to me -- maybe use strncpy instead, and put it on > phabricator.kde.org so somebody familiar with the code can have a look? strncpy()/strnd

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #29 from Axel Kellermann --- (In reply to Sven Brauch from comment #27) > Does that still happen with KDevelop 5.1+? I thought I fixed it. See comment #22. Random .txt files aren't scanned anymore, but .cmake files can still trigger the fau

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #28 from Sven Brauch --- Patch still looks sensible to me -- maybe use strncpy instead, and put it on phabricator.kde.org so somebody familiar with the code can have a look? -- You are receiving this mail because: You are watching all bug

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Sven Brauch
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #27 from Sven Brauch --- Does that still happen with KDevelop 5.1+? I thought I fixed it. -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #26 from Axel Kellermann --- I had another look at the lexer and I think I pinned down the problem with UTF-16 files in cmListFileLexer.c. Scanning the files works fine, but copying the scanned content into the token structure in cmListFileL

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #25 from Axel Kellermann --- Created attachment 106866 --> https://bugs.kde.org/attachment.cgi?id=106866&action=edit Proposal for patch -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2017-07-25 Thread Axel Kellermann
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #24 from Axel Kellermann --- Created attachment 106865 --> https://bugs.kde.org/attachment.cgi?id=106865&action=edit Minimal UTF-16 file to trigger behavior -- You are receiving this mail because: You are watching all bug changes.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2016-11-17 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added CC||asiasuppenes...@gmx.de --- Comment #23 from Kevin

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken, CMakeListsParser::readCMakeFile]

2016-11-17 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added Summary|Crash when projects |Crash when projects |contains *.

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-10-13 Thread Sven Brauch via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #22 from Sven Brauch --- Note that while above commit should fix the crash in this case, this bug is still open, since it would be back if you would rename the file to "CMakeLists.txt" ... I think. -- You are receiving this mail because: Y

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-10-13 Thread Sven Brauch via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #21 from Sven Brauch --- Git commit 77b83054f943b6c9bce0da178732f7992f7ada3b by Sven Brauch. Committed on 13/10/2016 at 18:52. Pushed by brauch into branch '5.0'. Remove mime type <-> extension cache The idea that because one file with ext

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-10-01 Thread Sven Brauch via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 Sven Brauch changed: What|Removed |Added CC||m...@svenbrauch.de --- Comment #20 from Sven Brau

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-10-01 Thread Axel Kellermann via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #19 from Axel Kellermann --- I had some time to kill today, so I took another look at why random .txt files get processed by the background parser. If I understand the code flow correctly, it happens like this: - on startup the project folde

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-09-09 Thread Night Nord via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 Night Nord changed: What|Removed |Added CC||nightn...@gmail.com --- Comment #18 from Night Nor

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-09-08 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 --- Comment #17 from Kevin Funk --- Some comments from the dup: """ I found the problem, and it's actually similar, but not the same as bug 363269. The code base being parsed contains a subfolder with example text in a couple of different asian languag

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-09-08 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added CC||axel.kellerm...@gmx.de --- Comment #16 from Kevin

[kdevelop] [Bug 363269] Crash when projects contains *.txt file that is actually a binary file [cmListFileLexerSetToken]

2016-09-08 Thread Kevin Funk via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363269 Kevin Funk changed: What|Removed |Added Summary|Crash when projects |Crash when projects |contains *.