Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review47020 --- Ship it! If you have the possibility (build setup) please mer

Re: Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact

2014-01-07 Thread Andrea Iacovitti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114907/#review47019 --- kdeui/fonts/kfontutils.cpp

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Kevin Ottens
On Tuesday 07 January 2014 23:30:28 John Layt wrote: > On 7 January 2014 19:49, Kevin Ottens wrote: > >> Most of the > >> dialog code from there has been merged into Qt5.2, or is planned for > >> Qt 5.3, so needs deleting. I'm also wondering if we still need our > >> own KPrintPreview dialog, the

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Alex Merry
On 07/01/14 22:30, John Layt wrote: > Running through the print dialog features, I'm don't think there is > anything left to be upstreamed. There's a couple of very minor CUPS > features in the dialog that I don't think anyone uses (mirror page, > page border, page label) that I don't really want

Review Request 114907: Make KFontUtils::adaptFontSize be a bit more exact

2014-01-07 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114907/ --- Review request for kdelibs and Jeremy Whiting. Repository: kdelibs Desc

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread John Layt
On 7 January 2014 19:49, Kevin Ottens wrote: >> Most of the >> dialog code from there has been merged into Qt5.2, or is planned for >> Qt 5.3, so needs deleting. I'm also wondering if we still need our >> own KPrintPreview dialog, there was a reason in 4.0 but I can't >> remember why now and I'm

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Albert Astals Cid
El Dimarts, 7 de gener de 2014, a les 23:10:11, John Layt va escriure: > On 7 January 2014 19:55, Albert Astals Cid wrote: > > El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure: > >> On 07/01/14 17:10, John Layt wrote: > >> > I've put myself down (rather obviously) for KPrintU

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread John Layt
On 7 January 2014 19:55, Albert Astals Cid wrote: > El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure: >> On 07/01/14 17:10, John Layt wrote: >> > I've put myself down (rather obviously) for KPrintUtils. Most of the >> > dialog code from there has been merged into Qt5.2, or i

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Wolfgang Bauer
> On Jan. 7, 2014, 9:51 a.m., Martin Gräßlin wrote: > > how does that behave with the normal locker (that is no screensaver)? > > Thomas Lübking wrote: > "None" is not "blank" - the patch is correct. > > If a cursor is specified, it is displayed regardless of what window the > poin

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Albert Astals Cid
El Dimarts, 7 de gener de 2014, a les 18:24:41, Alex Merry va escriure: > On 07/01/14 17:10, John Layt wrote: > > I've put myself down (rather obviously) for KPrintUtils. Most of the > > dialog code from there has been merged into Qt5.2, or is planned for > > Qt 5.3, so needs deleting. I'm also w

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Kevin Ottens
Hello, On Tuesday 07 January 2014 18:10:10 John Layt wrote: > On 6 January 2014 07:52, Kevin Ottens wrote: > > I urge everyone, and in particular people volunteering to maintain a > > framework, to do a pass of review of our code base and APIs to modernize > > them when appropriate. It is a very

Re: KF5 Update Meeting Minutes 2014-w2

2014-01-07 Thread Albert Astals Cid
El Dimarts, 7 de gener de 2014, a les 17:28:29, Kevin Ottens va escriure: > Hello, > > As a reminder the maintainers list is available there: > http://community.kde.org/Frameworks/List Can I suggest changing "Unmaintained" to "looking for a maintainer"? It looks pretty bad that we released a the

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Alex Merry
On 07/01/14 17:10, John Layt wrote: > I've put myself down (rather obviously) for KPrintUtils. Most of the > dialog code from there has been merged into Qt5.2, or is planned for > Qt 5.3, so needs deleting. I'm also wondering if we still need our > own KPrintPreview dialog, there was a reason in

Re: KF5 Update Meeting Minutes 2014-w2

2014-01-07 Thread Alex Merry
On 07/01/14 16:28, Kevin Ottens wrote: >> * alexmerry [...] plans to adopt kimageformats and kmediaplayer; > > Alex: Both KImageFormats and KMediaPlayer are your if you adjust the wiki > page > accordingly. I've also taken KDesignerPlugin; as far as I'm aware, I'm the only person to have done

Re: KF5 Update Meeting Minutes 2014-w2

2014-01-07 Thread Siddharth Sharma
Hello, I am also looking to maintain a project, if there is something where i can help. I would try to join the meeting. Regards, Siddharth Sharma On Tue, Jan 7, 2014 at 9:23 PM, Kevin Ottens wrote: > Hello everyone, > > This is the minutes of the Week 48 KF5 meeting. As usual it has been

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread John Layt
On 6 January 2014 07:52, Kevin Ottens wrote: > I urge everyone, and in particular people volunteering to maintain a > framework, to do a pass of review of our code base and APIs to modernize them > when appropriate. It is a very big task, and in no way can be coordinated in > the way we've been w

Re: KF5 Update Meeting Minutes 2014-w2

2014-01-07 Thread Kevin Ottens
Hello, As a reminder the maintainers list is available there: http://community.kde.org/Frameworks/List People willing to maintain a framework should put their name in the corresponding column. On Tuesday 07 January 2014 16:53:30 Kevin Ottens wrote: > * agateau plans to work on kapidox, [...]

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Kevin Ottens
On Tuesday 07 January 2014 07:22:01 Kevin Ottens wrote: > On Tuesday 07 January 2014 00:45:19 Christoph Feck wrote: > > On Monday 06 January 2014 23:54:46 Kevin Ottens wrote: > > > On Monday 06 January 2014 22:26:27 Alexander Neundorf wrote: > > > > IMO something like proposing the maintainers and

Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

2014-01-07 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/ --- (Updated Jan. 7, 2014, 4:24 p.m.) Review request for kdelibs. Changes -

KF5 Update Meeting Minutes 2014-w2

2014-01-07 Thread Kevin Ottens
Hello everyone, This is the minutes of the Week 48 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, d_ed, mck182, mgraesslin, Riddell, sandsmark, sebas, svuorela and myself. Announcement: * Happy new year! * TP1 is offi

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Thomas Lübking
> On Jan. 7, 2014, 8:51 a.m., Martin Gräßlin wrote: > > how does that behave with the normal locker (that is no screensaver)? "None" is not "blank" - the patch is correct. If a cursor is specified, it is displayed regardless of what window the pointer is in. If None is specified, the normal cu

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Aurélien Gâteau
Le mardi 7 janvier 2014 11:36:34 Alex Merry a écrit : > On 06/01/14 06:52, Kevin Ottens wrote: > > I used to say that the maintenance model of kdelibs was "David Faure by > > default". It's great to have someone like David around, but at the same > > time it's delusional and dangerous to think that

Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

2014-01-07 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/#review46971 --- src/core/global.cpp

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-07 Thread Alex Merry
On 06/01/14 06:52, Kevin Ottens wrote: > I used to say that the maintenance model of kdelibs was "David Faure by > default". It's great to have someone like David around, but at the same time > it's delusional and dangerous to think that he'll always be able to save the > day. This model has to

Re: Review Request 114889: Fix KIO::convertSize(...) returning string with "(I18N_ARGUMENT_MISSING)" inside

2014-01-07 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114889/#review46964 --- This code was originally like this (more or less), but someone

Re: Review Request 114841: Screenlocker: don't set the mouse cursor when grabbing the mouse

2014-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114841/#review46960 --- how does that behave with the normal locker (that is no screen

Re: Review Request 112335: In oxygen: Use the iconSize from mainToolbar

2014-01-07 Thread Hugo Pereira Da Costa
> On Jan. 7, 2014, 5:44 a.m., Àlex Fiestas wrote: > > Hey hugo, is this in somehow now that oxygen uses KStyle again? Hi Alex, yes this has been removed from Oxygen::pixelMetric and moved to kstyle::pixelMetric. However it has the same issue: case PM_ToolBarIconSize: return KIconLo