Re: Review Request 113969: Do not assume every items have the same height

> On April 6, 2014, 7:48 a.m., David Faure wrote: > > kdeui/itemviews/kcategorizedview.cpp, line 795 > > > > > > Coding style comment: some code paths use "break" (which results in > > return QModelIndex() at th

Re: Review Request 113969: Do not assume every items have the same height

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113969/ --- (Updated April 22, 2014, 6:13 a.m.) Review request for kdelibs, David Fau

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 6:41 p.m.) Review request for kde-workspace, Pla

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On March 26, 2014, 11:07 p.m., Thomas Lübking wrote: > > you could sighup or sigusr the greeter process and have it > > > > setImmediateLock(true); > > desktopResized(); > > > > in return > > Wolfgang Bauer wrote: > I agree, this would be a bit nicer... > But I tried it and cannot ge

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56190 --- see minor nitpicks, but in general the patch seems fine and re

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 9:28 p.m.) Review request for kde-workspace, Pla

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? signal() is depre

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 5:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56209 --- ksmserver/screenlocker/greeter/main.cpp

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 9:56 p.m.) Review request for kde-workspace, Pla

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 9:48 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 38 > > > > > > /me would not insist on newline, but there needs to be a blank after > > the "if" > > if

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 5:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/ --- Review request for kde-workspace and Plasma. Bugs: 224200 http://bugs

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

> On April 22, 2014, 7:34 p.m., Thomas Lübking wrote: > > ksmserver/screenlocker/greeter/main.cpp, line 89 > > > > > > ooc.: what's wrong about just: > >signal(SIGUSR1, signalHandler); ? > > Wolfgang Baue

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/ --- (Updated April 22, 2014, 10:41 p.m.) Review request for kde-workspace and

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/ --- (Updated April 22, 2014, 10:34 p.m.) Review request for kde-workspace, Pl

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56219 --- Ship it! from here - see veto condition in the other RR (i do

Re: Review Request 117644: screenlocker: don't leave behind screensaver processes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117644/#review56240 --- would you please also adapt that for plasma-workspace repo (ne

Re: Review Request 117091: Force the screen locker's greeter to show the password input field in case of immediateLock

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117091/#review56241 --- Is that only relevant for the legacy (XSS) locker or also for