Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 14, 2014, 10:38 a.m.) Review request for KDE Software on Ma

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/#review68379 --- komparepart/kompare_part.cpp

Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

2014-10-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120580/ --- Review request for KDE Software on Mac OS X and KDE Runtime. Repository:

Re: Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

2014-10-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120580/ --- (Updated Oct. 14, 2014, 1:58 p.m.) Review request for KDE Software on Mac

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/ --- (Updated Oct. 14, 2014, 1:59 p.m.) Review request for KDE Software on Mac

Gwenview maintainership

2014-10-14 Thread Aurélien Gâteau
For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes Gwenview. Awesome David Edmundson did the grunt work of porting it to KDE Frameworks 5 (Thanks again David!), but

Re: Review Request 120287: [OS X] make kde-workspace build

2014-10-14 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/ --- (Updated Oct. 14, 2014, 6:06 p.m.) Review request for KDE Software on Mac

Re: Review Request 120287: [OS X] make kde-workspace build

2014-10-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120287/#review68404 --- I'm not understanding the changes in Plasma Netbook. Why do yo

Re: Review Request 120287: [OS X] make kde-workspace build

2014-10-14 Thread René J . V . Bertin
> On Oct. 14, 2014, 6:38 p.m., Martin Gräßlin wrote: > > I'm not understanding the changes in Plasma Netbook. Why do you want the > > Netbook shell on OSX while on the other side you disabled the desktop > > shell? AFAIK you cannot replace the shell of OSX, so having Netbook sounds > > pretty

Re: Review Request 120287: [OS X] make kde-workspace build

2014-10-14 Thread Martin Gräßlin
> On Okt. 14, 2014, 6:38 nachm., Martin Gräßlin wrote: > > I'm not understanding the changes in Plasma Netbook. Why do you want the > > Netbook shell on OSX while on the other side you disabled the desktop > > shell? AFAIK you cannot replace the shell of OSX, so having Netbook sounds > > prett

Re: Review Request 120287: [OS X] make kde-workspace build

2014-10-14 Thread René J . V . Bertin
> On Oct. 14, 2014, 6:38 p.m., Martin Gräßlin wrote: > > I'm not understanding the changes in Plasma Netbook. Why do you want the > > Netbook shell on OSX while on the other side you disabled the desktop > > shell? AFAIK you cannot replace the shell of OSX, so having Netbook sounds > > pretty

Re: Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

2014-10-14 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120580/#review68411 --- Ship it! I don't know the code at all, but the #ifdef'd Q_SLO

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 14, 2014, 1:14 p.m.) Review request for kdelibs and Vavelin

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-14 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68412 --- kioslave/trash/kcmtrash.cpp

Re: Gwenview maintainership

2014-10-14 Thread Lukáš Tinkl
Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): For the past few months, I haven't been doing any work on KDE projects, and I don't see this changing for now. It's time for me to step down from the projects I maintain. This includes Gwenview. Awesome David Edmundson did the grunt work of portin

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-14 Thread René J . V . Bertin
> On Oct. 14, 2014, 9:35 p.m., Thomas Lübking wrote: > > kioslave/trash/kcmtrash.cpp, line 220 > > > > > > don't know about the "exotic OS" policy on this, but changes to i18n > > strings need to happen for new

Re: Gwenview maintainership

2014-10-14 Thread Burkhard Lück
Am Dienstag, 14. Oktober 2014, 22:10:19 schrieb Lukáš Tinkl: > Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): > > For the past few months, I haven't been doing any work on KDE projects, > > and I don't see this changing for now. It's time for me to step down > > from the projects I maintain. Thi

Re: Review Request 120554: Initial frameworks port of kompare

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120554/ --- (Updated Oct. 14, 2014, 2:53 p.m.) Review request for kdelibs and Vavelin

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120573/#review68418 --- Nice! Just some comments. kioslave/trash/trashimpl.cpp

Re: Review Request 120573: [OS X] make KDE's trash use the OS X trash

2014-10-14 Thread David Faure
> On Oct. 14, 2014, 7:35 p.m., Thomas Lübking wrote: > > kioslave/trash/kcmtrash.cpp, line 220 > > > > > > don't know about the "exotic OS" policy on this, but changes to i18n > > strings need to happen for new

[UPDATE] kdepimlibs Coverity Scan Report, Oct 14 2014

2014-10-14 Thread Allen Winter
Howdy, Attached is the Coverity Scan report for kdepimlibs 4.14 as of today. You might feel like fixing some of the issues. I filtered out the QtCore and (deprecated) kcal library from this report. Let me know if you find false positives or stuff we can ignore (like in test programs). CID Type

Re: Fwd: PVS-Studio KDE analysis

2014-10-14 Thread Albert Astals Cid
El Divendres, 3 d'octubre de 2014, a les 04:24:01, Christoph Feck va escriure: > On Friday 03 October 2014 02:53:37 Boris Egorov wrote: > > On 10/02/2014 04:45 PM, Ben Cooksley wrote: > > > Okay, can you confirm whether we're allowed to publish this > > > publicly or not? > > > > > > Thanks, > > >

Re: Review Request 120580: [OS X] make KWalletD::connectToScreenSaver a stub function

2014-10-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120580/#review68428 --- > I'd be interested to know the reason for connecting to the s

Re: Gwenview maintainership

2014-10-14 Thread Aurélien Gâteau
On Tue, Oct 14, 2014, at 22:10, Lukáš Tinkl wrote: > Dne 14.10.2014 v 17:51 Aurélien Gâteau napsal(a): > > For the past few months, I haven't been doing any work on KDE projects, > > and I don't see this changing for now. It's time for me to step down > > from the projects I maintain. This includes