Re: branchGroup stable-qt4 Compile failures. Need dev assistance please.

2015-04-29 Thread Friedrich W. H. Kossebau
Hi Scarlett, great work with the update of the KDE CI, thank you for caring for that side of development :) 2 things where you asked for more help: Am Dienstag, 21. April 2015, 13:45:06 schrieb Scarlett Clark: > I know this is an external depend, but I have no experience with it. > Can maybe a

Review Request 123568: Use user-places.xbel instead of bookmarks.xml in places model.

2015-04-29 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123568/ --- Review request for kdelibs. Bugs: 345174 http://bugs.kde.org/show_bug

Re: Review Request 122249: libksysguard: add Kill Window to End Process button and show correct keyboard shortcut

2015-04-29 Thread Gregor Mi
> On April 20, 2015, 10:36 p.m., Thomas Pfeiffer wrote: > > What would likely be confusing is that the two button modes have different > > interaction flows: The "End Process" mode requires to first select a > > process and then press the button to work, whereas the "Kill specific > > window"

Re: Alternative to QDateTime::isDateOnly ?

2015-04-29 Thread David Jarvie
On Tue, April 28, 2015 9:32 pm, Christian Mollekopf wrote: > On Tue, Apr 28, 2015, at 08:47 PM, John Layt wrote: >> On 27 April 2015 at 21:17, Christian Mollekopf >> wrote: >> > >> Using a QDate in the api is probably not an option for PIM though as >> it doesn't have a QTimeZone attached which y

Re: Alternative to QDateTime::isDateOnly ?

2015-04-29 Thread Sandro Knauß
Hey, > One option is the invalid QTime that Aleix mentions. I did have that > in the back of my mind while re-writing QDateTime internals and so > whatever QDate, Qtime and QTimeZone you set should persist in spite of > the QDateTIme overall being invalid. However it's not really a > solution as

Re: Alternative to QDateTime::isDateOnly ?

2015-04-29 Thread Christian Mollekopf
On Wed, Apr 29, 2015, at 12:33 AM, Aleix Pol wrote: > On Tue, Apr 28, 2015 at 10:11 PM, Christian Mollekopf > wrote: > > > > I may be a bit extreme that way, but QDateTime::isValid() would be a > > blocker > > for the isDateOnly() functionality IMO. > > > >> I would most certainly not go into t

Re: Alternative to QDateTime::isDateOnly ?

2015-04-29 Thread Christian Mollekopf
On Tue, Apr 28, 2015, at 08:47 PM, John Layt wrote: > On 27 April 2015 at 21:17, Christian Mollekopf > wrote: > Hey John, > > 1. add isDateOnly functionality to QDateTime > ... > > Opinions following: > > 1. I'm not sure whether it semantically makes sense to have a QDateTime > > without a time

Re: Alternative to QDateTime::isDateOnly ?

2015-04-29 Thread Christian Mollekopf
Hey Aleix, > > What about considering the port to be like: > QDateTime().time().isNull()? > > Even QDateTime::isValid documentation mentions that the date and the > time need to be valid, therefore the time can be invalid. > > With that assumption, I'd say we could even implement > QDateTime::i