Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- Review request for kdelibs and Stephen Kelly. Description --- In addi

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-09 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review37417 --- Have you tried kdepim applications with this patch too? Many of

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:57 p.m.) Review request for kdelibs and Stephen

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
> On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote: > > Have you tried kdepim applications with this patch too? Many of them use > > this class. I just grepped in kdepim, it seems only kmail-mobile makes use of it. It looks like it's working, but I am not familiar with this application so I am

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 13, 2013, 5:59 p.m.) Review request for kdelibs, Michael Boh

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-13 Thread Michael Bohlender
> On Aug. 9, 2013, 12:59 p.m., Stephen Kelly wrote: > > Have you tried kdepim applications with this patch too? Many of them use > > this class. > > Aurélien Gâteau wrote: > I just grepped in kdepim, it seems only kmail-mobile makes use of it. It > looks like it's working, but I am not fam

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 14, 2013, 7:30 a.m.) Status -- This change has been mar

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review37747 --- This review has been submitted with commit 5bab478dd04d85a6017

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review37748 --- Ship it! Ship It! - Stephen Kelly On Aug. 14, 2013, 7:30 a.

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Stephen Kelly
> On Aug. 14, 2013, 7:30 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 5bab478dd04d85a6017c54bc986bcf0b9e235264 by Michael Bohlender to branch > > master. What is this about? Was it pushed to a local clone or so? - Stephen -

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Michael Bohlender
> On Aug. 14, 2013, 7:30 a.m., Commit Hook wrote: > > This review has been submitted with commit > > 5bab478dd04d85a6017c54bc986bcf0b9e235264 by Michael Bohlender to branch > > master. > > Stephen Kelly wrote: > What is this about? Was it pushed to a local clone or so? I fucked up and use

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-14 Thread Aurélien Gâteau
> On Aug. 9, 2013, 2:59 p.m., Stephen Kelly wrote: > > Have you tried kdepim applications with this patch too? Many of them use > > this class. > > Aurélien Gâteau wrote: > I just grepped in kdepim, it seems only kmail-mobile makes use of it. It > looks like it's working, but I am not fami

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-17 Thread Michael Bohlender
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review38038 --- Ship it! sorry for taking so long. I applied the patch and eve

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/#review38042 --- This review has been submitted with commit 14e2ff5b7359d572cd5

Re: Review Request 111953: KLinkItemSelectionModel: synchronize currentIndex

2013-08-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111953/ --- (Updated Aug. 17, 2013, 7:45 p.m.) Status -- This change has been mar