Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- Review request for KDE Base Apps, KDE Software on Mac OS X and kdelibs. R

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/#review67379 --- I assume you'd be better off altering KMenu::addTitle() - or e

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) I agree totally, but for that - I'd have to understand exactly wha

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread Thomas Lübking
> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-24 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-25 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- (Updated Sept. 25, 2014, 4 p.m.) Review request for KDE Base Apps, KDE So

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-25 Thread Thomas Lübking
> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-25 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-25 Thread Thomas Lübking
> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-25 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread Thomas Lübking
> On Sept. 24, 2014, 5:48 nachm., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread René J . V . Bertin
> On Sept. 24, 2014, 7:48 p.m., Thomas Lübking wrote: > > I assume you'd be better off altering KMenu::addTitle() - or even patch Qt > > (QMenu on mach cannot deal w/ widget actions, at least if used on the > > global menubar) > > René J.V. Bertin wrote: > I agree totally, but for that >

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- (Updated Sept. 26, 2014, 7:28 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/#review67495 --- changing this patch to prevent just the call to invalidateBuff

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread Thomas Lübking
> On Sept. 26, 2014, 5:40 nachm., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times th

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread Thomas Lübking
> On Sept. 26, 2014, 5:40 nachm., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times th

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread René J . V . Bertin
> On Sept. 26, 2014, 7:40 p.m., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times the

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-26 Thread Thomas Lübking
> On Sept. 26, 2014, 5:40 nachm., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times th

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-27 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/#review67533 --- How about this modification if I were to modify `KMenu::addTit

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-09-27 Thread Thomas Lübking
> On Sept. 27, 2014, 6:13 nachm., René J.V. Bertin wrote: > > How about this modification if I were to modify `KMenu::addTitle` to do > > something similar to what my patch to Konqueror does, on OS X? I modified > > the code to detect when an action is being added to a KMenu that has a > > KMa

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-10-01 Thread René J . V . Bertin
> On Sept. 26, 2014, 7:40 p.m., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times the

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-10-01 Thread Thomas Lübking
> On Sept. 26, 2014, 5:40 nachm., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times th

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-10-02 Thread René J . V . Bertin
> On Sept. 26, 2014, 7:40 p.m., René J.V. Bertin wrote: > > changing this patch to prevent just the call to > > invalidateBuffer_resizeHelper (and setting isResize=false when that > > function cannot be called) shows something in place of the menu's title > > exactly once. All other times the

Re: Review Request 120355: [OS X] prevent a crash when opening konqueror's Help menu

2014-10-02 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120355/ --- (Updated Oct. 2, 2014, 7:10 p.m.) Review request for KDE Base Apps, KDE S