Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

2016-03-23 Thread Dominik Haumann
> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive.

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-03-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 51 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-03-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 51 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-03-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-03-23 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 23 Mar 2016 15:19:40 + Build duration: 6 min 5 sec CHANGE SET Revision

Re: Review Request 127473: Add const variant to getter method

2016-03-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127473/ --- (Updated March 23, 2016, 3:25 p.m.) Status -- This change has been

Re: Review Request 127473: Add const variant to getter method

2016-03-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127473/#review93901 --- Ship it! Ship It! - David Edmundson On March 23, 2016,

Review Request 127473: Add const variant to getter method

2016-03-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127473/ --- Review request for KDE Frameworks. Repository: attica Description

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
> On March 23, 2016, 12:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread Aleix Pol Gonzalez
> On March 23, 2016, 1:07 p.m., Marco Martin wrote: > > In theory using QQuickWidget is the correct way, but... > > That widget is really not reliable, it has a structural (and probably > > unfixable at least on x11) problem in which anybody calling winId() > > anywhere on any window on the

Re: Review Request 126949: Remove Air and Oxygen themes

2016-03-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126949/ --- (Updated March 23, 2016, 12:15 p.m.) Status -- This change has been

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/#review93895 --- In theory using QQuickWidget is the correct way, but... That

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

2016-03-23 Thread Thomas Lübking
> On März 21, 2016, 8:42 nachm., Dominik Haumann wrote: > > ping > > Marco Martin wrote: > +1, to me the latest version could be fine, would like a last word from > windowmanager people tough As mentioned, I ceased to care. I'm providing input while phasing out (and promise it to be on

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

2016-03-23 Thread Marco Martin
> On March 23, 2016, 10:51 a.m., Marco Martin wrote: > > Ship It! (as in, ignore my comment about the option, I'm fine with the added option now) - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

2016-03-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127154/#review93888 --- Ship it! Ship It! - Marco Martin On Feb. 24, 2016,

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- (Updated March 23, 2016, 10:29 a.m.) Review request for KDE Frameworks.

Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127469/ --- Review request for KDE Frameworks. Bugs: 359124