KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 322 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/322/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 09 Mar 2020 04:49:16 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D27910: Make sure warning output is enabled before testing if the correct warning is printed

apol added a comment. Is it passing on the CI because somehow we enable warnings on there? https://build.kde.org/job/Frameworks/job/karchive/job/kf5-qt5%20SUSEQt5.13/60/testReport/ REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D27910 To: sandsmark, dfaure Cc:

D27883: Register spawned applications as an independent cgroups

apol added inline comments. INLINE COMMENTS > kprocessrunner.cpp:51 > + > +std::once_flag dbusTypesRegistered; > + This could be in the function scope as static. > kprocessrunner.cpp:281 > +{ > +if (!qEnvironmentVariableIsSet("KDE_APPLICATIONS_AS_SCOPE")) { > +return; Who defines

D27927: Use more flexible shebang

sitter accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27927 To: tcberner, #freebsd, sitter, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27926: [breeze-icons] Add flameshot tray icons

ndavis accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27926: [breeze-icons] Add flameshot tray icons

ndavis added a comment. It's a systray icon, so it doesn't need to have a 16px version REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27936: Windows: Add suport for file date creation

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27936 AFFECTED

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 77235. meven added a comment. Get code ready for 5.69, I really HOPE that the last time I have to do this, remove a few qDebug(), add some test assertions, make test more reliable REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27882: Move KProcessRunner into it's own file

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27882 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27860: [server] Add some sub-surface life cycle signals

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > surface_interface.h:348 > +/** > + * Emitted whenever a new child sub-surface @p subSurface is added. > + */ Include @since REPOSITORY R127 KWayland

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

meven added a comment. In D27833#622353 , @apol wrote: > What's the use-case? Originally D27934 was needing it, but in the end this is not needed anymore, so I think it should be best to postpone

D27913: Icons for emoji categories

guoyunhe added a comment. In D27913#624159 , @ngraham wrote: > If we do this, then won't the category icons look different from the actual emoji icons when using a font where the emojis look different? Hi @ngraham , the main idea is to

D27463: KconfigXT: Add a value attribute to Enum field choices

This revision was automatically updated to reflect the committed changes. Closed by commit R237:ec207330d5bd: KconfigXT: Add a value attribute to Enum field choices (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77225=77226

D27463: KconfigXT: Add a value attribute to Enum field choices

meven updated this revision to Diff 77225. meven added a comment. Rebase on master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=77077=77225 BRANCH arcpatch-D27463_2 REVISION DETAIL https://phabricator.kde.org/D27463 AFFECTED FILES

D27926: [breeze-icons] Add flameshot tray icons

axionl marked an inline comment as done. axionl added a comment. In D27926#624240 , @ngraham wrote: > Nice! > > Do you think you could also make 16px versions? Sorry, maybe not. The 16px space is too small to get the correct angle to

D25315: KDirModel: implement showing a root node for the requested URL

ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kdirmodel.h:79 > That sounds more confusing to me, depending on how one thinks about all this. > > There's nothing special about the first child compared to other direct > children, one misinterpretation of your suggested

D27926: [breeze-icons] Add flameshot tray icons

ngraham added a comment. Nice! Do you think you could also make 16px versions? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D25315: KDirModel: implement showing a root node for the requested URL

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kdirmodel.h:79 > I suggest: > s/its children/the first child/ OR > s/at its children/directly at the first child/ That sounds more confusing to me, depending on how one thinks about all

D25315: KDirModel: implement showing a root node for the requested URL

dfaure updated this revision to Diff 77224. dfaure added a comment. Add missing braces around one-line if() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25315?vs=77155=77224 BRANCH 2019_11_kdirmodel_root REVISION DETAIL

D27926: [breeze-icons] Add flameshot tray icons

axionl updated this revision to Diff 77223. axionl added a comment. Update flameshot tray icon. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27926?vs=77197=77223 REVISION DETAIL https://phabricator.kde.org/D27926 AFFECTED FILES

D27909: Move barcode image scaling logic to AbstractBarcode

svuorela accepted this revision. This revision is now accepted and ready to land. REPOSITORY R280 Prison BRANCH pending REVISION DETAIL https://phabricator.kde.org/D27909 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/85/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 08 Mar 2020 16:21:18 + Build duration: 1 min 5 sec and counting JUnit Tests Name:

D27562: [kcmcontrols] Respect header/footer visibility

This revision was automatically updated to reflect the committed changes. Closed by commit R296:0dad857cddfb: [kcmcontrols] Respect header/footer visibility (authored by nicolasfella). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27562?vs=76136=77221

D27562: [kcmcontrols] Respect header/footer visibility

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH rhv REVISION DETAIL https://phabricator.kde.org/D27562 To: nicolasfella, #plasma, mart, ngraham Cc: iasensio, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27927: Use more flexible shebang

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27927 To: tcberner, #freebsd, sitter, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27913: Icons for emoji categories

ngraham added a comment. If we do this, then won't the category icons look different from the actual emoji icons when using a font where the emojis look different? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27913 To: guoyunhe, #breeze Cc: ngraham,

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D27932 To: cordlandwehr, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27932: NetworkManager-Qt: Convert license headers to SPDX expressions

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Herald added a reviewer: jgrulich. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX expressions and add license files as

D27926: [breeze-icons] Add flameshot tray icons

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks, this will be nice to have once the issue identified in my comment is resolved. INLINE COMMENTS > flameshot-tray.svg:2 > + xmlns="http://www.w3.org/2000/svg;> > +

D27929: CMake syntax fixes

turbov created this revision. turbov added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. turbov requested review of this revision. REVISION SUMMARY - add some more variables introduced in CMake

D27928: [VIM Mode] Add g g commands

gikari edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D27928: [VIM Mode] Add g g commands

gikari added reviewers: Kate, Frameworks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D27928: [VIM Mode] Add g g commands

gikari created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gikari requested review of this revision. REVISION SUMMARY Add twin commands for `gj` and `gk` for usage with standard arrow keys. BUG: 418486 TEST PLAN