D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: kde-frameworks-devel, ngraham, LeGast00n, cblack, michaelh, ahmadsamir, bruns, vkrause

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. I opened a bug but I didn’t have any answer so far. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. It’s perso at hack-libre dot org REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham, kde-frameworks-devel, jraleigh, GB_2, ragreen, Pitel,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 50581. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=50580=50581 REVISION DETAIL https://phabricator.kde.org/D15189 AFFECTED FILES kioclient/kioclient.cpp To: achauvel, #frameworks, dfaure,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 50580. achauvel added a comment. Added an `ifdef` so that it could compile with older version of KIO. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=47987=50580 REVISION DETAIL

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. @dfaure I don’t see how to do that, since there does not seem to have such `ifdef` in the actual codebase. However I can make `set(KF5_MIN_VERSION "5.55.0")` instead of 5.54.0 in the `CMakeLists.txt`. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D17727: Get default web browser from xdg-settings if it’s not set in KDE

achauvel abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17727 To: achauvel Cc: ngraham, rdieter, kde-frameworks-devel, michaelh, bruns

D17726: Add helper function to disable redirections (useful for kde-open)

achauvel updated this revision to Diff 48028. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17726?vs=47986=48028 REVISION DETAIL https://phabricator.kde.org/D17726 AFFECTED FILES src/widgets/krun.cpp src/widgets/krun.h src/widgets/krun_p.h To:

D17371: [KRun] when asked to open link in external browser, fall back to mimeapps.list if nothing is set in kdeglobals

achauvel added a comment. I think it’s better than what I proposed (without knowing about yours) in D17727 . INLINE COMMENTS > krun.cpp:1421-1431 > + > +// If a default browser isn't set in kdeglobals, fall back to > mimeapps.list > +if

D17727: Get default web browser from xdg-settings if it’s not set in KDE

achauvel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. achauvel requested review of this revision. REVISION SUMMARY This greatly speed up opening URLs from kde-open (avoid ~1 second of wait) REPOSITORY R241 KIO REVISION DETAIL

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 47987. achauvel added a comment. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Uses new function added in https://phabricator.kde.org/D17726 REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D17726: Add helper function to disable redirections (useful for kde-open)

achauvel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. achauvel requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D15189 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17726

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. Is anybody interested in helping me figure out how I can implement that properly? I would be glad to start working again on it, but I don’t know enough about KIO right now. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 40897. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=40784=40897 REVISION DETAIL https://phabricator.kde.org/D15189 AFFECTED FILES src/widgets/krun.cpp To: achauvel, #frameworks, dfaure, cfeck Cc:

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 40784. achauvel edited the test plan for this revision. achauvel added a comment. Previous was incorrect, this one works. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=40782=40784 REVISION DETAIL

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. achauvel requested review of this revision. REVISION SUMMARY Fix https://bugs.kde.org/show_bug.cgi?id=354246 REPOSITORY R241 KIO REVISION DETAIL

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. To add an option to use the fallback of a Plasma theme (i.e. to disable shadows and transparency). REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. Should I open a bug report on https://bugs.kde.org? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10910 To: achauvel Cc: ngraham, #frameworks, michaelh

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel added a comment. > FWIW, Breeze shadows can now be turned off entirely (System Settings > Application Style > Window Decorations > Breeze > Click on the little Settings button in the corner > Shadows > Size: None), so the only thing this really adds is opaque backgrounds.

D10910: Add unshadowed opaque variants for Breeze Light and Dark desktop themes

achauvel created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. achauvel requested review of this revision. REVISION SUMMARY It seems to be quite popular since it got more than 1000 downloads on kde.store.org in a week,