D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Marco Martin
mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add a "level" api that has the same meaning as in the Kirigami Heading component, This m

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Marco Martin
mart added a comment. F6443889: image.png with a QWidget KCM F6443893: image.png REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg Cc: kde-framewor

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Nathaniel Graham
ngraham added a comment. In D17190#366840 , @mart wrote: > F6443889: image.png > > with a QWidget KCM > F6443893: image.png In those screenshots, "< Fonts

D17190: Add level api from Kirigami.Heading

2018-11-27 Thread Marco Martin
mart added a comment. In D17190#366854 , @ngraham wrote: > In those screenshots, "< Fonts" is basically just a named back button. Should it really have the same size and visual weight as the active KCMs' title? I think so, it's the title

D17190: Add level api from Kirigami.Heading

2018-11-28 Thread Fabian Riethmayer
fabianr edited the summary of this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

2018-11-28 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH phab/heading REVISION DETAIL https://phabricator.kde.org/D17190 To: mart, #plasma, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17190: Add level api from Kirigami.Heading

2018-11-29 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R236:d3964629cbff: Add level api from Kirigami.Heading (authored by mart). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17190?vs=46322&id=46463 REVISION DETAIL

D17190: Add level api from Kirigami.Heading

2018-12-27 Thread Christoph Feck
cfeck added inline comments. INLINE COMMENTS > ktitlewidget.cpp:132 > titleFrame->setBackgroundRole(QPalette::Base); > +titleFrame->setContentsMargins(0, 0, 0, 0); > Setting 0 margins effectively disables the frame; the Breeze setting to keep frames around page titles is no longer re