D19395: [KJobWidget] remove deprecated method

2019-02-28 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R288:07d140f5a206: [KJobWidget] remove deprecated method (authored by mlaurent). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52793&id=52801 REVISION DET

D19395: [KJobWidget] remove deprecated method

2019-02-28 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R288 KJobWidgets BRANCH remove_deprecated_method (branched from master) REVISION DETAIL https://phabricator.kde.org/D19395 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent updated this revision to Diff 52793. mlaurent added a comment. Disable deprecated method until 5.12 as requested REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19395?vs=52765&id=52793 BRANCH remove_deprecated_method (branched from master) R

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent marked an inline comment as done. REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D19395 To: mlaurent, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:47 > SOVERSION 5) > - > +#add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) > Since it's commented out, it's

D19395: [KJobWidget] remove deprecated method

2019-02-27 Thread Laurent Montel
mlaurent created this revision. mlaurent added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY remove deprecated method REPOSITORY R288 KJobWidgets BRANCH remove_deprecated