This revision was automatically updated to reflect the committed changes.
Closed by commit R242:adb999898842: [PlasmaComponents3] Vertically center
button text as well (authored by ngraham).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
BRANCH
vertically-center-button-text (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D21502
To: ngraham, #plasma, broulik
Cc: broulik, apol,
ngraham marked 3 inline comments as done.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21502
To: ngraham, #plasma
Cc: broulik, apol, kde-frameworks-devel, michaelh, ngraham, bruns
ngraham updated this revision to Diff 58931.
ngraham added a comment.
Always fill height
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21502?vs=58917=58931
BRANCH
vertically-center-button-text (branched from master)
REVISION DETAIL
ngraham added a comment.
Oh haha
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21502
To: ngraham, #plasma
Cc: broulik, apol, kde-frameworks-devel, michaelh, ngraham, bruns
broulik added inline comments.
INLINE COMMENTS
> ngraham wrote in Button.qml:56
> Apparently not, because explicitly adding this does make a difference, as the
> before-and-after images show.
I think he was asking why not just make it `true` unconditionally
REPOSITORY
R242 Plasma Framework
ngraham added inline comments.
INLINE COMMENTS
> apol wrote in Button.qml:56
> With it being a RowLayout, shouldn't fillHeight be always true?
Apparently not, because explicitly adding this does make a difference, as the
before-and-after images show.
REPOSITORY
R242 Plasma Framework
apol added inline comments.
INLINE COMMENTS
> Button.qml:56
> Layout.fillWidth: !icon.visible
> +Layout.fillHeight: !icon.visible
> visible: text.length > 0
With it being a RowLayout, shouldn't fillHeight be always true?
REPOSITORY
R242 Plasma Framework
ngraham edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21502
To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21502
To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham edited the summary of this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D21502
To: ngraham, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
ngraham created this revision.
ngraham added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The PC3 Button didn't have `Layout.FillWidth: true` set, so button text was
not
12 matches
Mail list logo