D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. In D23927#548607 , @kossebau wrote: > Any chance you could pik this up and complete? Thing is, the deprecated API is also still used internally,so anything but deprecated. Actually the new API calls the "deprecated"

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. Any chance you could pik this up and complete? Thing is, the deprecated API is also still used internally,so anything but deprecated. Actually the new API calls the "deprecated" one. I just tried to adapt the code to the new deprecation macros (forgot that

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. In D23927#537585 , @vkrause wrote: > Moving even more towards a QIcon rather than a QPixmap API is a good thing for sure, I agree on that. I don't think going back is justified here though, especially since the

D23927: Improve naming of KTitleWidget icon methods

vkrause added a comment. In D23927#537583 , @kossebau wrote: > When going to adapt some code to follow the deprecation, I now look though at some inconsistency in the API: > > - KTitleWidget has a property "pixmap" > - the `setPixmap`

D23927: Improve naming of KTitleWidget icon methods

kossebau added a comment. When going to adapt some code to follow the deprecation, I now look though at some inconsistency in the API: - KTitleWidget has a property "pixmap" - the `setPixmap` methods all set this pixmap, with overloads for convenience - `setIcon` is without a getter

D23927: Improve naming of KTitleWidget icon methods

vkrause added inline comments. INLINE COMMENTS > dhaumann wrote in ktitlewidget.h:45 > Could you also fix the documentation here? This is typically copy & pasted > later ;) Sorry, race condition on the push :) Will do that in a separate commit. REPOSITORY R236 KWidgetsAddons REVISION

D23927: Improve naming of KTitleWidget icon methods

dhaumann added inline comments. INLINE COMMENTS > ktitlewidget.h:45 > titleWidget->setText(i18n("Title")); > titleWidget->setPixmap(QIcon::fromTheme("screen").pixmap(22, 22)); > * @endcode Could you also fix the documentation here? This is typically copy & pasted later ;) REPOSITORY

D23927: Improve naming of KTitleWidget icon methods

This revision was automatically updated to reflect the committed changes. Closed by commit R236:10753c73409d: Improve naming of KTitleWidget icon methods (authored by vkrause). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23927?vs=65979=65983

D23927: Improve naming of KTitleWidget icon methods

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23927 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23927: Improve naming of KTitleWidget icon methods

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY As suggested by David in D23899 . REPOSITORY