This revision was automatically updated to reflect the committed changes.
Closed by commit R241:66837e4c049d: GIT_SILENT clang-format kpasswdserver.*
(authored by ahmadsamir).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28097?vs=78157=78158
REVISION DETAIL
ahmadsamir updated this revision to Diff 78157.
ahmadsamir added a comment.
Rebase on master
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28097?vs=78155=78157
BRANCH
l-kpasswdserver-clang-format (branched from master)
REVISION DETAIL
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Thanks. Let's do manual changes separately :-)
REPOSITORY
R241 KIO
BRANCH
l-kpasswdserver-clang-format (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D28097
To:
ahmadsamir updated this revision to Diff 78155.
ahmadsamir retitled this revision from "GIT_SILENT clang-format kpasswdserver.*
plus some manual changes" to "GIT_SILENT clang-format kpasswdserver.*".
ahmadsamir added a comment.
Verbatim
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ahmadsamir updated this revision to Diff 78154.
ahmadsamir added a comment.
clang-format only, less prone to errors, as the level of stupidity of the
tool is locked at the compile time of the tool (unlike manual changes)
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kpasswdserver.cpp:249
> #ifdef HAVE_KF5WALLET
> -if (!result &&
> -!m_walletDisabled &&
> -(info.username.isEmpty() ||
ahmadsamir created this revision.
ahmadsamir added reviewers: Frameworks, dfaure, apol.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.
REVISION SUMMARY
Braces around if blocks.
TEST PLAN
make && ctest
REPOSITORY
R241 KIO
BRANCH
