croick created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
- currently it is not possible to get a signal from the icon border menu when
no mark is clicked, which prevents the creation of
dhaumann added a comment.
The patch looks good, but is there a concrete use-case?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6541
To: croick, #ktexteditor
Cc: dhaumann, kwrite-devel, #frameworks
croick added a comment.
In https://phabricator.kde.org/D6541#123758, @dhaumann wrote:
> The patch looks good, but is there a concrete use-case?
I tried to implement a custom context menu for breakpoints and bookmarks in
https://phabricator.kde.org/tag/kdevelop/, mainly for display
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
I think the patch is fine.
REPOSITORY
R39 KTextEditor
BRANCH
defaultmarker
REVISION DETAIL
https://phabricator.kde.org/D6541
To: croick, #ktexteditor, dhaumann
Cc: dhaumann, kwr
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:3b202d26f2ee: Emit signals from icon border when no mark
was clicked (authored by croick).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6541?vs=16282&id=16605