Re: Review Request 119323: fix auth race condition

2014-07-21 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 21, 2014, 8:47 p.m.) Status -- This change has been ma

Re: Review Request 119323: fix auth race condition

2014-07-18 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62631 --- Ship it! I have been using this for 4.x and 5.x for a while w

Re: Review Request 119323: fix auth race condition

2014-07-17 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 17, 2014, 11:23 a.m.) Review request for KDE Frameworks, Hr

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62547 --- FYI, this probably needs to go in kdelibs too as the issue is

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62546 --- src/backends/polkit-1/Polkit1Backend.cpp

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Hrvoje Senjan
> On July 16, 2014, 6:06 p.m., Luca Beltrame wrote: > > I ran the (few) autotests, and those also pass. I can't test it runtime, > > will do so later hopefully. a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =) also polkit reports system-bus-name is used - Hrvoje

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62520 --- I ran the (few) autotests, and those also pass. I can't test i

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- (Updated July 16, 2014, 4:05 p.m.) Review request for KDE Frameworks, Hrv

Review Request 119323: fix auth race condition

2014-07-16 Thread Martin Tobias Holmedahl Sandsmark
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/ --- Review request for KDE Frameworks and Martin Bříza. Repository: kauth D