---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/
---
Review request for KDE Frameworks and Michael Palimaka.
Repository: kdesu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/#review3
---
Ship it!
Ship It!
- Jeremy Whiting
On March 19, 2015, 4:59
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/#review9
---
as in other similar requests: -2 from my side
- Martin Gräßli
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
To extend: I think the way is wrong. If it now builds on MacOS the required is
wrong. It should be an optional find_package properly ifdefed.
- Martin
> On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
Actually, you
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
> On March 20, 2015, 8:07 a.m., Martin Gräßlin wrote:
> > as in other similar requests: -2 from my side
>
> Martin Gräßlin wrote:
> To extend: I think the way is wrong. If it now builds on MacOS the
> required is wrong. It should be an optional find_package properly ifdefed.
>
> Christoph
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123075/
---
(Updated June 1, 2017, 1:20 p.m.)
Status
--
This change has been dis
15 matches
Mail list logo
